* [PATCH v2] virtio: reject shm region if length is zero
@ 2025-05-11 11:44 Sami
2025-05-11 15:36 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Sami @ 2025-05-11 11:44 UTC (permalink / raw)
To: mst; +Cc: jasowang, xuanzhuo, eperezma, virtualization, linux-kernel,
Sami Uddin
From: Sami Uddin <sami.md.ko@gmail.com>
Prevent usage of shared memory regions where the length is zero,
as such configurations are not valid and may lead to unexpected behavior.
Signed-off-by: Sami Uddin <sami.md.ko@gmail.com>
---
v2:
- Fixed coding style issue: added space after 'if' statement
include/linux/virtio_config.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index 169c7d367fac..b641b16d42ef 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -329,6 +329,8 @@ static inline
bool virtio_get_shm_region(struct virtio_device *vdev,
struct virtio_shm_region *region, u8 id)
{
+ if (region->len == 0)
+ return false;
if (!vdev->config->get_shm_region)
return false;
return vdev->config->get_shm_region(vdev, region, id);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] virtio: reject shm region if length is zero
2025-05-11 11:44 [PATCH v2] virtio: reject shm region if length is zero Sami
@ 2025-05-11 15:36 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2025-05-11 15:36 UTC (permalink / raw)
To: SamiUddinsami.md.ko
Cc: jasowang, xuanzhuo, eperezma, virtualization, linux-kernel,
Sami Uddin
On Sun, May 11, 2025 at 09:14:28PM +0930, SamiUddinsami.md.ko@gmail.com wrote:
> From: Sami Uddin <sami.md.ko@gmail.com>
>
> Prevent usage of shared memory regions where the length is zero,
> as such configurations are not valid and may lead to unexpected behavior.
>
> Signed-off-by: Sami Uddin <sami.md.ko@gmail.com>
> ---
> v2:
> - Fixed coding style issue: added space after 'if' statement
>
> include/linux/virtio_config.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index 169c7d367fac..b641b16d42ef 100644
> --- a/include/linux/virtio_config.h
> +++ b/include/linux/virtio_config.h
> @@ -329,6 +329,8 @@ static inline
> bool virtio_get_shm_region(struct virtio_device *vdev,
> struct virtio_shm_region *region, u8 id)
> {
> + if (region->len == 0)
> + return false;
if (!region->len)
is more idiomatic
> if (!vdev->config->get_shm_region)
> return false;
> return vdev->config->get_shm_region(vdev, region, id);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-11 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-11 11:44 [PATCH v2] virtio: reject shm region if length is zero Sami
2025-05-11 15:36 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox