Re: [PATCH] vhost-scsi: Fix log flooding with target does not exist errors

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Sat, Jun 07, 2025 at 12:18:15PM -0500, Mike Christie wrote:
> As part of the normal initiator side scanning the guest's scsi layer
> will loop over all possible targets and send an inquiry. Since the
> max number of targets for virtio-scsi is 256, this results in 255
> error messages about targets not existing. When there's more than 1
> vhost-scsi device, then you get N * 255 log messages.
> 
> It looks like the log message was added by accident in:
> 
> commit 09d7583294aa ("vhost/scsi: Use common handling code in request
> queue handler")
> 
> The patch was just making some coce common but added the vq_err call
> and I'm guessing the patch author forgot to enable the vq_err call
> (vq_err is implemented by pr_debug which defaults to off). So this
> patch removes the call since it's expected to hit this path during
> device discovery.
> 
> Fixes: 09d7583294aa ("vhost/scsi: Use common handling code in request queue handler")
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
>  drivers/vhost/scsi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]