From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566D91A9B3D; Sun, 6 Jul 2025 11:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751802893; cv=none; b=pWT96dSovGTBWVwPRxH469K3jkiZQ/WHSNXroY/cZRgsv1URtNGSdL1L1KnH6Ln41q99/9AjYpxga/InoejLwUUTdB05zkymwFXUVE9GTY7SjurZfoCgLmjK46MFHWrIlFJrHAhVjoBKdwMzaXweukkpx0Ra0TPkR5TDy1mvq/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751802893; c=relaxed/simple; bh=SPvc0Gg9JBc6QNuHQkLZL5zu7Rjosnn7svEd2viLK9s=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=GNC5UHgTZMSeKfeGLdHA9TD0FAdIfQN7fG2xFT3jd38+out8H4OYqst6Zv4yhRuUhMWEUQlMx6J2TnaYaC2/aC1Ye37KCkWkI2GbwE1mj0V1oN3U9qNTk0/azZ7kJD4Mk86smGpTdpWuFn4/4q1NW5Q+uQPZCZvvNTk+BwE9mq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NitheQ0n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NitheQ0n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86C6EC4CEED; Sun, 6 Jul 2025 11:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751802892; bh=SPvc0Gg9JBc6QNuHQkLZL5zu7Rjosnn7svEd2viLK9s=; h=Subject:To:Cc:From:Date:From; b=NitheQ0nz+6keaeTvoaFWK23VZUo/M9SuYyM/+J76skioTJFQuU3JYh3KGubWT65a PdeGt/5BtDM9ZDThBN1DMDDUZ6ad3OZL6iVVRRQPckf8tEuAVCPbJN5p6eZHQCuInU UhZw6MvFKgU7hnqFPyN4B3jK6HEFdWarY/tvgZdI= Subject: Patch "vsock/vmci: Clear the vmci transport packet properly when initializing it" has been added to the 5.10-stable tree To: bryan-bt.tan@broadcom.com,davem@davemloft.net,edumazet@google.com,gregkh@linuxfoundation.org,harshavardhana.sa@broadcom.com,horms@kernel.org,kuba@kernel.org,pabeni@redhat.com,sgarzare@redhat.com,stable@kernel.org,virtualization@lists.linux.dev,vishnu.dasa@broadcom.com Cc: From: Date: Sun, 06 Jul 2025 13:54:34 +0200 Message-ID: <2025070634-snore-harmful-2266@gregkh> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled vsock/vmci: Clear the vmci transport packet properly when initializing it to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: vsock-vmci-clear-the-vmci-transport-packet-properly-when-initializing-it.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 223e2288f4b8c262a864e2c03964ffac91744cd5 Mon Sep 17 00:00:00 2001 From: HarshaVardhana S A Date: Tue, 1 Jul 2025 14:22:54 +0200 Subject: vsock/vmci: Clear the vmci transport packet properly when initializing it From: HarshaVardhana S A commit 223e2288f4b8c262a864e2c03964ffac91744cd5 upstream. In vmci_transport_packet_init memset the vmci_transport_packet before populating the fields to avoid any uninitialised data being left in the structure. Cc: Bryan Tan Cc: Vishnu Dasa Cc: Broadcom internal kernel review list Cc: Stefano Garzarella Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Simon Horman Cc: virtualization@lists.linux.dev Cc: netdev@vger.kernel.org Cc: stable Signed-off-by: HarshaVardhana S A Signed-off-by: Greg Kroah-Hartman Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Acked-by: Stefano Garzarella Link: https://patch.msgid.link/20250701122254.2397440-1-gregkh@linuxfoundation.org Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -119,6 +119,8 @@ vmci_transport_packet_init(struct vmci_t u16 proto, struct vmci_handle handle) { + memset(pkt, 0, sizeof(*pkt)); + /* We register the stream control handler as an any cid handle so we * must always send from a source address of VMADDR_CID_ANY */ @@ -131,8 +133,6 @@ vmci_transport_packet_init(struct vmci_t pkt->type = type; pkt->src_port = src->svm_port; pkt->dst_port = dst->svm_port; - memset(&pkt->proto, 0, sizeof(pkt->proto)); - memset(&pkt->_reserved2, 0, sizeof(pkt->_reserved2)); switch (pkt->type) { case VMCI_TRANSPORT_PACKET_TYPE_INVALID: Patches currently in stable-queue which might be from harshavardhana.sa@broadcom.com are queue-5.10/vsock-vmci-clear-the-vmci-transport-packet-properly-when-initializing-it.patch