public inbox for virtualization@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com, virtualization@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH V4 00/19] virtio_ring in order support
Date: Thu, 24 Jul 2025 14:39:58 +0800	[thread overview]
Message-ID: <20250724064017.26058-1-jasowang@redhat.com> (raw)

Hello all:

This sereis tries to implement the VIRTIO_F_IN_ORDER to
virtio_ring. This is done by introducing virtqueue ops so we can
implement separate helpers for different virtqueue layout/features
then the in-order were implemented on top.

Tests shows 2%-19% imporvment with packed virtqueue PPS with KVM guest
vhost-net/testpmd on the host.

Changes since V3:

- Re-benchmark with the recent vhost-net in order support
- Rename the batched used id and length
- Other minor tweaks

Changes since V2:

- Fix build warning when DEBUG is enabled

Changes since V1:

- use const global array of function pointers to avoid indirect
  branches to eliminate retpoline when mitigation is enabled
- fix used length calculation when processing used ids in a batch
- fix sparse warnings

Please review.

Thanks

Jason Wang (19):
  virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx()
  virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants
  virtio_ring: unify logic of virtqueue_poll() and more_used()
  virtio_ring: switch to use vring_virtqueue for virtqueue resize
    variants
  virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare
    variants
  virtio_ring: switch to use vring_virtqueue for virtqueue_add variants
  virtio: switch to use vring_virtqueue for virtqueue_add variants
  virtio_ring: switch to use vring_virtqueue for enable_cb_prepare
    variants
  virtio_ring: use vring_virtqueue for enable_cb_delayed variants
  virtio_ring: switch to use vring_virtqueue for disable_cb variants
  virtio_ring: switch to use vring_virtqueue for detach_unused_buf
    variants
  virtio_ring: use u16 for last_used_idx in virtqueue_poll_split()
  virtio_ring: introduce virtqueue ops
  virtio_ring: determine descriptor flags at one time
  virtio_ring: factor out core logic of buffer detaching
  virtio_ring: factor out core logic for updating last_used_idx
  virtio_ring: factor out split indirect detaching logic
  virtio_ring: factor out split detaching logic
  virtio_ring: add in order support

 drivers/virtio/virtio_ring.c | 902 +++++++++++++++++++++++++++--------
 1 file changed, 690 insertions(+), 212 deletions(-)

-- 
2.39.5


             reply	other threads:[~2025-07-24  6:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  6:39 Jason Wang [this message]
2025-07-24  6:39 ` [PATCH V4 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-07-24  6:40 ` [PATCH V4 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-07-24  6:40 ` [PATCH V4 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 07/19] virtio: " Jason Wang
2025-07-24  6:40 ` [PATCH V4 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants Jason Wang
2025-07-24  6:40 ` [PATCH V4 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() Jason Wang
2025-07-24  6:40 ` [PATCH V4 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-07-24  6:40 ` [PATCH V4 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-07-24  6:40 ` [PATCH V4 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-07-24  6:40 ` [PATCH V4 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-07-24  6:40 ` [PATCH V4 17/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-07-24  6:40 ` [PATCH V4 18/19] virtio_ring: factor out split " Jason Wang
2025-07-24  6:40 ` [PATCH V4 19/19] virtio_ring: add in order support Jason Wang
2025-07-25 13:15   ` Michael S. Tsirkin
2025-07-25 20:56   ` Thorsten Blum
2025-07-28  3:23     ` Jason Wang
2025-07-28 13:41 ` [PATCH V4 00/19] virtio_ring " Eugenio Perez Martin
2025-07-29  2:35   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250724064017.26058-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox