From: Greg KH <gregkh@linuxfoundation.org>
To: Abinash Singh <abinashsinghlalotra@gmail.com>
Cc: amit@kernel.org, arnd@arndb.de, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/virtio_console : refactor resource cleanup to use scope-based helpers
Date: Mon, 4 Aug 2025 17:50:52 +0100 [thread overview]
Message-ID: <2025080440-foam-oversight-53b5@gregkh> (raw)
In-Reply-To: <20250804113020.620352-1-abinashsinghlalotra@gmail.com>
On Mon, Aug 04, 2025 at 05:00:20PM +0530, Abinash Singh wrote:
> This refactors the 'alloc_buf' function to replace traditional goto-based
> error handling with scope-based cleanup helpers.
>
> No functional changes intended.
Please only do this in new code being submitted, no need to change any
existing code unless it is needed.
> Signed-off-by: Abinash Singh <abinashsinghlalotra@gmail.com>
> ---
> drivers/char/virtio_console.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
Did you test this?
thanks,
greg k-h
prev parent reply other threads:[~2025-08-04 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 11:30 [PATCH] drivers/char/virtio_console : refactor resource cleanup to use scope-based helpers Abinash Singh
2025-08-04 16:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025080440-foam-oversight-53b5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abinashsinghlalotra@gmail.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox