Re: [PATCH net] virtio_net: adjust the execution order of function `virtnet_close` during freeze

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 15 Aug 2025 14:06:15 +0800 Junnan Wu wrote:
> On Fri, 15 Aug 2025 13:38:21 +0800 Jason Wang <jasowang@redhat.com> wrote
> > On Fri, Aug 15, 2025 at 10:24 AM Junnan Wu <junnan01.wu@samsung.com> wrote:  
> > > Sorry, I basically mean that the tx napi which caused by
> > > userspace will not be scheduled during suspend, others can not be
> > > guaranteed, such as unfinished packets already in tx vq etc.
> > >
> > > But after this patch, once `virtnet_close` completes,
> > > both tx and rq napi will be disabled which guarantee their napi
> > > will not be scheduled in future. And the tx state will be set to
> > > "__QUEUE_STATE_DRV_XOFF" correctly in `netif_device_detach`.  
> > 
> > Ok, so the commit mentioned by fix tag is incorrect.  
> 
> Yes, you are right. The commit of this fix tag is the first commit I
> found which add function `virtnet_poll_cleantx`. Actually, we are not
> sure whether this issue appears after this commit.
> 
> In our side, this issue is found by chance in version 5.15.
> 
> It's hard to find the key commit which cause this issue
> for reason that the reproduction of this scenario is too complex.

I think the problem needs to be more clearly understood, and then it
will be easier to find the fixes tag. At the face of it the patch
makes it look like close() doesn't reliably stop the device, which
is highly odd.