From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99AD037DEEE for ; Thu, 21 Aug 2025 20:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806918; cv=none; b=oxzqQ82ZG1iWK2svmxMqG5cWvhSwamD8S+vN4hyMvRUwzT5J34mROrOZCE/Bm0ABfvJwfCovdMexQSbuxxLj+RW0hdxo9qQCwdM6LpJ49fCoZm7DH+OPGI3wrjui0HAv3bypzULi2C9eyotDbA1dp6pqXyBjkYm0QxlgadV2Ogg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806918; c=relaxed/simple; bh=u2IvbkeQqipan9xn1FH8uDngo5kbDeDcvQE423cldao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=e+nVuHorS1ltuFEePJfjrXTkboXmNezeJVfdgx9TDttql5VoZw551XXPnPfmSyRiiL0Eswzgv8lWa/CYkOwWStBZZe/Id1e/3xrtr93jQUEiA4lMtTe36sfLmivWAMT0keGrgiZN1bsWFzfuksvFihUDNG3UYnMsYAJPfGjbxzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B3sr6LQt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B3sr6LQt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uIthYg0x+2djveHghlw2Jb9wmVGYKVQz7R4ULrPQfiU=; b=B3sr6LQtuUYizDjn6wgyn4F8MIpcNMkOlNbstW7Lrh1yOQfJh6FyQI1fBivC8m3n1PEpt4 or15qoSGc60hlmpqErc5TRvoNumZc2o1aWXhvOjmhZGsMkhh4ujr9jVxpNuvhFhsQF64Pd VV+9mXFF+oho47PjJV9PGd1WQovW/gk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-bdMGIc8BP6ml2kGknB8wYw-1; Thu, 21 Aug 2025 16:08:33 -0400 X-MC-Unique: bdMGIc8BP6ml2kGknB8wYw-1 X-Mimecast-MFC-AGG-ID: bdMGIc8BP6ml2kGknB8wYw_1755806913 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45a1b05a59cso9779585e9.1 for ; Thu, 21 Aug 2025 13:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806913; x=1756411713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIthYg0x+2djveHghlw2Jb9wmVGYKVQz7R4ULrPQfiU=; b=CBsGUeLUqZ7eyGmHjN5E3JlPFcTPJ3m42zDzgDNB2KHlAXxrDGpBdElB/IDTMwgQIq ahk+vvcKcX+dy1JB8yxasWUMdzC24a8N8FkNXnRZ+w6WcTskC1NIOvAxUEWMrp/x0nHV wKdFm8LoP2WMpUGZEZkhXYrWUJcZ4k5AtOYzU+GfE4nsFmCY+4+Hum8E6JU9uAaD1iuf p46yV7U67kQXNYwrQsfG/doZWTQuydBOrxWpo4S5R03zFVsZ/7FjOKiVl0YLlkya4+Ud wc/X6p4YoC/Vfn8vTmrIdTR2iSNZsEs9yUSPsNBOqnzrZmMyZKD/7dr6mIf5btL6v5TA 9qXA== X-Forwarded-Encrypted: i=1; AJvYcCWGMseMPKVQczclAsspf/f1YH1x96UZueLoUYGC4pJnjGI4k7CL1fST0CE17Uf/QSqonoIXg20Hq9RWsntcfA==@lists.linux.dev X-Gm-Message-State: AOJu0YwcQKblYwa9xZQNbASu2hLmKyhqzqToTEtbTxDOAQtX2mGCtm4v Uv+XUJJzwm7zmstbHYqbI4M6W5rUod2vg+Ub06TAyGH4obzJyEZva6Sa3RcANZ8+gAgLrQGTYZO T+3jvFiRk00QAouvcYpOIAFYbHxxrv43FeybOrhI6nMErincnVfJuE44EDyA7WdCCbrB/ X-Gm-Gg: ASbGncvWcfl6qH6+dkeJGgqSVGIPWPNLIUruRjFKYIzXUqX4RliHEZ0kuDAF++Lrcaq ZLF0ZvROrNa1Tyiq/KUgXLqCeYhDR08ZsGDCs9w6R23bgiIEOJYulbGJKXOZkeXhbDNJg/MU1bh BNoOZnZdRNSW1Ohr0c5TQv/18VN+rtdafgdeC65JPS3BSZeAz9XSP7R9puYVAwSuYnyt9H+llbf PXQE5WYa2HMMY07sSmUtCz/iYMCDJ7JzXTin/57nCZmPOzV0hPDsDCjOA2BdSMPKCWtcpDoIA3E wnVYfld7+e4XHbi3+4jv0lWL7Fs+2q/K4CA1Odc1gPfEXQRHPlxVJ+tlQGXhlVaGNeE+2eN+iVl 5PDmtu9GW90SkwX/qyeQEtA== X-Received: by 2002:a05:6000:40de:b0:3a5:783f:528a with SMTP id ffacd0b85a97d-3c5dcefee22mr195299f8f.59.1755806912333; Thu, 21 Aug 2025 13:08:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRe/VOMg0cdir08bDTWMwU06A85Ixelypa7wMbtHpunFYS8URS38ofNnAO5nDnYJmoWLlWSQ== X-Received: by 2002:a05:6000:40de:b0:3a5:783f:528a with SMTP id ffacd0b85a97d-3c5dcefee22mr195231f8f.59.1755806911819; Thu, 21 Aug 2025 13:08:31 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b50f16eb1sm7598185e9.3.2025.08.21.13.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:31 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Brett Creeley , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 30/35] vfio/pci: drop nth_page() usage within SG entry Date: Thu, 21 Aug 2025 22:06:56 +0200 Message-ID: <20250821200701.1329277-31-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Oz4e-FtbPTY4FPn8_L-Egg8MJERHqKp79sYvMtlXPtM_1755806913 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true It's no longer required to use nth_page() when iterating pages within a single SG entry, so let's drop the nth_page() usage. Cc: Brett Creeley Cc: Jason Gunthorpe Cc: Yishai Hadas Cc: Shameer Kolothum Cc: Kevin Tian Cc: Alex Williamson Signed-off-by: David Hildenbrand --- drivers/vfio/pci/pds/lm.c | 3 +-- drivers/vfio/pci/virtio/migrate.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c index f2673d395236a..4d70c833fa32e 100644 --- a/drivers/vfio/pci/pds/lm.c +++ b/drivers/vfio/pci/pds/lm.c @@ -151,8 +151,7 @@ static struct page *pds_vfio_get_file_page(struct pds_vfio_lm_file *lm_file, lm_file->last_offset_sg = sg; lm_file->sg_last_entry += i; lm_file->last_offset = cur_offset; - return nth_page(sg_page(sg), - (offset - cur_offset) / PAGE_SIZE); + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; } cur_offset += sg->length; } diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c index ba92bb4e9af94..7dd0ac866461d 100644 --- a/drivers/vfio/pci/virtio/migrate.c +++ b/drivers/vfio/pci/virtio/migrate.c @@ -53,8 +53,7 @@ virtiovf_get_migration_page(struct virtiovf_data_buffer *buf, buf->last_offset_sg = sg; buf->sg_last_entry += i; buf->last_offset = cur_offset; - return nth_page(sg_page(sg), - (offset - cur_offset) / PAGE_SIZE); + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; } cur_offset += sg->length; } -- 2.50.1