From: Simon Horman <horms@kernel.org>
To: Daniel Jurgens <danielj@nvidia.com>
Cc: netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
alex.williamson@redhat.com, virtualization@lists.linux.dev,
pabeni@redhat.com, parav@nvidia.com, shshitrit@nvidia.com,
yohadt@nvidia.com, Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH net-next v2 01/11] virtio-pci: Expose generic device capability operations
Date: Tue, 9 Sep 2025 16:29:47 +0100 [thread overview]
Message-ID: <20250909152947.GA20205@horms.kernel.org> (raw)
In-Reply-To: <20250908164046.25051-2-danielj@nvidia.com>
On Mon, Sep 08, 2025 at 11:40:36AM -0500, Daniel Jurgens wrote:
...
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index db31fc6f4f1f..a6e121b6f1f1 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -12,6 +12,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/completion.h>
> #include <linux/virtio_features.h>
> +#include <linux/virtio_admin.h>
>
> /**
> * struct virtqueue - a queue to register buffers for sending or receiving.
> @@ -161,6 +162,7 @@ struct virtio_device {
> struct virtio_device_id id;
> const struct virtio_config_ops *config;
> const struct vringh_config_ops *vringh_config;
> + const struct virtio_admin_ops *admin_ops;
nit: Please consider also adding admin_ops to the Kernel doc for
struct virtio_device.
> struct list_head vqs;
> VIRTIO_DECLARE_FEATURES(features);
> void *priv;
...
next prev parent reply other threads:[~2025-09-09 15:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 16:40 [PATCH net-next v2 00/11] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 01/11] virtio-pci: Expose generic device capability operations Daniel Jurgens
2025-09-09 15:29 ` Simon Horman [this message]
2025-09-09 17:56 ` Dan Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 02/11] virtio-pci: Expose object create and destroy API Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 03/11] virtio_net: Create virtio_net directory Daniel Jurgens
2025-09-09 19:27 ` kernel test robot
2025-09-08 16:40 ` [PATCH net-next v2 04/11] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 05/11] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 06/11] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 07/11] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 08/11] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 09/11] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 10/11] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-09-08 16:40 ` [PATCH net-next v2 11/11] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909152947.GA20205@horms.kernel.org \
--to=horms@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=danielj@nvidia.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=yishaih@nvidia.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).