virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com
Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH V7 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants
Date: Thu, 25 Sep 2025 18:36:51 +0800	[thread overview]
Message-ID: <20250925103708.44589-3-jasowang@redhat.com> (raw)
In-Reply-To: <20250925103708.44589-1-jasowang@redhat.com>

Those variants are used internally so let's switch to use
vring_virtqueue as parameter to be consistent with other internal
virtqueue helpers.

Acked-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/virtio/virtio_ring.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 73790593523a..fed3962411a1 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -919,11 +919,10 @@ static unsigned int virtqueue_enable_cb_prepare_split(struct virtqueue *_vq)
 	return last_used_idx;
 }
 
-static bool virtqueue_poll_split(struct virtqueue *_vq, unsigned int last_used_idx)
+static bool virtqueue_poll_split(struct vring_virtqueue *vq,
+				 unsigned int last_used_idx)
 {
-	struct vring_virtqueue *vq = to_vvq(_vq);
-
-	return (u16)last_used_idx != virtio16_to_cpu(_vq->vdev,
+	return (u16)last_used_idx != virtio16_to_cpu(vq->vq.vdev,
 			vq->split.vring.used->idx);
 }
 
@@ -1844,9 +1843,8 @@ static unsigned int virtqueue_enable_cb_prepare_packed(struct virtqueue *_vq)
 	return vq->last_used_idx;
 }
 
-static bool virtqueue_poll_packed(struct virtqueue *_vq, u16 off_wrap)
+static bool virtqueue_poll_packed(struct vring_virtqueue *vq, u16 off_wrap)
 {
-	struct vring_virtqueue *vq = to_vvq(_vq);
 	bool wrap_counter;
 	u16 used_idx;
 
@@ -2611,8 +2609,8 @@ bool virtqueue_poll(struct virtqueue *_vq, unsigned int last_used_idx)
 		return false;
 
 	virtio_mb(vq->weak_barriers);
-	return vq->packed_ring ? virtqueue_poll_packed(_vq, last_used_idx) :
-				 virtqueue_poll_split(_vq, last_used_idx);
+	return vq->packed_ring ? virtqueue_poll_packed(vq, last_used_idx) :
+				 virtqueue_poll_split(vq, last_used_idx);
 }
 EXPORT_SYMBOL_GPL(virtqueue_poll);
 
-- 
2.31.1


  parent reply	other threads:[~2025-09-25 10:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 10:36 [PATCH V7 00/19] virtio_ring in order support Jason Wang
2025-09-25 10:36 ` [PATCH V7 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-09-25 10:36 ` Jason Wang [this message]
2025-09-25 10:36 ` [PATCH V7 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-09-25 10:36 ` [PATCH V7 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 07/19] virtio: switch to use vring_virtqueue for virtqueue_get variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-09-25 10:36 ` [PATCH V7 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
2025-09-25 10:37 ` [PATCH V7 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants Jason Wang
2025-09-25 10:37 ` [PATCH V7 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() Jason Wang
2025-09-28 18:27   ` David Laight
2025-09-29  8:22     ` Michael S. Tsirkin
2025-10-09  5:55       ` Jason Wang
2025-09-25 10:37 ` [PATCH V7 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-09-29  8:23   ` Michael S. Tsirkin
2025-09-25 10:37 ` [PATCH V7 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-09-25 10:37 ` [PATCH V7 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-10-20 23:06   ` Michael S. Tsirkin
2025-10-21  3:57     ` Jason Wang
2025-09-25 10:37 ` [PATCH V7 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-09-25 10:37 ` [PATCH V7 17/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-09-25 10:37 ` [PATCH V7 18/19] virtio_ring: factor out split " Jason Wang
2025-09-25 10:37 ` [PATCH V7 19/19] virtio_ring: add in order support Jason Wang
2025-09-26 14:47   ` Michael S. Tsirkin
2025-10-14  3:50     ` Jason Wang
2025-10-14  9:13   ` Michael S. Tsirkin
2025-10-15  4:42     ` Jason Wang
2025-10-01 11:30 ` [PATCH V7 00/19] virtio_ring " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925103708.44589-3-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).