From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 19/19] virtio_ring: add in order support
Date: Mon, 20 Oct 2025 06:11:29 -0400 [thread overview]
Message-ID: <20251020061049-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251020071003.28834-20-jasowang@redhat.com>
On Mon, Oct 20, 2025 at 03:10:03PM +0800, Jason Wang wrote:
> @@ -168,7 +172,7 @@ struct vring_virtqueue_packed {
> struct vring_virtqueue;
>
> struct virtqueue_ops {
> - int (*add)(struct vring_virtqueue *_vq, struct scatterlist *sgs[],
> + int (*add)(struct vring_virtqueue *vq, struct scatterlist *sgs[],
> unsigned int total_sg, unsigned int out_sgs,
> unsigned int in_sgs, void *data,
> void *ctx, bool premapped, gfp_t gfp);
BTW this should really be part of 13/19, not here.
--
MST
next prev parent reply other threads:[~2025-10-20 10:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 7:09 [PATCH V8 00/19] virtio_ring in order support Jason Wang
2025-10-20 7:09 ` [PATCH V8 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-10-20 7:09 ` [PATCH V8 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-10-20 7:09 ` [PATCH V8 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 07/19] virtio: switch to use vring_virtqueue for virtqueue_get variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants Jason Wang
2025-10-20 7:09 ` [PATCH V8 12/19] virtio_ring: switch to use unsigned int for virtqueue_poll_packed() Jason Wang
2025-10-20 16:15 ` Michael S. Tsirkin
2025-10-21 3:53 ` Jason Wang
2025-10-20 7:09 ` [PATCH V8 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-10-20 10:41 ` Michael S. Tsirkin
2025-10-21 3:28 ` Jason Wang
2025-10-20 15:20 ` Michael S. Tsirkin
2025-10-21 3:52 ` Jason Wang
2025-10-20 7:09 ` [PATCH V8 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-10-20 15:18 ` Michael S. Tsirkin
2025-10-21 3:50 ` Jason Wang
2025-10-20 7:09 ` [PATCH V8 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-10-20 7:10 ` [PATCH V8 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-10-20 7:10 ` [PATCH V8 17/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-10-20 16:17 ` Michael S. Tsirkin
2025-10-21 3:55 ` Jason Wang
2025-10-20 18:05 ` Michael S. Tsirkin
2025-10-20 7:10 ` [PATCH V8 18/19] virtio_ring: factor out split " Jason Wang
2025-10-20 15:18 ` Michael S. Tsirkin
2025-10-21 3:36 ` Jason Wang
2025-10-21 8:27 ` Michael S. Tsirkin
2025-10-22 4:00 ` Jason Wang
2025-10-22 5:44 ` Michael S. Tsirkin
2025-10-20 7:10 ` [PATCH V8 19/19] virtio_ring: add in order support Jason Wang
2025-10-20 9:08 ` Michael S. Tsirkin
2025-10-21 3:21 ` Jason Wang
2025-10-20 9:13 ` Michael S. Tsirkin
2025-10-21 3:25 ` Jason Wang
2025-10-20 10:11 ` Michael S. Tsirkin [this message]
2025-10-21 3:26 ` Jason Wang
2025-10-20 15:19 ` [PATCH V8 00/19] virtio_ring " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020061049-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).