* [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling
@ 2025-11-01 19:43 Mike Christie
2025-11-01 20:55 ` Chaitanya Kulkarni
2025-11-06 6:39 ` Jason Wang
0 siblings, 2 replies; 3+ messages in thread
From: Mike Christie @ 2025-11-01 19:43 UTC (permalink / raw)
To: virtualization, mst, jasowang, eperezma, kvm; +Cc: Mike Christie
If we fail to attach to a cgroup we are leaking the id. This adds
a new goto to free the id.
Fixes: 7d9896e9f6d0 ("vhost: Reintroduce kthread API and add mode selection")
Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
drivers/vhost/vhost.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 8570fdf2e14a..e6df5bb4932b 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -804,11 +804,13 @@ static int vhost_kthread_worker_create(struct vhost_worker *worker,
ret = vhost_attach_task_to_cgroups(worker);
if (ret)
- goto stop_worker;
+ goto free_id;
worker->id = id;
return 0;
+free_id:
+ xa_erase(&dev->worker_xa, id);
stop_worker:
vhost_kthread_do_stop(worker);
return ret;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling
2025-11-01 19:43 [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling Mike Christie
@ 2025-11-01 20:55 ` Chaitanya Kulkarni
2025-11-06 6:39 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2025-11-01 20:55 UTC (permalink / raw)
To: Mike Christie, virtualization@lists.linux-foundation.org,
mst@redhat.com, jasowang@redhat.com, eperezma@redhat.com,
kvm@vger.kernel.org
On 11/1/25 12:43, Mike Christie wrote:
> If we fail to attach to a cgroup we are leaking the id. This adds
> a new goto to free the id.
>
> Fixes: 7d9896e9f6d0 ("vhost: Reintroduce kthread API and add mode selection")
> Signed-off-by: Mike Christie<michael.christie@oracle.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling
2025-11-01 19:43 [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling Mike Christie
2025-11-01 20:55 ` Chaitanya Kulkarni
@ 2025-11-06 6:39 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2025-11-06 6:39 UTC (permalink / raw)
To: Mike Christie; +Cc: virtualization, mst, eperezma, kvm
On Sun, Nov 2, 2025 at 3:45 AM Mike Christie
<michael.christie@oracle.com> wrote:
>
> If we fail to attach to a cgroup we are leaking the id. This adds
> a new goto to free the id.
>
> Fixes: 7d9896e9f6d0 ("vhost: Reintroduce kthread API and add mode selection")
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-06 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-01 19:43 [PATCH 1/1] vhost: Fix kthread worker cgroup failure handling Mike Christie
2025-11-01 20:55 ` Chaitanya Kulkarni
2025-11-06 6:39 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).