From: "Michael S. Tsirkin" <mst@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH] virtio_ring: kernel-doc: fix function name, function param warnings
Date: Sun, 16 Nov 2025 01:33:17 -0500 [thread overview]
Message-ID: <20251116013303-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251115224534.3832145-1-rdunlap@infradead.org>
On Sat, Nov 15, 2025 at 02:45:33PM -0800, Randy Dunlap wrote:
> Add description for the function parameter @vaddr.
> Correct the function name in a kernel-doc comment.
>
> Fixes these warning:
> WARNING: drivers/virtio/virtio_ring.c:3174 function parameter 'vaddr' not
> described in 'virtqueue_map_free_coherent'
> WARNING: drivers/virtio/virtio_ring.c:3308 expecting prototype for
> virtqueue_mapping_error(). Prototype was for virtqueue_map_mapping_error()
> instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks, already fixed in my tree.
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Cc: Eugenio Pérez <eperezma@redhat.com>
> Cc: virtualization@lists.linux.dev
> ---
> drivers/virtio/virtio_ring.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20251114.orig/drivers/virtio/virtio_ring.c
> +++ linux-next-20251114/drivers/virtio/virtio_ring.c
> @@ -3166,6 +3166,7 @@ EXPORT_SYMBOL_GPL(virtqueue_map_alloc_co
> * @vdev: the virtio device we are talking to
> * @map: metadata for performing mapping
> * @size: the size of the buffer
> + * @vaddr: virtual address of the buffer
> * @map_handle: the mapped address that needs to be freed
> *
> */
> @@ -3299,7 +3300,7 @@ void virtqueue_unmap_single_attrs(const
> EXPORT_SYMBOL_GPL(virtqueue_unmap_single_attrs);
>
> /**
> - * virtqueue_mapping_error - check dma address
> + * virtqueue_map_mapping_error - check dma address
> * @_vq: the struct virtqueue we're talking about.
> * @addr: DMA address
> *
prev parent reply other threads:[~2025-11-16 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 22:45 [PATCH] virtio_ring: kernel-doc: fix function name, function param warnings Randy Dunlap
2025-11-16 6:33 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251116013303-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).