* [PATCH] virtio_pci: drop kernel.h
@ 2025-11-18 23:08 Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-11-18 23:08 UTC (permalink / raw)
To: linux-kernel
Cc: Yishai Hadas, Alex Williamson, Jason Wang, Xuan Zhuo,
Eugenio Pérez, Alex Williamson, virtualization
UAPI headers really have no business pulling in kernel.h
Drop it - it does not seem to be needed, either.
Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
Cc: "Yishai Hadas" <yishaih@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/virtio_pci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
index c691ac210ce2..d1b31efc4d7d 100644
--- a/include/uapi/linux/virtio_pci.h
+++ b/include/uapi/linux/virtio_pci.h
@@ -40,7 +40,6 @@
#define _LINUX_VIRTIO_PCI_H
#include <linux/types.h>
-#include <linux/kernel.h>
#ifndef VIRTIO_PCI_NO_LEGACY
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_pci: drop kernel.h
2025-11-18 23:08 [PATCH] virtio_pci: drop kernel.h Michael S. Tsirkin
@ 2025-11-19 0:57 ` Chaitanya Kulkarni
2025-11-19 2:51 ` Jason Wang
2025-11-19 5:17 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-11-19 0:57 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel@vger.kernel.org
Cc: Yishai Hadas, Alex Williamson, Jason Wang, Xuan Zhuo,
Eugenio Pérez, Alex Williamson,
virtualization@lists.linux.dev
On 11/18/25 15:08, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas"<yishaih@nvidia.com>
> Cc: Alex Williamson<alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
Indeed:
linux-block (discard-ret-value) # grep "kernel\.h" include/uapi/linux/* -ir
include/uapi/linux/virtio_pci.h:#include <linux/kernel.h>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_pci: drop kernel.h
2025-11-18 23:08 [PATCH] virtio_pci: drop kernel.h Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni
@ 2025-11-19 2:51 ` Jason Wang
2025-11-19 5:17 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2025-11-19 2:51 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Yishai Hadas, Alex Williamson, Xuan Zhuo,
Eugenio Pérez, Alex Williamson, virtualization
On Wed, Nov 19, 2025 at 7:08 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas" <yishaih@nvidia.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/uapi/linux/virtio_pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_pci: drop kernel.h
2025-11-18 23:08 [PATCH] virtio_pci: drop kernel.h Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni
2025-11-19 2:51 ` Jason Wang
@ 2025-11-19 5:17 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-11-19 5:17 UTC (permalink / raw)
To: linux-kernel
Cc: Yishai Hadas, Alex Williamson, Jason Wang, Xuan Zhuo,
Eugenio Pérez, Alex Williamson, virtualization
On Tue, Nov 18, 2025 at 06:08:37PM -0500, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas" <yishaih@nvidia.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Oops. Double checked and it's no good - I just had virtio disabled in
the config by mistake. Pls ignore.
> ---
> include/uapi/linux/virtio_pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index c691ac210ce2..d1b31efc4d7d 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -40,7 +40,6 @@
> #define _LINUX_VIRTIO_PCI_H
>
> #include <linux/types.h>
> -#include <linux/kernel.h>
>
> #ifndef VIRTIO_PCI_NO_LEGACY
>
> --
> MST
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-19 5:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 23:08 [PATCH] virtio_pci: drop kernel.h Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni
2025-11-19 2:51 ` Jason Wang
2025-11-19 5:17 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).