* [PATCH] virtio_ring: code cleanup in detach_buf_split
@ 2025-11-26 3:40 zhangdongchuan
2025-11-28 2:24 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: zhangdongchuan @ 2025-11-26 3:40 UTC (permalink / raw)
To: mst, jasowang, xuanzhuo, eperezma
Cc: virtualization, linux-kernel, zhangdongchuan
Since the return value of vring_unmap_one_split() is exactly
vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is
redundant. Assign vring_unmap_one_split() to i instead.
Since vq->split.desc_extra is assigned to extra, use extra[i].next
instead of vq->split.desc_extra[i].next to improve readability.
No change in functionality.
Signed-off-by: zhangdongchuan <zhangdongchuan@eswincomputing.com>
---
drivers/virtio/virtio_ring.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 7b6205253b46..0cbf3419a645 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -764,13 +764,12 @@ static void detach_buf_split(struct vring_virtqueue *vq, unsigned int head,
i = head;
while (vq->split.vring.desc[i].flags & nextflag) {
- vring_unmap_one_split(vq, &extra[i]);
- i = vq->split.desc_extra[i].next;
+ i = vring_unmap_one_split(vq, &extra[i]);
vq->vq.num_free++;
}
vring_unmap_one_split(vq, &extra[i]);
- vq->split.desc_extra[i].next = vq->free_head;
+ extra[i].next = vq->free_head;
vq->free_head = head;
/* Plus final descriptor */
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] virtio_ring: code cleanup in detach_buf_split
2025-11-26 3:40 [PATCH] virtio_ring: code cleanup in detach_buf_split zhangdongchuan
@ 2025-11-28 2:24 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2025-11-28 2:24 UTC (permalink / raw)
To: zhangdongchuan@eswincomputing.com
Cc: mst, xuanzhuo, eperezma, virtualization, linux-kernel
On Wed, Nov 26, 2025 at 11:41 AM zhangdongchuan@eswincomputing.com
<zhangdongchuan@eswincomputing.com> wrote:
>
> Since the return value of vring_unmap_one_split() is exactly
> vq->split.desc_extra[i].next, 'i = vq->split.desc_extra[i].next' is
> redundant. Assign vring_unmap_one_split() to i instead.
>
> Since vq->split.desc_extra is assigned to extra, use extra[i].next
> instead of vq->split.desc_extra[i].next to improve readability.
>
> No change in functionality.
>
> Signed-off-by: zhangdongchuan <zhangdongchuan@eswincomputing.com>
> ---
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-28 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 3:40 [PATCH] virtio_ring: code cleanup in detach_buf_split zhangdongchuan
2025-11-28 2:24 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).