From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011037.outbound.protection.outlook.com [40.107.208.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D6F346FD7 for ; Wed, 26 Nov 2025 19:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764185801; cv=fail; b=lA7hrNK5v4MzfjCGUzjdAM7DK8TZCv013c+8Awv0z5sUCxZLeK3ItFYuIHXfkz9/OQkYHEE2avnVq974acjDiQKLg8hqknwSf51u/BbpYdxNEqcm0UgJaO2TD7dO1pdoaWgI+YKZavJrK4Vmp9W5XQqvi19l0icwNOsH/rqPp0c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764185801; c=relaxed/simple; bh=dfOh2zP3H7CTzCGYqNhUeDAD71rk4GX1cOtfy6cDv1I=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WM4HnUQcOpxZhLnyBcbnhMmecTum7EXaRXs33B3Yv77Zp5sl9Pd40y8tqSuBv9qBBseGk7jldf2xV8l1QCYKGKQr7+gFEtFkx0aDC6N/EHFRfv+Ll0IGSWMjIFtMeHVpuXfll9y27DXa6qLBwl5x+ZNa77PyrnEVJOMfTHD4GUI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SkmMVWFs; arc=fail smtp.client-ip=40.107.208.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SkmMVWFs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lR3AKrx1UWZNlnTqdef6xIGudKK7KXs8y8XM7sTMOgpV2BX222S+YWfAXFEPyaZmcvbxq9Lyc2b2HQqn9Kzeot3c11l6NXGvJtf2aG5AuNMu7JDmItsDHjHeXB2wMEe2SEs2PepHGx4D1dCL1D9fc8FKUVuG/T+3uCiI2FkxpPOeu4cYZLiOdD4rTewPeEqAdPg5IWwsaruIQ1QmlxBS+0qTfWZjUOq2M6/3NmlA36ztKMVVm61390ltLElLJl5zmG0j/P9Esdhp65NEcSj/v8vkmi3KR+LuMy9viXvl0kBMi8hOisnY2ep8GxK8gSG5iJnufgcf+flkrYG4sANsnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=szrtro3WbDnfaF9OGTr+focsylgV2ifB5ScH6O0O3hE=; b=hcLjmK5snAA+/x0tkn9lC5wRm43ked6s4lxyx2jlej2kIOyyrqLSRGateydSXXTCIn30SJ8ogJCwxDLJvyDCEQucCY8ISe1X/5WExL/0o9TUI+p5UrxdRm/q2VpXPzmedBt5/aQIziIXVSjwUu2huqH5VA0GFMkd6ja4xupsVFTdBf+HXgso2F/7GphdKZ5o0VYBhd2m9BgGX6L77CuXlvk5+Gc+9/dmtWYX3K7JMDOymI4I8sucM36zUIto+ZygtiH2fNdY6N6jpP/MkOTuUxXmk+YAtGbMSnBcBWnFL5Vx/IZTJYeQDPGttg0bggY+ydwsl8suliMbRqhpjKZHwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szrtro3WbDnfaF9OGTr+focsylgV2ifB5ScH6O0O3hE=; b=SkmMVWFssmxmlkMDAZG+ab+fYq855K/HvA7k9t2mKyuiGYKLAO/Z8rqvc699+iWn+6A/7TbDO0kr8NJ1PpmdFEWoreAtiBaze0rmtaYYq/h5PhuEaAIKHxZVEHVirG0Esq6F72Dq4LFKrft5SlXt+AWWOI2g8cUyagODdjCa9FT587AH/eCzWvnFSkKIWicZM1iINuB+862qgdXjNBhg3qjWpVXrcKVpMjEyBgiS8eKDXg5m0EfSurEEJFPhD7ZJr0n20PSQNBzdnkGw4WdRCF1zq0LlUYFVXlMkGiCwSdzMMZ1GFeq0acn+Uyg5SjVUptIvHSK81GDxd79ltWoxOg== Received: from CH2PR18CA0029.namprd18.prod.outlook.com (2603:10b6:610:4f::39) by MN2PR12MB4128.namprd12.prod.outlook.com (2603:10b6:208:1dd::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.11; Wed, 26 Nov 2025 19:36:27 +0000 Received: from CH2PEPF00000141.namprd02.prod.outlook.com (2603:10b6:610:4f:cafe::4c) by CH2PR18CA0029.outlook.office365.com (2603:10b6:610:4f::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.11 via Frontend Transport; Wed, 26 Nov 2025 19:36:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH2PEPF00000141.mail.protection.outlook.com (10.167.244.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Wed, 26 Nov 2025 19:36:27 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 26 Nov 2025 11:36:07 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 26 Nov 2025 11:36:06 -0800 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Wed, 26 Nov 2025 11:36:05 -0800 From: Daniel Jurgens To: , , , CC: , , , , , , , , , , , "Daniel Jurgens" Subject: [PATCH net-next v13 07/12] virtio_net: Implement layer 2 ethtool flow rules Date: Wed, 26 Nov 2025 13:35:34 -0600 Message-ID: <20251126193539.7791-8-danielj@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251126193539.7791-1-danielj@nvidia.com> References: <20251126193539.7791-1-danielj@nvidia.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000141:EE_|MN2PR12MB4128:EE_ X-MS-Office365-Filtering-Correlation-Id: 331022b2-ca4b-489c-e2ae-08de2d231758 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Z/aKMJFq5nFeLa4LCZyHjZ6HgIFxaQ4ACplEWRxab+0yT4eZuxkuFcbLQPJK?= =?us-ascii?Q?Z1JbY+n8JUwER+AGIIChCeE0X+SRng/LaF2H9vVIIQAMWc58IFg1XHg1o0a+?= =?us-ascii?Q?wJuH41DWFvuA4ElgXDz86EHMHOHQswMlWTecArnAXmaiLORFXfff4aMXBHhl?= =?us-ascii?Q?Fc20yRCiyotDkYzHvYRa4fl6M7h2er4W6fhTizFQQPx7i1eM5RPt8LvfbjFw?= =?us-ascii?Q?AUq1V3fNVd4SxYw++gI7KwheXX4u2hc2cpG+1kefvS4UOknxhgvGoLYpPVR5?= =?us-ascii?Q?N6MW1oYq70uZxJPrunFAVxHGZLZeQgTQG/f9oLi4htncPFF1pU+YnYs57Ez/?= =?us-ascii?Q?HBXUmrVYbpa3V+bzg5f4W+lg2WzHi65xx5C6HzxqriQOOab/8WnX0j7Q3GmM?= =?us-ascii?Q?sn2+qiniVuiZcx7AkkiAaMzQ+RCJlm7IZCPMelysO5dPIEBq15nYfFhcVkei?= =?us-ascii?Q?ZfGNkuwCQ/qojJEM6TuUGViY9Im96MmJM+m96see+KvUNcNvKNObNwwLJT3d?= =?us-ascii?Q?JR02oNsbpaf6Tf45DrQElO0KLadeFOTlslPRa+riDcxozNtZoSjp+pRoStef?= =?us-ascii?Q?IJqXcIrZcdnRZHonQd4n/n1ORCqp6ZnE+rajgXdxOtkr33U96JjlDmz98S6e?= =?us-ascii?Q?xWXeDt3Z8hp+AMFgNEZ+OlXtpyKh/ckjnSUBNlZfT30CSjaG5LHSsXTxtLqV?= =?us-ascii?Q?JzZTp4vQUnW2BbsBwjrl4drauxdnua3u9iisuOnaRZ3tZLCuohky06E5XJW8?= =?us-ascii?Q?WbGjwZDlPmukVGgTA8kKTlsfqNzrJbDCo/Qo5q9kIKbej32XvI/e/1QARYr+?= =?us-ascii?Q?mZN6yMi1Wi/Kngqc7pXbtXiHDCjjFahXaMEVPUK/liu8MiCu9KlzF6D75kYJ?= =?us-ascii?Q?c7gXh4IS1DCaGBtSDufha3cseh0oPpUDUp2sSCo5Ex+vsrm4EtrBgGFoBm1H?= =?us-ascii?Q?VSuaKLJJPmAgus3ffCYyixCGSc9lKyH/mctVrfTljpeehC9Ro6570VMx3ZIe?= =?us-ascii?Q?v8QefcvViiME+cM5Sq0fdhownPhZFpFfVST0+5sBWjjoX+QOJfmRlRxEIP5x?= =?us-ascii?Q?2Jpr+COJx2SMEYb+zpg9CtDFwMMQ24LQukeWSmc68HTlJe1VAnhQw+g/Ti8u?= =?us-ascii?Q?4lp9+a875lYswMQ/dXGX5DTYC9MHoFAXtH3iHMeir+QHSkijx70Hv/HPrnr2?= =?us-ascii?Q?hmUoht8QzUIvd9G4exJBe27n3YaPX7N5681PQxHwvayyr4FRKBFXjjRhjp4f?= =?us-ascii?Q?3HRzaVuIaDTHqnJh7qP5UdH9dt2kTPu0+ww7qujg8IXeefK7ZIiD0sBbXHxB?= =?us-ascii?Q?wup2isBFzNOqYuQD0PXSxWAhwV+FRkcwOCAlXMkPOZU2tMFPvb/bHhbaPkKs?= =?us-ascii?Q?tu+4nWypc/h5gxSLW/qRxymOz6lnZUQn7cB9yl+SWkAjS140CwSMowiBNGK6?= =?us-ascii?Q?lMddNF6AeY/evuSebxVOGsY5kntuoU2hgcULuAADLgKy7H3TEq6pd9wwqofD?= =?us-ascii?Q?Tknaa7y/uMv/M8U6D8/4FF+wQlpOr1gbDt1xZsncZgNMyyOMFE1cQ9gWCI/A?= =?us-ascii?Q?tgqmS42tHiydHe80cN8=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2025 19:36:27.0560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 331022b2-ca4b-489c-e2ae-08de2d231758 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000141.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4128 Filtering a flow requires a classifier to match the packets, and a rule to filter on the matches. A classifier consists of one or more selectors. There is one selector per header type. A selector must only use fields set in the selector capability. If partial matching is supported, the classifier mask for a particular field can be a subset of the mask for that field in the capability. The rule consists of a priority, an action and a key. The key is a byte array containing headers corresponding to the selectors in the classifier. This patch implements ethtool rules for ethernet headers. Example: $ ethtool -U ens9 flow-type ether dst 08:11:22:33:44:54 action 30 Added rule with ID 1 The rule in the example directs received packets with the specified destination MAC address to rq 30. Signed-off-by: Daniel Jurgens Reviewed-by: Parav Pandit Reviewed-by: Shahar Shitrit Reviewed-by: Xuan Zhuo --- v4: - Fixed double free bug in error flows - Build bug on for classifier struct ordering. - (u8 *) to (void *) casting. - Documentation in UAPI - Answered questions about overflow with no changes. v6: - Fix sparse warning "array of flexible structures" Jakub K/Simon H v7: - Move for (int i -> for (i hunk from next patch. Paolo Abeni v12: - Make key_size u8. MST - Free key in insert_rule when it's successful. MST --- --- drivers/net/virtio_net.c | 464 +++++++++++++++++++++++++++++ include/uapi/linux/virtio_net_ff.h | 50 ++++ 2 files changed, 514 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 4dfab53fc2d5..6f2a5b4339db 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -31,6 +31,7 @@ #include #include #include +#include static int napi_weight = NAPI_POLL_WEIGHT; module_param(napi_weight, int, 0444); @@ -286,6 +287,11 @@ static const struct virtnet_stat_desc virtnet_stats_tx_speed_desc_qstat[] = { VIRTNET_STATS_DESC_TX_QSTAT(speed, ratelimit_packets, hw_drop_ratelimits), }; +struct virtnet_ethtool_ff { + struct xarray rules; + int num_rules; +}; + #define VIRTNET_FF_ETHTOOL_GROUP_PRIORITY 1 #define VIRTNET_FF_MAX_GROUPS 1 @@ -295,8 +301,16 @@ struct virtnet_ff { struct virtio_net_ff_cap_data *ff_caps; struct virtio_net_ff_cap_mask_data *ff_mask; struct virtio_net_ff_actions *ff_actions; + struct xarray classifiers; + int num_classifiers; + struct virtnet_ethtool_ff ethtool; }; +static int virtnet_ethtool_flow_insert(struct virtnet_ff *ff, + struct ethtool_rx_flow_spec *fs, + u16 curr_queue_pairs); +static int virtnet_ethtool_flow_remove(struct virtnet_ff *ff, int location); + #define VIRTNET_Q_TYPE_RX 0 #define VIRTNET_Q_TYPE_TX 1 #define VIRTNET_Q_TYPE_CQ 2 @@ -5663,6 +5677,21 @@ static u32 virtnet_get_rx_ring_count(struct net_device *dev) return vi->curr_queue_pairs; } +static int virtnet_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info) +{ + struct virtnet_info *vi = netdev_priv(dev); + + switch (info->cmd) { + case ETHTOOL_SRXCLSRLINS: + return virtnet_ethtool_flow_insert(&vi->ff, &info->fs, + vi->curr_queue_pairs); + case ETHTOOL_SRXCLSRLDEL: + return virtnet_ethtool_flow_remove(&vi->ff, info->fs.location); + } + + return -EOPNOTSUPP; +} + static const struct ethtool_ops virtnet_ethtool_ops = { .supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES | ETHTOOL_COALESCE_USECS | ETHTOOL_COALESCE_USE_ADAPTIVE_RX, @@ -5689,6 +5718,7 @@ static const struct ethtool_ops virtnet_ethtool_ops = { .get_rxfh_fields = virtnet_get_hashflow, .set_rxfh_fields = virtnet_set_hashflow, .get_rx_ring_count = virtnet_get_rx_ring_count, + .set_rxnfc = virtnet_set_rxnfc, }; static void virtnet_get_queue_stats_rx(struct net_device *dev, int i, @@ -5786,6 +5816,429 @@ static const struct netdev_stat_ops virtnet_stat_ops = { .get_base_stats = virtnet_get_base_stats, }; +struct virtnet_ethtool_rule { + struct ethtool_rx_flow_spec flow_spec; + u32 classifier_id; +}; + +/* The classifier struct must be the last field in this struct */ +struct virtnet_classifier { + size_t size; + u32 id; + struct virtio_net_resource_obj_ff_classifier classifier; +}; + +static_assert(sizeof(struct virtnet_classifier) == + ALIGN(offsetofend(struct virtnet_classifier, classifier), + __alignof__(struct virtnet_classifier)), + "virtnet_classifier: classifier must be the last member"); + +static bool check_mask_vs_cap(const void *m, const void *c, + u16 len, bool partial) +{ + const u8 *mask = m; + const u8 *cap = c; + int i; + + for (i = 0; i < len; i++) { + if (partial && ((mask[i] & cap[i]) != mask[i])) + return false; + if (!partial && mask[i] != cap[i]) + return false; + } + + return true; +} + +static +struct virtio_net_ff_selector *get_selector_cap(const struct virtnet_ff *ff, + u8 selector_type) +{ + struct virtio_net_ff_selector *sel; + void *buf; + int i; + + buf = &ff->ff_mask->selectors; + sel = buf; + + for (i = 0; i < ff->ff_mask->count; i++) { + if (sel->type == selector_type) + return sel; + + buf += sizeof(struct virtio_net_ff_selector) + sel->length; + sel = buf; + } + + return NULL; +} + +static bool validate_eth_mask(const struct virtnet_ff *ff, + const struct virtio_net_ff_selector *sel, + const struct virtio_net_ff_selector *sel_cap) +{ + bool partial_mask = !!(sel_cap->flags & VIRTIO_NET_FF_MASK_F_PARTIAL_MASK); + struct ethhdr *cap, *mask; + struct ethhdr zeros = {}; + + cap = (struct ethhdr *)&sel_cap->mask; + mask = (struct ethhdr *)&sel->mask; + + if (memcmp(&zeros.h_dest, mask->h_dest, sizeof(zeros.h_dest)) && + !check_mask_vs_cap(mask->h_dest, cap->h_dest, + sizeof(mask->h_dest), partial_mask)) + return false; + + if (memcmp(&zeros.h_source, mask->h_source, sizeof(zeros.h_source)) && + !check_mask_vs_cap(mask->h_source, cap->h_source, + sizeof(mask->h_source), partial_mask)) + return false; + + if (mask->h_proto && + !check_mask_vs_cap(&mask->h_proto, &cap->h_proto, + sizeof(__be16), partial_mask)) + return false; + + return true; +} + +static bool validate_mask(const struct virtnet_ff *ff, + const struct virtio_net_ff_selector *sel) +{ + struct virtio_net_ff_selector *sel_cap = get_selector_cap(ff, sel->type); + + if (!sel_cap) + return false; + + switch (sel->type) { + case VIRTIO_NET_FF_MASK_TYPE_ETH: + return validate_eth_mask(ff, sel, sel_cap); + } + + return false; +} + +static int setup_classifier(struct virtnet_ff *ff, struct virtnet_classifier *c) +{ + int err; + + err = xa_alloc(&ff->classifiers, &c->id, c, + XA_LIMIT(0, le32_to_cpu(ff->ff_caps->classifiers_limit) - 1), + GFP_KERNEL); + if (err) + return err; + + err = virtio_admin_obj_create(ff->vdev, + VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER, + c->id, + VIRTIO_ADMIN_GROUP_TYPE_SELF, + 0, + &c->classifier, + c->size); + if (err) + goto err_xarray; + + return 0; + +err_xarray: + xa_erase(&ff->classifiers, c->id); + + return err; +} + +static void destroy_classifier(struct virtnet_ff *ff, + u32 classifier_id) +{ + struct virtnet_classifier *c; + + c = xa_load(&ff->classifiers, classifier_id); + if (c) { + virtio_admin_obj_destroy(ff->vdev, + VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER, + c->id, + VIRTIO_ADMIN_GROUP_TYPE_SELF, + 0); + + xa_erase(&ff->classifiers, c->id); + kfree(c); + } +} + +static void destroy_ethtool_rule(struct virtnet_ff *ff, + struct virtnet_ethtool_rule *eth_rule) +{ + ff->ethtool.num_rules--; + + virtio_admin_obj_destroy(ff->vdev, + VIRTIO_NET_RESOURCE_OBJ_FF_RULE, + eth_rule->flow_spec.location, + VIRTIO_ADMIN_GROUP_TYPE_SELF, + 0); + + xa_erase(&ff->ethtool.rules, eth_rule->flow_spec.location); + destroy_classifier(ff, eth_rule->classifier_id); + kfree(eth_rule); +} + +static int insert_rule(struct virtnet_ff *ff, + struct virtnet_ethtool_rule *eth_rule, + u32 classifier_id, + const u8 *key, + u8 key_size) +{ + struct ethtool_rx_flow_spec *fs = ð_rule->flow_spec; + struct virtio_net_resource_obj_ff_rule *ff_rule; + int err; + + ff_rule = kzalloc(sizeof(*ff_rule) + key_size, GFP_KERNEL); + if (!ff_rule) + return -ENOMEM; + + /* Intentionally leave the priority as 0. All rules have the same + * priority. + */ + ff_rule->group_id = cpu_to_le32(VIRTNET_FF_ETHTOOL_GROUP_PRIORITY); + ff_rule->classifier_id = cpu_to_le32(classifier_id); + ff_rule->key_length = key_size; + ff_rule->action = fs->ring_cookie == RX_CLS_FLOW_DISC ? + VIRTIO_NET_FF_ACTION_DROP : + VIRTIO_NET_FF_ACTION_RX_VQ; + ff_rule->vq_index = fs->ring_cookie != RX_CLS_FLOW_DISC ? + cpu_to_le16(fs->ring_cookie) : 0; + memcpy(&ff_rule->keys, key, key_size); + + err = virtio_admin_obj_create(ff->vdev, + VIRTIO_NET_RESOURCE_OBJ_FF_RULE, + fs->location, + VIRTIO_ADMIN_GROUP_TYPE_SELF, + 0, + ff_rule, + sizeof(*ff_rule) + key_size); + if (err) + goto err_ff_rule; + + eth_rule->classifier_id = classifier_id; + ff->ethtool.num_rules++; + kfree(ff_rule); + kfree(key); + + return 0; + +err_ff_rule: + kfree(ff_rule); + + return err; +} + +static u32 flow_type_mask(u32 flow_type) +{ + return flow_type & ~(FLOW_EXT | FLOW_MAC_EXT | FLOW_RSS); +} + +static bool supported_flow_type(const struct ethtool_rx_flow_spec *fs) +{ + switch (fs->flow_type) { + case ETHER_FLOW: + return true; + } + + return false; +} + +static int validate_flow_input(struct virtnet_ff *ff, + const struct ethtool_rx_flow_spec *fs, + u16 curr_queue_pairs) +{ + /* Force users to use RX_CLS_LOC_ANY - don't allow specific locations */ + if (fs->location != RX_CLS_LOC_ANY) + return -EOPNOTSUPP; + + if (fs->ring_cookie != RX_CLS_FLOW_DISC && + fs->ring_cookie >= curr_queue_pairs) + return -EINVAL; + + if (fs->flow_type != flow_type_mask(fs->flow_type)) + return -EOPNOTSUPP; + + if (!supported_flow_type(fs)) + return -EOPNOTSUPP; + + return 0; +} + +static void calculate_flow_sizes(struct ethtool_rx_flow_spec *fs, + u8 *key_size, size_t *classifier_size, + int *num_hdrs) +{ + *num_hdrs = 1; + *key_size = sizeof(struct ethhdr); + /* + * The classifier size is the size of the classifier header, a selector + * header for each type of header in the match criteria, and each header + * providing the mask for matching against. + */ + *classifier_size = *key_size + + sizeof(struct virtio_net_resource_obj_ff_classifier) + + sizeof(struct virtio_net_ff_selector) * (*num_hdrs); +} + +static void setup_eth_hdr_key_mask(struct virtio_net_ff_selector *selector, + u8 *key, + const struct ethtool_rx_flow_spec *fs) +{ + struct ethhdr *eth_m = (struct ethhdr *)&selector->mask; + struct ethhdr *eth_k = (struct ethhdr *)key; + + selector->type = VIRTIO_NET_FF_MASK_TYPE_ETH; + selector->length = sizeof(struct ethhdr); + + memcpy(eth_m, &fs->m_u.ether_spec, sizeof(*eth_m)); + memcpy(eth_k, &fs->h_u.ether_spec, sizeof(*eth_k)); +} + +static int +validate_classifier_selectors(struct virtnet_ff *ff, + struct virtio_net_resource_obj_ff_classifier *classifier, + int num_hdrs) +{ + struct virtio_net_ff_selector *selector = (void *)classifier->selectors; + int i; + + for (i = 0; i < num_hdrs; i++) { + if (!validate_mask(ff, selector)) + return -EINVAL; + + selector = (((void *)selector) + sizeof(*selector) + + selector->length); + } + + return 0; +} + +static int build_and_insert(struct virtnet_ff *ff, + struct virtnet_ethtool_rule *eth_rule) +{ + struct virtio_net_resource_obj_ff_classifier *classifier; + struct ethtool_rx_flow_spec *fs = ð_rule->flow_spec; + struct virtio_net_ff_selector *selector; + struct virtnet_classifier *c; + size_t classifier_size; + int num_hdrs; + u8 key_size; + u8 *key; + int err; + + calculate_flow_sizes(fs, &key_size, &classifier_size, &num_hdrs); + + key = kzalloc(key_size, GFP_KERNEL); + if (!key) + return -ENOMEM; + + /* + * virtio_net_ff_obj_ff_classifier is already included in the + * classifier_size. + */ + c = kzalloc(classifier_size + + sizeof(struct virtnet_classifier) - + sizeof(struct virtio_net_resource_obj_ff_classifier), + GFP_KERNEL); + if (!c) { + kfree(key); + return -ENOMEM; + } + + c->size = classifier_size; + classifier = &c->classifier; + classifier->count = num_hdrs; + selector = (void *)&classifier->selectors[0]; + + setup_eth_hdr_key_mask(selector, key, fs); + + err = validate_classifier_selectors(ff, classifier, num_hdrs); + if (err) + goto err_key; + + err = setup_classifier(ff, c); + if (err) + goto err_classifier; + + err = insert_rule(ff, eth_rule, c->id, key, key_size); + if (err) { + /* destroy_classifier will free the classifier */ + destroy_classifier(ff, c->id); + goto err_key; + } + + return 0; + +err_classifier: + kfree(c); +err_key: + kfree(key); + + return err; +} + +static int virtnet_ethtool_flow_insert(struct virtnet_ff *ff, + struct ethtool_rx_flow_spec *fs, + u16 curr_queue_pairs) +{ + struct virtnet_ethtool_rule *eth_rule; + int err; + + if (!ff->ff_supported) + return -EOPNOTSUPP; + + err = validate_flow_input(ff, fs, curr_queue_pairs); + if (err) + return err; + + eth_rule = kzalloc(sizeof(*eth_rule), GFP_KERNEL); + if (!eth_rule) + return -ENOMEM; + + err = xa_alloc(&ff->ethtool.rules, &fs->location, eth_rule, + XA_LIMIT(0, le32_to_cpu(ff->ff_caps->rules_limit) - 1), + GFP_KERNEL); + if (err) + goto err_rule; + + eth_rule->flow_spec = *fs; + + err = build_and_insert(ff, eth_rule); + if (err) + goto err_xa; + + return err; + +err_xa: + xa_erase(&ff->ethtool.rules, eth_rule->flow_spec.location); + +err_rule: + fs->location = RX_CLS_LOC_ANY; + kfree(eth_rule); + + return err; +} + +static int virtnet_ethtool_flow_remove(struct virtnet_ff *ff, int location) +{ + struct virtnet_ethtool_rule *eth_rule; + int err = 0; + + if (!ff->ff_supported) + return -EOPNOTSUPP; + + eth_rule = xa_load(&ff->ethtool.rules, location); + if (!eth_rule) { + err = -ENOENT; + goto out; + } + + destroy_ethtool_rule(ff, eth_rule); +out: + return err; +} + static size_t get_mask_size(u16 type) { switch (type) { @@ -5961,6 +6414,8 @@ static int virtnet_ff_init(struct virtnet_ff *ff, struct virtio_device *vdev) if (err) goto err_ff_action; + xa_init_flags(&ff->classifiers, XA_FLAGS_ALLOC); + xa_init_flags(&ff->ethtool.rules, XA_FLAGS_ALLOC); ff->vdev = vdev; ff->ff_supported = true; @@ -5985,9 +6440,18 @@ static int virtnet_ff_init(struct virtnet_ff *ff, struct virtio_device *vdev) static void virtnet_ff_cleanup(struct virtnet_ff *ff) { + struct virtnet_ethtool_rule *eth_rule; + unsigned long i; + if (!ff->ff_supported) return; + xa_for_each(&ff->ethtool.rules, i, eth_rule) + destroy_ethtool_rule(ff, eth_rule); + + xa_destroy(&ff->ethtool.rules); + xa_destroy(&ff->classifiers); + virtio_admin_obj_destroy(ff->vdev, VIRTIO_NET_RESOURCE_OBJ_FF_GROUP, VIRTNET_FF_ETHTOOL_GROUP_PRIORITY, diff --git a/include/uapi/linux/virtio_net_ff.h b/include/uapi/linux/virtio_net_ff.h index 0401e8fdc7a8..db47553773bd 100644 --- a/include/uapi/linux/virtio_net_ff.h +++ b/include/uapi/linux/virtio_net_ff.h @@ -12,6 +12,8 @@ #define VIRTIO_NET_FF_ACTION_CAP 0x802 #define VIRTIO_NET_RESOURCE_OBJ_FF_GROUP 0x0200 +#define VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER 0x0201 +#define VIRTIO_NET_RESOURCE_OBJ_FF_RULE 0x0202 /** * struct virtio_net_ff_cap_data - Flow filter resource capability limits @@ -101,4 +103,52 @@ struct virtio_net_resource_obj_ff_group { __le16 group_priority; }; +/** + * struct virtio_net_resource_obj_ff_classifier - Flow filter classifier object + * @count: number of selector entries in @selectors + * @reserved: must be set to 0 by the driver and ignored by the device + * @selectors: array of selector descriptors that define match masks + * + * Payload for the VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER administrative object. + * Each selector describes a header mask used to match packets + * (see struct virtio_net_ff_selector). Selectors appear in the order they are + * to be applied. + */ +struct virtio_net_resource_obj_ff_classifier { + __u8 count; + __u8 reserved[7]; + __u8 selectors[]; +}; + +/** + * struct virtio_net_resource_obj_ff_rule - Flow filter rule object + * @group_id: identifier of the target flow filter group + * @classifier_id: identifier of the classifier referenced by this rule + * @rule_priority: relative priority of this rule within the group + * @key_length: number of bytes in @keys + * @action: action to perform, one of VIRTIO_NET_FF_ACTION_* + * @reserved: must be set to 0 by the driver and ignored by the device + * @vq_index: RX virtqueue index for VIRTIO_NET_FF_ACTION_RX_VQ, 0 otherwise + * @reserved1: must be set to 0 by the driver and ignored by the device + * @keys: concatenated key bytes matching the classifier's selectors order + * + * Payload for the VIRTIO_NET_RESOURCE_OBJ_FF_RULE administrative object. + * @group_id and @classifier_id refer to previously created objects of types + * VIRTIO_NET_RESOURCE_OBJ_FF_GROUP and VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER + * respectively. The key bytes are compared against packet headers using the + * masks provided by the classifier's selectors. Multi-byte fields are + * little-endian. + */ +struct virtio_net_resource_obj_ff_rule { + __le32 group_id; + __le32 classifier_id; + __u8 rule_priority; + __u8 key_length; /* length of key in bytes */ + __u8 action; + __u8 reserved; + __le16 vq_index; + __u8 reserved1[2]; + __u8 keys[]; +}; + #endif -- 2.50.1