From: Eric Biggers <ebiggers@kernel.org>
To: Bibo Mao <maobibo@loongson.cn>
Cc: Gonglei <arei.gonglei@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
kvm@vger.kernel.org, linux-crypto@vger.kernel.org,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/10] crypto: virtio: Add ecb aes algo support
Date: Tue, 9 Dec 2025 17:45:24 -0800 [thread overview]
Message-ID: <20251210014524.GA4128@sol> (raw)
In-Reply-To: <4ac7b5b9-d819-62b5-1425-0e0b07762120@loongson.cn>
On Wed, Dec 10, 2025 at 09:36:06AM +0800, Bibo Mao wrote:
>
>
> On 2025/12/10 上午7:25, Eric Biggers wrote:
> > On Tue, Dec 09, 2025 at 10:22:58AM +0800, Bibo Mao wrote:
> > > ECB AES also is added here, its ivsize is zero and name is different
> > > compared with CBC AES algo.
> >
> > What is the use case for this feature?Currently qemu builtin backend and
> > openssl afalg only support CBC AES,
> it depends on modified qemu and openssl to test this.
>
> Maybe this patch adding ECB AES algo can be skipped now, it is just an
> example, the final target is to add SM4 cipher.
There's no need to add useless features. The title of your patchset is
"crypto: virtio: Add ecb aes algo support". So it sounds like the main
point of your patchset is to add a useless feature? If there are
actually unrelated fixes you want, you should send those separately.
As for SM4 support (which mode?), if you really want that (you
shouldn't), why not use the existing CPU accelerated implementation?
- Eric
next prev parent reply other threads:[~2025-12-10 1:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251209022258.4183415-1-maobibo@loongson.cn>
2025-12-09 2:22 ` [PATCH v3 01/10] crypto: virtio: Add spinlock protection with virtqueue notification Bibo Mao
2025-12-09 4:32 ` Jason Wang
2025-12-09 2:22 ` [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick in virtio_crypto_skcipher_crypt_req Bibo Mao
2025-12-09 2:22 ` [PATCH v3 03/10] crypto: virtio: Replace package id with numa node id Bibo Mao
2025-12-09 2:22 ` [PATCH v3 04/10] crypto: virtio: Add algo pointer in virtio_crypto_skcipher_ctx Bibo Mao
2025-12-09 2:22 ` [PATCH v3 05/10] crypto: virtio: Use generic API aes_check_keylen() Bibo Mao
2025-12-09 2:22 ` [PATCH v3 06/10] crypto: virtio: Remove AES specified marcro AES_BLOCK_SIZE Bibo Mao
2025-12-09 2:22 ` [PATCH v3 07/10] crypto: virtio: Add req_data with structure virtio_crypto_sym_request Bibo Mao
2025-12-09 2:22 ` [PATCH v3 08/10] crypto: virtio: Add IV buffer in " Bibo Mao
2025-12-09 2:22 ` [PATCH v3 09/10] crypto: virtio: Add skcipher support without IV Bibo Mao
2025-12-09 2:22 ` [PATCH v3 10/10] crypto: virtio: Add ecb aes algo support Bibo Mao
2025-12-09 23:25 ` Eric Biggers
2025-12-10 1:36 ` Bibo Mao
2025-12-10 1:45 ` Eric Biggers [this message]
2025-12-11 1:45 ` Bibo Mao
[not found] <20251209015951.4174743-1-maobibo@loongson.cn>
2025-12-09 1:59 ` Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210014524.GA4128@sol \
--to=ebiggers@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=davem@davemloft.net \
--cc=eperezma@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maobibo@loongson.cn \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).