Re: Backport request for commit 5326ab737a47 ("virtio_console: fix order of fields cols and rows")

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Dec 23, 2025 at 10:36:48PM +0100, Filip Hejsek wrote:
> Hi,
> 
> I would like to once again request backporting 5326ab737a47
> ("virtio_console: fix order of fields cols and rows") to LTS kernels
> (6.12.x, 6.6.x, 6.1.x, 5.15.x and 5.10.x). The patch fixes a
> discrepancy between the Virtio spec and the Linux implementation.
> 
> Previously, we were considering changing the spec instead, however, a
> decision has been made [1] to keep the spec and backport the kernel
> fix.
> 
> [1]: https://lore.kernel.org/virtio-comment/20251013035826-mutt-send-email-mst@kernel.org/
> 
> Thanks,
> Filip Hejsek


Acked-by: Michael S. Tsirkin <mst@redhat.com>

> On Thu, 2025-09-18 at 01:13 +0200, Filip Hejsek wrote:
> > Hi,
> > 
> > I would like to request backporting 5326ab737a47 ("virtio_console: fix
> > order of fields cols and rows") to all LTS kernels.
> > 
> > I'm working on QEMU patches that add virtio console size support.
> > Without the fix, rows and columns will be swapped.
> > 
> > As far as I know, there are no device implementations that use the
> > wrong order and would by broken by the fix.
> > 
> > Note: A previous version [1] of the patch contained "Cc: stable" and
> > "Fixes:" tags, but they seem to have been accidentally left out from
> > the final version.
> > 
> > [1]: https://lore.kernel.org/all/20250320172654.624657-1-maxbr@linux.ibm.com/
> > 
> > Thanks,
> > Filip Hejsek