From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH V11 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants
Date: Thu, 25 Dec 2025 12:25:59 +0800 [thread overview]
Message-ID: <20251225042608.32350-11-jasowang@redhat.com> (raw)
In-Reply-To: <20251225042608.32350-1-jasowang@redhat.com>
Those variants are used internally so let's switch to use
vring_virtqueue as parameter to be consistent with other internal
virtqueue helpers.
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio_ring.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 00de30862777..a4d084f5ca95 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -874,10 +874,8 @@ static void *virtqueue_get_buf_ctx_split(struct vring_virtqueue *vq,
return ret;
}
-static void virtqueue_disable_cb_split(struct virtqueue *_vq)
+static void virtqueue_disable_cb_split(struct vring_virtqueue *vq)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
-
if (!(vq->split.avail_flags_shadow & VRING_AVAIL_F_NO_INTERRUPT)) {
vq->split.avail_flags_shadow |= VRING_AVAIL_F_NO_INTERRUPT;
@@ -893,7 +891,7 @@ static void virtqueue_disable_cb_split(struct virtqueue *_vq)
vring_used_event(&vq->split.vring) = 0x0;
else
vq->split.vring.avail->flags =
- cpu_to_virtio16(_vq->vdev,
+ cpu_to_virtio16(vq->vq.vdev,
vq->split.avail_flags_shadow);
}
}
@@ -1786,10 +1784,8 @@ static void *virtqueue_get_buf_ctx_packed(struct vring_virtqueue *vq,
return ret;
}
-static void virtqueue_disable_cb_packed(struct virtqueue *_vq)
+static void virtqueue_disable_cb_packed(struct vring_virtqueue *vq)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
-
if (vq->packed.event_flags_shadow != VRING_PACKED_EVENT_FLAG_DISABLE) {
vq->packed.event_flags_shadow = VRING_PACKED_EVENT_FLAG_DISABLE;
@@ -2542,9 +2538,9 @@ void virtqueue_disable_cb(struct virtqueue *_vq)
struct vring_virtqueue *vq = to_vvq(_vq);
if (vq->packed_ring)
- virtqueue_disable_cb_packed(_vq);
+ virtqueue_disable_cb_packed(vq);
else
- virtqueue_disable_cb_split(_vq);
+ virtqueue_disable_cb_split(vq);
}
EXPORT_SYMBOL_GPL(virtqueue_disable_cb);
--
2.31.1
next prev parent reply other threads:[~2025-12-25 4:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 4:25 [PATCH V11 00/19] virtio_ring in order support Jason Wang
2025-12-25 4:25 ` [PATCH V11 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-12-25 4:25 ` [PATCH V11 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-12-25 4:25 ` [PATCH V11 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 07/19] virtio: switch to use vring_virtqueue for virtqueue_get variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-12-25 4:25 ` [PATCH V11 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-12-25 4:25 ` Jason Wang [this message]
2025-12-25 4:26 ` [PATCH V11 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants Jason Wang
2025-12-25 4:26 ` [PATCH V11 12/19] virtio_ring: switch to use unsigned int for virtqueue_poll_packed() Jason Wang
2025-12-25 4:26 ` [PATCH V11 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-12-26 19:37 ` Michael S. Tsirkin
2025-12-29 7:16 ` Jason Wang
2025-12-26 19:45 ` Michael S. Tsirkin
2025-12-29 7:16 ` Jason Wang
2025-12-25 4:26 ` [PATCH V11 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-12-26 19:33 ` Michael S. Tsirkin
2025-12-29 7:16 ` Jason Wang
2025-12-25 4:26 ` [PATCH V11 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-12-25 4:26 ` [PATCH V11 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-12-25 4:26 ` [PATCH V11 17/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-12-25 4:26 ` [PATCH V11 18/19] virtio_ring: factor out split " Jason Wang
2025-12-25 4:26 ` [PATCH V11 19/19] virtio_ring: add in order support Jason Wang
2025-12-26 19:57 ` Michael S. Tsirkin
2025-12-27 10:09 ` Michael S. Tsirkin
2025-12-29 7:15 ` Jason Wang
2025-12-29 7:18 ` Jason Wang
-- strict thread matches above, loose matches on Subject: below --
2025-12-30 6:46 [PATCH V11 00/19] virtio_ring " Jason Wang
2025-12-30 6:46 ` [PATCH V11 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251225042608.32350-11-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).