From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263D02E1C6B for ; Fri, 2 Jan 2026 11:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352658; cv=none; b=aj04fx25667gpwqv2y/MXiTlHRXTCFM/33Y9A97Cjb3GT9jC+ecrrRuDGalGjy103yXZx1TYhv9DHyLdE7sYwqB0wzGjhXUENXyDxx5DssxxhaWcB/+ZQZOmgYYDi4XScX/tpNdeJ+4lT23Hsj2FloH0yMs2w6N9RMhuF6NV2MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767352658; c=relaxed/simple; bh=j+gjzPCCCvl+UXjwVGUBYvSZkC6L6hIK3UJ/XrmwLcc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=kVxrO6WzJ8jOrv/cUMdnSizR1UKl53JSe+JUqoVf+9nvDXBhTusQ2sKooYoSRiD5R8Vb4nKs3/uiDbKIJzceTN1QGM0Dv27h+Gka+q1eYFD/41K0Q7Bwvy1mND0ZbQxR5vI6CdtlfSVLs8WT27YcBm10lbmOMGrXhFpt6LZ0rJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bxLa9th3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bxLa9th3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767352655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GCWlh8uBOmDSQEd79VDuimcUgjfVQxRp6qQ9KdZZbfc=; b=bxLa9th3CB1FYl0CJxgRcGw6+NaErVsT/OyzhoNg6EMnOyAt80kd65c5K0xH6OCvhqG0R3 Xe0TfMMy7+V2ICp237oPH0eRTtP/TmGDUUp1ud08+PzDLHBco7bGiiFb0waRzPqG+Dro8v g0kyyAhs2hD0eFXkc2yd8Qj56nfi52M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-IUmZgI9zMfWp1ubhMrGobg-1; Fri, 02 Jan 2026 06:17:34 -0500 X-MC-Unique: IUmZgI9zMfWp1ubhMrGobg-1 X-Mimecast-MFC-AGG-ID: IUmZgI9zMfWp1ubhMrGobg_1767352653 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477c49f273fso149803275e9.3 for ; Fri, 02 Jan 2026 03:17:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767352653; x=1767957453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GCWlh8uBOmDSQEd79VDuimcUgjfVQxRp6qQ9KdZZbfc=; b=GnBJ/7V1zJhyVIESAMaFKtD24SBPm0Nl9ywl09I6rndGyY1S2nskfkiS/rAucm6l8Z nBkQdLFJnd4KQurnAO5Na1/lEDlcyXm3sno3yEfVN167DfRfSmNcZO+EmVm1o8kqqJOG 4kwutDMxNCKnY785oMvXBY47acDAzKwhIraIbIjPmEbpvsdTGOyBv4HM5G48+nb4NSI1 mvF516VydXONAedSvbO8dcv1zClW5+AI6X11MxmKhPRnI0dt2KIC+RxkAlXuUXGJtb8w h7Tifzlc8l+Y6TRNyleHYTwy/5k6qhJTxrCGEZdZmP8I6rsjDJAZNJOPqrLf392TZIIu Q4ZA== X-Forwarded-Encrypted: i=1; AJvYcCU9H+TlBNmQsjPBTmmO/4GavbsCwetO8BS8HOnRK6EsJgLWFGFYteQyCaWjuJECbunUN/8YCuRFPDFX3FV4ZA==@lists.linux.dev X-Gm-Message-State: AOJu0YxY8RmYdfDi+nMB+dVw5ZY6POfMECm6nWLVHYvWA0JJgIa7v+6z Wq6LsiOEBIMZIOg/GVpAgxCduA7E7z9LoU7nE/zx3CwTlWwHCSg1vGK05qRWgPk5dMn/TnzgeaU 07ojCKcnDbLZk2UagXU74viwItChzkQXxiMYL6gjhgZbLaa9gEqMDgfNd6HtnNAsxxBKA X-Gm-Gg: AY/fxX45HoQj2xoy5ZGywbSP4D9oX1dqbjUCnjVAPA41cvxsqcyHn9ITKxb8k8pdgxz XLNxdEAWmos7bIKO9z2dTp/pjtHTn/R1OrlhgUG2C8ceBNDtGK2AD7RS5y3FC9qLjsbY1WEd0gw Lc8ckB3lQbaRuqUdcxuV7rj4CXPOieWC4JIneZjcxpqp1BqStPWuJxOgYdbt6yBP0EpqfjryYhU z7Z00FE1SHdfP5YNcH680TDD41uHLvlXUm2uu9XF+vbDRw9yVVXvnsj8e3c9t6i+R+cQeCAXOCP YOPLxFe9Z+v+j0dNxaLnrBSUwp15PR1k5mTp6k5nBtOyFS4m4vec+Pexp/zRwQIlCLxnhAT/8Xi MAbcM+Debde/f4SZt7erKO5TNpTgfaJDuGg== X-Received: by 2002:a05:600c:8107:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-47d19595f00mr527615095e9.22.1767352653104; Fri, 02 Jan 2026 03:17:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwa61BzDAQlV9N6kMzOmYy7Hkb8vOAXLv3Qn/Wfyxm7iktYYakDvEJC0kSxdzWUaE/ZHihdA== X-Received: by 2002:a05:600c:8107:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-47d19595f00mr527614555e9.22.1767352652542; Fri, 02 Jan 2026 03:17:32 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab257asm84882883f8f.38.2026.01.02.03.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 03:17:31 -0800 (PST) Date: Fri, 2 Jan 2026 06:17:28 -0500 From: "Michael S. Tsirkin" To: Petr Tesarik Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?iso-8859-1?Q?P=E9rez?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Leon Romanovsky , Jason Gunthorpe , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC 05/13] dma-debug: track cache clean flag in entries Message-ID: <20260102060336-mutt-send-email-mst@kernel.org> References: <20260102085933.2f78123b@mordecai> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260102085933.2f78123b@mordecai> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XFBQARzjQGJaVd1d3okcDUSl5mKerR-O-8ZekgAFjlY_1767352653 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 02, 2026 at 08:59:33AM +0100, Petr Tesarik wrote: > On Tue, 30 Dec 2025 05:16:00 -0500 > "Michael S. Tsirkin" wrote: > > > If a driver is bugy and has 2 overlapping mappings but only > > sets cache clean flag on the 1st one of them, we warn. > > But if it only does it for the 2nd one, we don't. > > > > Fix by tracking cache clean flag in the entry. > > Shrink map_err_type to u8 to avoid bloating up the struct. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > kernel/dma/debug.c | 25 ++++++++++++++++++++----- > > 1 file changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c > > index 7e66d863d573..9bd14fd4c51b 100644 > > --- a/kernel/dma/debug.c > > +++ b/kernel/dma/debug.c > > @@ -63,6 +63,7 @@ enum map_err_types { > > * @sg_mapped_ents: 'mapped_ents' from dma_map_sg > > * @paddr: physical start address of the mapping > > * @map_err_type: track whether dma_mapping_error() was checked > > + * @is_cache_clean: driver promises not to write to buffer while mapped > > * @stack_len: number of backtrace entries in @stack_entries > > * @stack_entries: stack of backtrace history > > */ > > @@ -76,7 +77,8 @@ struct dma_debug_entry { > > int sg_call_ents; > > int sg_mapped_ents; > > phys_addr_t paddr; > > - enum map_err_types map_err_type; > > + u8 map_err_type; > > Where exactly is the bloat? With my configuration, the size of struct > dma_debug_entry is 128 bytes, with enough padding bytes at the end to > keep it at 128 even if I keep this member an enum... Ah, I missed ____cacheline_aligned_in_smp. Fixed. > > Anyway, if there is a reason to keep this member small, I prefer to > pack enum map_err_types instead: > > @@ -46,9 +46,9 @@ enum { > enum map_err_types { > MAP_ERR_CHECK_NOT_APPLICABLE, > MAP_ERR_NOT_CHECKED, > MAP_ERR_CHECKED, > -}; > +} __packed; Wow I didn't realize __packed can apply to enums. > #define DMA_DEBUG_STACKTRACE_ENTRIES 5 > > /** > > This will shrink it to a single byte but it will also keep the type > information. > > > + bool is_cache_clean; > > #ifdef CONFIG_STACKTRACE > > unsigned int stack_len; > > unsigned long stack_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > > @@ -472,12 +474,15 @@ static int active_cacheline_dec_overlap(phys_addr_t cln) > > return active_cacheline_set_overlap(cln, --overlap); > > } > > > > -static int active_cacheline_insert(struct dma_debug_entry *entry) > > +static int active_cacheline_insert(struct dma_debug_entry *entry, > > + bool *overlap_cache_clean) > > { > > phys_addr_t cln = to_cacheline_number(entry); > > unsigned long flags; > > int rc; > > > > + *overlap_cache_clean = false; > > + > > /* If the device is not writing memory then we don't have any > > * concerns about the cpu consuming stale data. This mitigates > > * legitimate usages of overlapping mappings. > > @@ -487,8 +492,14 @@ static int active_cacheline_insert(struct dma_debug_entry *entry) > > > > spin_lock_irqsave(&radix_lock, flags); > > rc = radix_tree_insert(&dma_active_cacheline, cln, entry); > > - if (rc == -EEXIST) > > + if (rc == -EEXIST) { > > + struct dma_debug_entry *existing; > > + > > active_cacheline_inc_overlap(cln); > > + existing = radix_tree_lookup(&dma_active_cacheline, cln); > > + if (existing) > > + *overlap_cache_clean = existing->is_cache_clean; > > *nitpick* > > IIUC radix_tree_insert() returns -EEXIST only if the key is already > present in the tree. Since radix_lock is not released between the > insert attempt and this lookup, I don't see how this lookup could > possibly fail. If it's not expected to fail, I would add a WARN_ON(). > > Please, do correct me if I'm missing something. > > Other than that, LGTM. > > Petr T Sure, thanks! > > + } > > spin_unlock_irqrestore(&radix_lock, flags); > > > > return rc; > > @@ -583,20 +594,24 @@ DEFINE_SHOW_ATTRIBUTE(dump); > > */ > > static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs) > > { > > + bool overlap_cache_clean; > > struct hash_bucket *bucket; > > unsigned long flags; > > int rc; > > > > + entry->is_cache_clean = !!(attrs & DMA_ATTR_CPU_CACHE_CLEAN); > > + > > bucket = get_hash_bucket(entry, &flags); > > hash_bucket_add(bucket, entry); > > put_hash_bucket(bucket, flags); > > > > - rc = active_cacheline_insert(entry); > > + rc = active_cacheline_insert(entry, &overlap_cache_clean); > > if (rc == -ENOMEM) { > > pr_err_once("cacheline tracking ENOMEM, dma-debug disabled\n"); > > global_disable = true; > > } else if (rc == -EEXIST && > > - !(attrs & (DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_CPU_CACHE_CLEAN)) && > > + !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && > > + !(entry->is_cache_clean && overlap_cache_clean) && > > !(IS_ENABLED(CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC) && > > is_swiotlb_active(entry->dev))) { > > err_printk(entry->dev, entry,