public inbox for virtualization@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mark Brown" <broonie@kernel.org>,
	"Varshini Rajendran" <varshini.rajendran@microchip.com>,
	"Mikhail Kshevetskiy" <mikhail.kshevetskiy@iopsys.eu>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Sunny Luo" <sunny.luo@amlogic.com>,
	"Janne Grunau" <j@jannau.net>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Chin-Ting Kuo" <chin-ting_kuo@aspeedtech.com>,
	"CL Wang" <cl634@andestech.com>,
	"Manikandan Muralidharan" <manikandan.m@microchip.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Hang Zhou" <929513338@qq.com>, "Jun Guo" <jun.guo@cixtech.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Benoît Monin" <benoit.monin@bootlin.com>,
	"Shiji Yang" <yangshiji66@outlook.com>,
	"James Clark" <james.clark@linaro.org>,
	"Jonathan Marek" <jonathan@marek.ca>,
	"Carlos Song" <carlos.song@nxp.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Xianwei Zhao" <xianwei.zhao@amlogic.com>,
	"Prajna Rajendra Kumar" <prajna.rajendrakumar@microchip.com>,
	"Sergio Perez Gonzalez" <sperezglz@gmail.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Qianfeng Rong" <rongqianfeng@vivo.com>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Gabor Juhos" <j4g8y7@gmail.com>,
	"Md Sadre Alam" <quic_mdalam@quicinc.com>,
	"Rosen Penev" <rosenp@gmail.com>,
	"Luis de Arquer" <luis.dearquer@inertim.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Longbin Li" <looong.bin@gmail.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Clément Le Goffic" <clement.legoffic@foss.st.com>,
	"Alessandro Grassi" <alessandro.grassi@mailbox.org>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Darshan R" <rathod.darshan.0896@gmail.com>,
	"Aaron Kling" <webgeek1234@gmail.com>,
	"Vishwaroop A" <va@nvidia.com>,
	"Haixu Cui" <quic_haixcui@quicinc.com>,
	"Darshan Rathod" <darshanrathod475@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org,
	openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	imx@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	virtualization@lists.linux.dev
Cc: "Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Ray Liu" <ray.liu@airoha.com>, "Sven Peter" <sven@kernel.org>,
	"Neal Gompa" <neal@gompa.dev>, "Cédric Le Goater" <clg@kaod.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Ryan Wanner" <ryan.wanner@microchip.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Kamal Dasu" <kamal.dasu@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Kursad Oney" <kursad.oney@broadcom.com>,
	"Anand Gore" <anand.gore@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Jean-Marie Verdun" <verdun@hpe.com>,
	"Nick Hawkins" <nick.hawkins@hpe.com>,
	"Yang Shen" <shenyang39@huawei.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Lixu Zhang" <lixu.zhang@intel.com>,
	"Yinbo Zhu" <zhuyinbo@loongson.cn>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Patrick Venture" <venture@google.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Han Xu" <han.xu@nxp.com>,
	"Yogesh Gaur" <yogeshgaur.83@gmail.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Chris Packham" <chris.packham@alliedtelesis.co.nz>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Li-hao Kuo" <lhjeff911@gmail.com>,
	"Masahisa Kojima" <masahisa.kojima@linaro.org>,
	"Jassi Brar" <jaswinder.singh@linaro.org>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Sowjanya Komatineni" <skomatineni@nvidia.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Michal Simek" <michal.simek@amd.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>
Subject: [PATCH v1 3/4] spi: Drop duplicate fwnode assignment
Date: Thu,  8 Jan 2026 21:23:40 +0100	[thread overview]
Message-ID: <20260108203004.3538449-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260108203004.3538449-1-andriy.shevchenko@linux.intel.com>

The SPI core provides the default fwnode for the controller,
inherited from the actual (parent) device. No need to repeat it
in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-hisi-kunpeng.c | 1 -
 drivers/spi/spi-synquacer.c    | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/drivers/spi/spi-hisi-kunpeng.c b/drivers/spi/spi-hisi-kunpeng.c
index dadf558dd9c0..afe51adcc507 100644
--- a/drivers/spi/spi-hisi-kunpeng.c
+++ b/drivers/spi/spi-hisi-kunpeng.c
@@ -497,7 +497,6 @@ static int hisi_spi_probe(struct platform_device *pdev)
 	host->cleanup = hisi_spi_cleanup;
 	host->transfer_one = hisi_spi_transfer_one;
 	host->handle_err = hisi_spi_handle_err;
-	host->dev.fwnode = dev->fwnode;
 	host->min_speed_hz = DIV_ROUND_UP(host->max_speed_hz, CLK_DIV_MAX);
 
 	hisi_spi_hw_init(hs);
diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c
index eaf560487591..d0a875249910 100644
--- a/drivers/spi/spi-synquacer.c
+++ b/drivers/spi/spi-synquacer.c
@@ -600,7 +600,6 @@ static irqreturn_t sq_spi_tx_handler(int irq, void *priv)
 
 static int synquacer_spi_probe(struct platform_device *pdev)
 {
-	struct device_node *np = pdev->dev.of_node;
 	struct spi_controller *host;
 	struct synquacer_spi *sspi;
 	int ret;
@@ -699,8 +698,6 @@ static int synquacer_spi_probe(struct platform_device *pdev)
 		goto disable_clk;
 	}
 
-	host->dev.of_node = np;
-	host->dev.fwnode = pdev->dev.fwnode;
 	host->auto_runtime_pm = true;
 	host->bus_num = pdev->id;
 
-- 
2.50.1


  parent reply	other threads:[~2026-01-08 20:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 20:23 [PATCH v1 0/4] spi: Make SPI core to take care of fwnode assignment Andy Shevchenko
2026-01-08 20:23 ` [PATCH v1 1/4] spi: Propagate default fwnode to the SPI controller device Andy Shevchenko
2026-01-12 11:53   ` Charles Keepax
2026-01-12 12:03     ` Andy Shevchenko
2026-01-08 20:23 ` [PATCH v1 2/4] spi: Drop duplicate of_node assignment Andy Shevchenko
2026-01-09  9:11   ` Geert Uytterhoeven
2026-01-09 19:38   ` William Zhang
2026-01-09 21:05   ` Martin Blumenstingl
2026-01-09 22:05   ` Cédric Le Goater
2026-01-11  5:51   ` Chen-Yu Tsai
2026-01-11 19:41   ` Heiko Stübner
2026-01-12  7:11   ` Patrice CHOTARD
2026-01-12  7:50   ` [Linux-stm32] " Amelie Delaunay
2026-01-08 20:23 ` Andy Shevchenko [this message]
2026-01-08 20:23 ` [PATCH v1 4/4] spi: Drop duplicate device_set_node() call Andy Shevchenko
2026-01-12 14:10   ` Benoît Monin
2026-01-20 19:22 ` [PATCH v1 0/4] spi: Make SPI core to take care of fwnode assignment Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108203004.3538449-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=929513338@qq.com \
    --cc=Frank.Li@nxp.com \
    --cc=alain.volmat@foss.st.com \
    --cc=alessandro.grassi@mailbox.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alim.akhtar@samsung.com \
    --cc=anand.gore@broadcom.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=asahi@lists.linux.dev \
    --cc=avifishman70@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=benjaminfair@google.com \
    --cc=benoit.monin@bootlin.com \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=carlos.song@nxp.com \
    --cc=chenhuacai@kernel.org \
    --cc=chin-ting_kuo@aspeedtech.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=cl634@andestech.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=clement.legoffic@foss.st.com \
    --cc=clg@kaod.org \
    --cc=conor.dooley@microchip.com \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=daniel@zonque.org \
    --cc=darshanrathod475@gmail.com \
    --cc=david.rhodes@cirrus.com \
    --cc=dlechner@baylibre.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=festevam@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=geert+renesas@glider.be \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=heiko@sntech.de \
    --cc=imx@lists.linux.dev \
    --cc=j.neuschaefer@gmx.net \
    --cc=j4g8y7@gmail.com \
    --cc=j@jannau.net \
    --cc=james.clark@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=jbrunet@baylibre.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=joel@jms.id.au \
    --cc=jonas.gorski@gmail.com \
    --cc=jonathan@marek.ca \
    --cc=jonathanh@nvidia.com \
    --cc=jun.guo@cixtech.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=krzk@kernel.org \
    --cc=kursad.oney@broadcom.com \
    --cc=ldewangan@nvidia.com \
    --cc=lhjeff911@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    --cc=looong.bin@gmail.com \
    --cc=lorenzo@kernel.org \
    --cc=luis.dearquer@inertim.com \
    --cc=manikandan.m@microchip.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=masahisa.kojima@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=michal.simek@amd.com \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=miquel.raynal@bootlin.com \
    --cc=neal@gompa.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=nick.hawkins@hpe.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=nuno.sa@analog.com \
    --cc=olteanv@gmail.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=orsonzhai@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=phasta@kernel.org \
    --cc=pjw@kernel.org \
    --cc=prajna.rajendrakumar@microchip.com \
    --cc=quic_haixcui@quicinc.com \
    --cc=quic_mdalam@quicinc.com \
    --cc=rafal@milecki.pl \
    --cc=rathod.darshan.0896@gmail.com \
    --cc=ray.liu@airoha.com \
    --cc=rf@opensource.cirrus.com \
    --cc=rjui@broadcom.com \
    --cc=robert.jarzmik@free.fr \
    --cc=rongqianfeng@vivo.com \
    --cc=rosenp@gmail.com \
    --cc=ryan.wanner@microchip.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=samuel.holland@sifive.com \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=shenyang39@huawei.com \
    --cc=skomatineni@nvidia.com \
    --cc=sperezglz@gmail.com \
    --cc=sunny.luo@amlogic.com \
    --cc=sven@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=va@nvidia.com \
    --cc=varshini.rajendran@microchip.com \
    --cc=venture@google.com \
    --cc=verdun@hpe.com \
    --cc=virtualization@lists.linux.dev \
    --cc=webgeek1234@gmail.com \
    --cc=wens@kernel.org \
    --cc=william.zhang@broadcom.com \
    --cc=xianwei.zhao@amlogic.com \
    --cc=yangshiji66@outlook.com \
    --cc=yogeshgaur.83@gmail.com \
    --cc=yuenn@google.com \
    --cc=zhang.lyra@gmail.com \
    --cc=zhuyinbo@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox