From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S . Tsirkin " <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
"Maxime Coquelin" <mcoqueli@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Cindy Lu" <lulu@redhat.com>,
jasowang@redhat.com, "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Yongji Xie" <xieyongji@bytedance.com>,
"Eugenio Pérez" <eperezma@redhat.com>
Subject: [PATCH v11 07/12] vduse: refactor vdpa_dev_add for goto err handling
Date: Fri, 9 Jan 2026 16:24:25 +0100 [thread overview]
Message-ID: <20260109152430.512923-8-eperezma@redhat.com> (raw)
In-Reply-To: <20260109152430.512923-1-eperezma@redhat.com>
Next patches introduce more error paths in this function. Refactor it
so they can be accomodated through gotos.
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Xie Yongji <xieyongji@bytedance.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
v6: New in v6.
---
drivers/vdpa/vdpa_user/vduse_dev.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 0386434577b5..f7a45f396cf8 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -2171,21 +2171,27 @@ static int vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
dev->bounce_size);
mutex_unlock(&dev->domain_lock);
if (!dev->domain) {
- put_device(&dev->vdev->vdpa.dev);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto domain_err;
}
ret = _vdpa_register_device(&dev->vdev->vdpa, dev->vq_num);
if (ret) {
- put_device(&dev->vdev->vdpa.dev);
- mutex_lock(&dev->domain_lock);
- vduse_domain_destroy(dev->domain);
- dev->domain = NULL;
- mutex_unlock(&dev->domain_lock);
- return ret;
+ goto register_err;
}
return 0;
+
+register_err:
+ mutex_lock(&dev->domain_lock);
+ vduse_domain_destroy(dev->domain);
+ dev->domain = NULL;
+ mutex_unlock(&dev->domain_lock);
+
+domain_err:
+ put_device(&dev->vdev->vdpa.dev);
+
+ return ret;
}
static void vdpa_dev_del(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev)
--
2.52.0
next prev parent reply other threads:[~2026-01-09 15:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:24 [PATCH v11 00/12] Add multiple address spaces support to VDUSE Eugenio Pérez
2026-01-09 15:24 ` [PATCH v11 01/12] vduse: add v1 API definition Eugenio Pérez
2026-01-09 15:24 ` [PATCH v11 02/12] vduse: add vq group support Eugenio Pérez
2026-01-10 23:44 ` Michael S. Tsirkin
2026-01-12 7:35 ` Eugenio Perez Martin
2026-01-12 8:00 ` Michael S. Tsirkin
2026-01-12 12:09 ` Eugenio Perez Martin
2026-01-09 15:24 ` [PATCH v11 03/12] vduse: return internal vq group struct as map token Eugenio Pérez
2026-01-09 15:24 ` [PATCH v11 04/12] vhost: move vdpa group bound check to vhost_vdpa Eugenio Pérez
2026-01-10 23:46 ` Michael S. Tsirkin
2026-01-12 7:38 ` Eugenio Perez Martin
2026-01-12 7:56 ` Michael S. Tsirkin
2026-01-09 15:24 ` [PATCH v11 05/12] vdpa: document set_group_asid thread safety Eugenio Pérez
2026-01-10 23:48 ` Michael S. Tsirkin
2026-01-12 7:39 ` Eugenio Perez Martin
2026-01-09 15:24 ` [PATCH v11 06/12] vhost: forbid change vq groups ASID if DRIVER_OK is set Eugenio Pérez
2026-01-10 23:49 ` Michael S. Tsirkin
2026-01-12 7:50 ` Eugenio Perez Martin
2026-01-09 15:24 ` Eugenio Pérez [this message]
2026-01-10 23:49 ` [PATCH v11 07/12] vduse: refactor vdpa_dev_add for goto err handling Michael S. Tsirkin
2026-01-12 7:51 ` Eugenio Perez Martin
2026-01-09 15:24 ` [PATCH v11 08/12] vduse: remove unused vaddr parameter of vduse_domain_free_coherent Eugenio Pérez
2026-01-09 15:24 ` [PATCH v11 09/12] vduse: take out allocations from vduse_dev_alloc_coherent Eugenio Pérez
2026-01-10 23:54 ` Michael S. Tsirkin
2026-01-12 9:26 ` Eugenio Perez Martin
2026-01-09 15:24 ` [PATCH v11 10/12] vduse: merge tree search logic of IOTLB_GET_FD and IOTLB_GET_INFO ioctls Eugenio Pérez
2026-01-10 23:56 ` Michael S. Tsirkin
2026-01-12 10:55 ` Eugenio Perez Martin
2026-01-16 6:40 ` kernel test robot
2026-01-09 15:24 ` [PATCH v11 11/12] vduse: add vq group asid support Eugenio Pérez
2026-01-11 0:03 ` Michael S. Tsirkin
2026-01-12 11:56 ` Eugenio Perez Martin
2026-01-12 12:00 ` Michael S. Tsirkin
2026-01-13 6:23 ` Jason Wang
2026-01-13 14:38 ` Eugenio Perez Martin
2026-01-14 7:32 ` Jason Wang
2026-01-14 8:21 ` Eugenio Perez Martin
2026-01-09 15:24 ` [PATCH v11 12/12] vduse: bump version number Eugenio Pérez
2026-01-13 6:25 ` Jason Wang
2026-01-13 15:09 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109152430.512923-8-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox