From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FAD332FA2B for ; Sun, 11 Jan 2026 09:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768122971; cv=none; b=eLE4olnfdyUqVLP1qy+1xw8rh5xgYhzWNS1dT9/6t/wYY9lKmBK9298JRaFisyxLHjpzzNLYE552jDdghUJuuKkj4q3BCYUCDKIJ7YhpMYjT/2k5NwZtgQPzDHw1hqMzheAh3tzbsSUeGAdX9GEPQCN1+sc6i3BiVQIHOQzXRck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768122971; c=relaxed/simple; bh=BZOccm4XxVdjIcV5Tne5ceXK0NuuvIGdkFXUs4hhCZY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=h05nYe7H0BAI4BDG5MCYi/tm3j9udLBvR4FGUBG7wzf/5h/QLNI4f7HI3PHg4vL5Klm3QHi7DFUae5GZP5D+t02gHXB9qj1hpx4BKAJJ1nO0liUEhevwEizGP95rhiSI+FEY5Bj5cDUdWs2zLyRVt2wD3VhiyRBn4LYaiTOnZAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HbM6d8JG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HbM6d8JG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768122969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WS2+XzdVc7BsmtGzyRzQokn3ZRi3QBRYwnL4Qo9AS50=; b=HbM6d8JGo14VIT0oghY8CjW/kDzJ0BdRuB+VL9HBN05BdZtoFJEt68tjdWb8UsyhWGcOHr ZEv2sdSC1dK9iglmWXPOduJIhUQOU7B6pkicWrtIKsmLa9zkRrLvcMc+g2GkOBLEUCWaQq cL6nZR2NWcD1hGAVh/Lootta1QdIE40= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-VXCA4mUdODmYRAa-Ul5Sgg-1; Sun, 11 Jan 2026 04:16:07 -0500 X-MC-Unique: VXCA4mUdODmYRAa-Ul5Sgg-1 X-Mimecast-MFC-AGG-ID: VXCA4mUdODmYRAa-Ul5Sgg_1768122966 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477964c22e0so31144855e9.0 for ; Sun, 11 Jan 2026 01:16:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768122966; x=1768727766; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WS2+XzdVc7BsmtGzyRzQokn3ZRi3QBRYwnL4Qo9AS50=; b=MTo2XVlbO4mC9BYQBCz4dGv2OhiZ2TIYiH+yKW/IUwDbPi7ge+pGmnkjkN0gm3/bD6 Fr7/l6yEByN/wBQ2iAEUQAwExBnEME/jC+aiyDMeX/KrqvuzmLmtkx8t00/SHVb7keaK Y4rwVpG8cbLuzNW+xB8wW9fvGlyAx9gRQLmCe5jDCY4OMd4LUiow86dbEbk7aO5sUvQB HEfEtZSxFNpFMd89Ckk3ef6apYZFGpJJzJb9mxZXIezF4oinDF7QNfblcBXZwjUlXJzN 9z4MsC+0mIlSRvtF//dStO9/Y1/mnpCRIGZWAAbKjYRAn88MCbWT9Rfec7jPGlVdHzi5 8JhQ== X-Forwarded-Encrypted: i=1; AJvYcCVDI+EtoW59xu8TnJQ5UKz5Eib9YuI9R3PVnai/rmttM4TDprqZFBZ1qOo9st5TT3x65/33r7Bm+WxZ9L1R/g==@lists.linux.dev X-Gm-Message-State: AOJu0YzoAYPAGfhLliShfwVybsJ594Pfy7ujccVYoCnfcUD8ZKZIOYpH XXWbHi7q7ne8vUMj0EKcw24tq96pvi/BdxPSDDFkQLZQn5l2Ok14zhTnYOcEqVMwPGsTTDCzL+x x3z5zvCUwgS0YbUHyLf/q8vYt1W79Xm3TTagZe96AbA0q2ePTdgDY4RXa+XVgBQJ/JsdM X-Gm-Gg: AY/fxX43AE2R0ujgLOR/C4qJVBI9LTvA7rr8ajPnyUhQVj+TMAuvQtpERdrMZbMeLbt oA6KasKqBKcWUrtrFGzBq2ZToVyN6TfzSMRc3MtBscfgtu1UKq2RDhak++CpzmeMI5y8qnhuhPX YiCxWBBbLZF1qsxBL1VbapnjAhHa+U2GJrVkashX6P5UoAe6Jfwqm5j2jerMVv0/bJvtw+hbD2E gjn/kzrgfICHuxuvA1jtgfYjs6nr3bAD3g1xfSOMeh5/qg/JmYWugCw1pAR0Xr9WzaAWJ58Ebm6 JO5dkUfijrLvEb1bczuGxHAm91PGZRf1ur3jlhBD3lwnxbxJcAT6CsT1Vupsox2iHknvA40WT6A y+TWrCm+g2r87tK0wVZpyZceptRxJd8k= X-Received: by 2002:a05:600c:3ba9:b0:477:9d88:2da6 with SMTP id 5b1f17b1804b1-47d847d0f30mr193215535e9.0.1768122966072; Sun, 11 Jan 2026 01:16:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1T4RKFHLydRXZSk4hv5pRkHtZL1MUAZhZsWSp+woZTG55Ip7dDXQ0exZCHM77fG+sLNTHpQ== X-Received: by 2002:a05:600c:3ba9:b0:477:9d88:2da6 with SMTP id 5b1f17b1804b1-47d847d0f30mr193214965e9.0.1768122965611; Sun, 11 Jan 2026 01:16:05 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f69e13bsm296398485e9.7.2026.01.11.01.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 01:16:05 -0800 (PST) Date: Sun, 11 Jan 2026 04:16:01 -0500 From: "Michael S. Tsirkin" To: Bobby Eshleman Cc: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH net-next v12 02/12] vsock: add netns to vsock core Message-ID: <20260111030617-mutt-send-email-mst@kernel.org> References: <20251126-vsock-vmtest-v12-0-257ee21cd5de@meta.com> <20251126-vsock-vmtest-v12-2-257ee21cd5de@meta.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20251126-vsock-vmtest-v12-2-257ee21cd5de@meta.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LVA3TtVMxneihb03OnultseX3QzvZzjmMFZxTbkZH6A_1768122966 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 26, 2025 at 11:47:31PM -0800, Bobby Eshleman wrote: > From: Bobby Eshleman > > Add netns logic to vsock core. Additionally, modify transport hook > prototypes to be used by later transport-specific patches (e.g., > *_seqpacket_allow()). > > Namespaces are supported primarily by changing socket lookup functions > (e.g., vsock_find_connected_socket()) to take into account the socket > namespace and the namespace mode before considering a candidate socket a > "match". > > This patch also introduces the sysctl /proc/sys/net/vsock/ns_mode that > accepts the "global" or "local" mode strings. > > Add netns functionality (initialization, passing to transports, procfs, > etc...) to the af_vsock socket layer. Later patches that add netns > support to transports depend on this patch. > > dgram_allow(), stream_allow(), and seqpacket_allow() callbacks are > modified to take a vsk in order to perform logic on namespace modes. In > future patches, the net and net_mode will also be used for socket > lookups in these functions. > > Signed-off-by: Bobby Eshleman > --- ... > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index adcba1b7bf74..6113c22db8dc 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c ... > @@ -2658,6 +2745,142 @@ static struct miscdevice vsock_device = { > .fops = &vsock_device_ops, > }; > > +static int vsock_net_mode_string(const struct ctl_table *table, int write, > + void *buffer, size_t *lenp, loff_t *ppos) > +{ > + char data[VSOCK_NET_MODE_STR_MAX] = {0}; > + enum vsock_net_mode mode; > + struct ctl_table tmp; nit: this file should now include linux/sysctl.h for this struct definition I think?