public inbox for virtualization@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Jason Wang" <jasowang@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Simon Horman" <horms@kernel.org>,
	netdev@vger.kernel.org, virtualization@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	"Kees Cook" <kees@kernel.org>
Subject: Re: [PATCH v2][next] virtio_net: Fix misalignment bug in struct virtnet_info
Date: Tue, 13 Jan 2026 18:16:58 -0800	[thread overview]
Message-ID: <20260113181658.0b65b96e@kernel.org> (raw)
In-Reply-To: <916a6c1a-681e-4e5e-8d49-75d0de5c46a1@redhat.com>

On Tue, 13 Jan 2026 16:06:05 +0100 Paolo Abeni wrote:
> > Probably but I'm yet to properly review it. The thing that puzzles me at
> > a first glance is how are things working right now then?  
> 
> Apparently they aren't ?!?
> 
> rss self-tests for virtio_net are failing:
> 
> https://netdev-ctrl.bots.linux.dev/logs/vmksft/drv-hw-dbg/results/471521/15-rss-api-py/stdout
> 
> but the result is into the CI reported as success (no idea why?!?)

To be clear this is a HW test so the fact that it shows up in CI as
green means just that the 2 sub cases (per [1]) which the CI judged 
to be stable and passing are still passing. The other 10 sub cases 
have never passed and still don't. IDK if you QEMU doesn't support 
RSS or it's something else but AFAICT this patch doesn't appear to 
make a difference to us.

[1] https://netdev.bots.linux.dev/devices.html

You can see the per-case breakdown of the history here (including 
the ignored sub-cases):
https://netdev.bots.linux.dev/flakes.html?tn-needle=drv-hw%2Fselftests-drivers-net-hw%2Frss-api-py&min-flip=0&br-pfx=net-next-hw&ld-cases=1

  parent reply	other threads:[~2026-01-14  2:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10  8:07 [PATCH v2][next] virtio_net: Fix misalignment bug in struct virtnet_info Gustavo A. R. Silva
2026-01-13 14:30 ` Paolo Abeni
2026-01-13 14:39   ` Michael S. Tsirkin
2026-01-13 15:06     ` Paolo Abeni
2026-01-13 15:09       ` Michael S. Tsirkin
2026-01-14  2:16       ` Jakub Kicinski [this message]
2026-01-14  7:18   ` Jason Wang
2026-01-14  8:53 ` Michael S. Tsirkin
2026-01-15  9:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113181658.0b65b96e@kernel.org \
    --to=kuba@kernel.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=gustavoars@kernel.org \
    --cc=horms@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox