From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S . Tsirkin " <mst@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
linux-kernel@vger.kernel.org, jasowang@redhat.com,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Maxime Coquelin" <mcoqueli@redhat.com>,
"Cindy Lu" <lulu@redhat.com>,
virtualization@lists.linux.dev,
"Yongji Xie" <xieyongji@bytedance.com>,
"Stefano Garzarella" <sgarzare@redhat.com>
Subject: [PATCH v14 12/13] vduse: bump version number
Date: Fri, 16 Jan 2026 15:04:54 +0100 [thread overview]
Message-ID: <20260116140455.1560491-13-eperezma@redhat.com> (raw)
In-Reply-To: <20260116140455.1560491-1-eperezma@redhat.com>
Finalize the series by advertising VDUSE API v1 support to userspace.
Now that all required infrastructure for v1 (ASIDs, VQ groups,
update_iotlb_v2) is in place, VDUSE devices can opt in to the new
features.
Assume API version 0 if the VDUSE instance does not call
VDUSE_GET_API_VERSION to maintain compatibility.
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
v12:
* Assume API version 0 by default if the VDUSE instance does not ask
(Jason).
---
drivers/vdpa/vdpa_user/vduse_dev.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 2727c0c26003..73d1d517dc6c 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -52,6 +52,15 @@
#define IRQ_UNBOUND -1
+/*
+ * VDUSE instance have not asked the vduse API version, so assume 0.
+ *
+ * Old devices may not ask for the device version and assume it is 0. Keep
+ * this value for these. From the moment the VDUSE instance ask for the
+ * version, convert to the latests supported one and continue regular flow
+ */
+#define VDUSE_API_VERSION_NOT_ASKED U64_MAX
+
struct vduse_virtqueue {
u16 index;
u16 num_max;
@@ -2153,6 +2162,8 @@ static long vduse_ioctl(struct file *file, unsigned int cmd,
mutex_lock(&vduse_lock);
switch (cmd) {
case VDUSE_GET_API_VERSION:
+ if (control->api_version == VDUSE_API_VERSION_NOT_ASKED)
+ control->api_version = VDUSE_API_VERSION_1;
ret = put_user(control->api_version, (u64 __user *)argp);
break;
case VDUSE_SET_API_VERSION: {
@@ -2163,7 +2174,7 @@ static long vduse_ioctl(struct file *file, unsigned int cmd,
break;
ret = -EINVAL;
- if (api_version > VDUSE_API_VERSION)
+ if (api_version > VDUSE_API_VERSION_1)
break;
ret = 0;
@@ -2180,6 +2191,8 @@ static long vduse_ioctl(struct file *file, unsigned int cmd,
break;
ret = -EINVAL;
+ if (control->api_version == VDUSE_API_VERSION_NOT_ASKED)
+ control->api_version = VDUSE_API_VERSION;
if (!vduse_validate_config(&config, control->api_version))
break;
@@ -2230,7 +2243,7 @@ static int vduse_open(struct inode *inode, struct file *file)
if (!control)
return -ENOMEM;
- control->api_version = VDUSE_API_VERSION;
+ control->api_version = VDUSE_API_VERSION_NOT_ASKED;
file->private_data = control;
return 0;
--
2.52.0
next prev parent reply other threads:[~2026-01-16 14:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 14:04 [PATCH v14 00/13] Add multiple address spaces support to VDUSE Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 01/13] vhost: move vdpa group bound check to vhost_vdpa Eugenio Pérez
2026-01-19 6:29 ` Jason Wang
2026-01-16 14:04 ` [PATCH v14 02/13] vduse: add v1 API definition Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 03/13] vduse: add vq group support Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 04/13] vduse: return internal vq group struct as map token Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 05/13] vdpa: document set_group_asid thread safety Eugenio Pérez
2026-01-19 6:30 ` Jason Wang
2026-01-16 14:04 ` [PATCH v14 06/13] vhost: forbid change vq groups ASID if DRIVER_OK is set Eugenio Pérez
2026-01-19 6:30 ` Jason Wang
2026-01-16 14:04 ` [PATCH v14 07/13] vduse: refactor vdpa_dev_add for goto err handling Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 08/13] vduse: remove unused vaddr parameter of vduse_domain_free_coherent Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 09/13] vduse: take out allocations from vduse_dev_alloc_coherent Eugenio Pérez
2026-01-19 6:42 ` Jason Wang
2026-01-16 14:04 ` [PATCH v14 10/13] vduse: merge tree search logic of IOTLB_GET_FD and IOTLB_GET_INFO ioctls Eugenio Pérez
2026-01-16 14:04 ` [PATCH v14 11/13] vduse: add vq group asid support Eugenio Pérez
2026-01-16 18:48 ` ALOK TIWARI
2026-01-19 7:16 ` Jason Wang
2026-01-19 8:09 ` Eugenio Perez Martin
2026-01-19 8:34 ` Jason Wang
2026-01-19 9:39 ` Michael S. Tsirkin
2026-01-19 10:29 ` Eugenio Perez Martin
2026-01-19 12:25 ` Jason Wang
2026-01-16 14:04 ` Eugenio Pérez [this message]
2026-01-16 14:04 ` [PATCH v14 13/13] Documentation: Add documentation for VDUSE Address Space IDs Eugenio Pérez
2026-01-16 18:41 ` ALOK TIWARI
2026-01-19 7:23 ` Eugenio Perez Martin
2026-01-19 7:19 ` Jason Wang
2026-01-19 7:40 ` Eugenio Perez Martin
2026-01-19 12:27 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116140455.1560491-13-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox