From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Srujana Challa <schalla@marvell.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
pabeni@redhat.com, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
andrew+netdev@lunn.ch, davem@davemloft.net,
ndabilpuram@marvell.com,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY_LEN
Date: Thu, 22 Jan 2026 08:52:53 -0800 [thread overview]
Message-ID: <20260122085253.33b93921@kernel.org> (raw)
In-Reply-To: <CANn89iL5s+egLhothNtnQf0jtAeftezUjNmbuXtUWgfVV3+bzg@mail.gmail.com>
On Thu, 22 Jan 2026 17:13:55 +0100 Eric Dumazet wrote:
> > Willem, WDYT? Is there a reason to keep the core key small?
> > Or deprecate netdev_rss_key_fill()?
>
> What do you mean by deprecating it ?
>
> One of the ideas was to make sure multiple NIC would share the same key,
> for some bonding setups.
>
> commit 960fb622f85180f36d3aff82af53e2be3db2f888 net: provide a per
> host RSS key generic infrastructure
Just wanted to put that option on the table, it wasn't clear to me what
the exact use case for the sysfs file was. Good to know that someone
cares :) thanks for the reference!
next prev parent reply other threads:[~2026-01-22 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 9:15 [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY_LEN Srujana Challa
2026-01-22 10:15 ` Michael S. Tsirkin
2026-01-23 11:37 ` [EXTERNAL] " Srujana Challa
2026-01-22 15:52 ` Jakub Kicinski
2026-01-22 16:13 ` Eric Dumazet
2026-01-22 16:17 ` Eric Dumazet
2026-01-22 16:52 ` Jakub Kicinski [this message]
2026-01-22 19:32 ` Willem de Bruijn
2026-01-22 19:42 ` Willem de Bruijn
2026-01-23 11:46 ` [EXTERNAL] " Srujana Challa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122085253.33b93921@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=schalla@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox