From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Cindy Lu" <lulu@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
linux-kernel@vger.kernel.org,
"Maxime Coquelin" <mcoqueli@redhat.com>,
"Yongji Xie" <xieyongji@bytedance.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
virtualization@lists.linux.dev
Subject: [PATCH 2/6] vduse: store control device pointer
Date: Wed, 28 Jan 2026 13:45:20 +0100 [thread overview]
Message-ID: <20260128124524.875271-3-eperezma@redhat.com> (raw)
In-Reply-To: <20260128124524.875271-1-eperezma@redhat.com>
This helps log the errors in next patches. The alternative is to
perform a linear search for it with class_find_device_by_devt(class, devt),
as device_destroy do for cleaning.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
drivers/vdpa/vdpa_user/vduse_dev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index a4963aaf9332..551ccde0b856 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -164,6 +164,7 @@ static DEFINE_IDR(vduse_idr);
static dev_t vduse_major;
static struct cdev vduse_ctrl_cdev;
+static const struct device *vduse_ctrl_dev;
static struct cdev vduse_cdev;
static struct workqueue_struct *vduse_irq_wq;
static struct workqueue_struct *vduse_irq_bound_wq;
@@ -2426,7 +2427,6 @@ static void vduse_mgmtdev_exit(void)
static int vduse_init(void)
{
int ret;
- struct device *dev;
ret = class_register(&vduse_class);
if (ret)
@@ -2443,9 +2443,9 @@ static int vduse_init(void)
if (ret)
goto err_ctrl_cdev;
- dev = device_create(&vduse_class, NULL, vduse_major, NULL, "control");
- if (IS_ERR(dev)) {
- ret = PTR_ERR(dev);
+ vduse_ctrl_dev = device_create(&vduse_class, NULL, vduse_major, NULL, "control");
+ if (IS_ERR(vduse_ctrl_dev)) {
+ ret = PTR_ERR(vduse_ctrl_dev);
goto err_device;
}
--
2.52.0
next prev parent reply other threads:[~2026-01-28 12:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 12:45 [PATCH 0/6] Add queue ready message to VDUSE Eugenio Pérez
2026-01-28 12:45 ` [PATCH 1/6] vduse: ensure vq->ready access is smp safe Eugenio Pérez
2026-01-29 1:16 ` Jason Wang
2026-01-29 6:20 ` Eugenio Perez Martin
2026-01-30 2:18 ` Jason Wang
2026-01-30 7:56 ` Eugenio Perez Martin
2026-02-03 4:05 ` Jason Wang
2026-02-03 10:35 ` Eugenio Perez Martin
2026-02-04 2:48 ` Jason Wang
2026-02-04 8:53 ` Eugenio Perez Martin
2026-02-05 4:04 ` Jason Wang
2026-02-05 6:30 ` Eugenio Perez Martin
2026-01-28 12:45 ` Eugenio Pérez [this message]
2026-01-28 12:45 ` [PATCH 3/6] vduse: Add API v2 definition Eugenio Pérez
2026-01-29 2:00 ` Jason Wang
2026-01-29 8:07 ` Eugenio Perez Martin
2026-01-30 2:17 ` Jason Wang
2026-01-30 8:12 ` Eugenio Perez Martin
2026-01-28 12:45 ` [PATCH 4/6] vduse: add VDUSE_GET_FEATURES ioctl Eugenio Pérez
2026-01-29 2:10 ` Jason Wang
2026-01-29 8:03 ` Eugenio Perez Martin
2026-01-28 12:45 ` [PATCH 5/6] vduse: add F_QUEUE_READY feature Eugenio Pérez
2026-01-29 2:12 ` Jason Wang
2026-01-29 6:26 ` Eugenio Perez Martin
2026-01-30 2:17 ` Jason Wang
2026-01-30 8:14 ` Eugenio Perez Martin
2026-02-03 4:00 ` Jason Wang
2026-02-03 7:27 ` Eugenio Perez Martin
2026-02-04 2:44 ` Jason Wang
2026-02-04 7:34 ` Eugenio Perez Martin
2026-02-05 4:08 ` Jason Wang
2026-02-05 6:38 ` Eugenio Perez Martin
2026-01-28 12:45 ` [PATCH 6/6] vduse: advertise API V2 support Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128124524.875271-3-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox