Re: [PATCH v10] can: virtio: Add virtio CAN driver

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Feb 26, 2026 at 03:08:28PM +0100, Harald Mommer wrote:
> Hello Matias,
> 
> On 2/17/26 11:24, Matias Ezequiel Vara Larsen wrote:
> 
> > +static int virtio_can_probe(struct virtio_device *vdev)
> > +{
> ...
> > +	priv->rpkt = devm_kzalloc(&vdev->dev, priv->rpkt_len *
> > +						priv->vqs[VIRTIO_CAN_QUEUE_RX]->num_free,
> > +						GFP_KERNEL);
> ...
> We're here clearly beyond column 80 with something which is not a string or a comment. Elsewhere we are also sometimes beyond column 80 but then only 1 or 2 characters which may or may not be acceptable by the kernel community. No idea. You may re-check the formatting.

it's relaxed recently - does not make sense to uglify code to fit
in 80 chars.

> Besides formatting:
> 
> I compared your actual v10 of the virtio CAN driver against my last v5 and and I saw nothing in your code which may cause a problem. Only learned doing the review this way that at some corners my old v5 code was not this bug free as I thought when I saw some changes. Nothing serious because in some "not expected to happen" corner case code paths but anyway I'll occasionally have to take over some of your changes into an internal project repository here.
> 
> We will see whether this virtio CAN device will be accepted in some near future for integration in the mainline kernel...
> 
> Regards
> Harald