From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD8F2046BA; Sat, 14 Mar 2026 20:06:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773518763; cv=none; b=WrJNAbIzQKE9arKUlnSwzlV/WV9sUpuh4JfxfMRWEBFPgNqd3DXzf/if3HkAzrNdUXdz6/EURaNT9mstYgiN52PnJYbvwJ6JxUxzD0VwfVFmPpA0v2N4HL76OHKSzfZbd+V71bn7DoUdXZI7Ee44id2UstzGq0IeyxuFU4aUCDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773518763; c=relaxed/simple; bh=Vedks8gdVTP9wSEvN7dGkLWh0D4RhYNYqCAWeATFhWc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fgDl4ylmUK8JuRRjG+ZTnMOu513N93m1ecsZpayL2x9vzUyLJG4gZKWOVpEWfTzSSV91H5gMxmHlq2Sn5Yp4dlDdRPUSkk9dAzSBg04m4u1P10n718uP1IbftUhr59gKfWMxVnTg/pPf6r3+OPD5TEK4iA0nN5B85xzhwlnQ54g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pTdtN5xI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pTdtN5xI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 083B3C116C6; Sat, 14 Mar 2026 20:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773518762; bh=Vedks8gdVTP9wSEvN7dGkLWh0D4RhYNYqCAWeATFhWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pTdtN5xIqR30KmjBfL2KVNQ1fJ3tNDtIqYf0GCDpV1TYBmDuvVkBMGOs1xffttMK/ rOEr7rz960iJaHe/9QXE3nJa+ajDGXJmF3XUXdlUbOL2okafXfWZdmzYL7PFO1g09d Ez1wRArCWruFWBeoSaCEPbFOPm9zlt5lkJfJK/IbbXgpfP3pP1DxZfOHx6BsFD37aq LzB6E0tUoFeWcu5U/SkLXe/vKZowq0dG9UWgRWUxP3wjAZoihPMETtdKpvhIq2UOJv xq/jBiILKhz03EHljS//m30IMJdncPWeXxuSt+DIVqGCcW+ILnks6x0hUohjf5uhZd +mmtcOLhMVYhw== Date: Sat, 14 Mar 2026 13:06:01 -0700 From: Jakub Kicinski To: I Viswanath Cc: stfomichev@gmail.com, horms@kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net, eperezma@redhat.com, xuanzhuo@linux.alibaba.com, jasowang@redhat.com, mst@redhat.com, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, jacob.e.keller@intel.com, ronak.doshi@broadcom.com, pcnet32@frontier.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, virtualization@lists.linux.dev, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v9 0/7] Introduce async callback ndo_set_rx_mode_async Message-ID: <20260314130601.0ec7a534@kernel.org> In-Reply-To: <20260314182809.362808-1-viswanathiyyappan@gmail.com> References: <20260314182809.362808-1-viswanathiyyappan@gmail.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 14 Mar 2026 23:58:02 +0530 I Viswanath wrote: > This is an implementation of the idea provided by Jakub here > > https://lore.kernel.org/netdev/20250923163727.5e97abdb@kernel.org/ > > The set_rx_mode callback is invoked under the addr_lock spinlock which > makes it illegal to sleep. This means set_rx_mode is prone to > sleep-in-atomic bugs as drivers have a tendency to do the I/O directly > in the callback. Stan is actively working on this: https://lore.kernel.org/20260313145113.1424442-1-sdf@fomichev.me I feel like I spent enough time reviewing your attempts and Stan will not need as much maintainer attention to bring this to a closure so let him cook. Sorry.