From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-2-111.ptr.blmpb.com (va-2-111.ptr.blmpb.com [209.127.231.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFDF38B12E for ; Mon, 13 Apr 2026 06:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.231.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776063185; cv=none; b=G7BPlQ9ji7uFGEzQPBlc0GvNtH4JN37IhVcw2veEctwRXGUOJtDFKJSw5ar7ZCOg9c76IV6vJ1E0TyY+xgSJo07lcb6AdnNhJtDbT5S4Y19fBMB8mj7ji72IeJ/4EqsjYizjFDKAaic+mPbb24K10MdEtvAZsQmAmtpB4fg0x5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776063185; c=relaxed/simple; bh=u6YITT5i3g3xtgW9vHR1/H4ETIGCGLKHnuU1y7MmgAg=; h=Cc:From:Subject:Content-Type:To:Date:Message-Id:Mime-Version; b=ZZHEIuj+fSpHdip+xWWZNVlhGDEVKwYnsdc37I0Dt6avxkP9tDci3pDZCbhNWcSgRQ+rT29Acif87aXMXT7Ts7sIgdLXizwsN6sENgiDQjssAQo9lWHJzyl+Bdfx/337EAiFF0Edkdv8A1MARgkt2EpDNSD8L3Bcz2DO5MwodWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=TqDavQnt; arc=none smtp.client-ip=209.127.231.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="TqDavQnt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1776063171; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=ZXothe/xKfm9FfMx4E0qgqfIEiuHvE3j/N2wGcAtYxw=; b=TqDavQntuKDSh00Ki6sB0RjiUhqGNCnjZj2QhdksM0ZkHiFhdXgp39gQcKQt2Bafo58rI1 4kpHxEebnDWsaaMGIlVAlCXXXhaqEuhMEmhZB7i6woVWR+dGACVv91BhrX78548YyiQH8h t8gM30YcPbb1kCPmgoM8Y4Vb213d65KmnCuXZxE3kAn9TZpmKVS9I2OdsGOvmz0gDWLJkb RLU4Z8MRhCi9p6l6w0Cp86ImjVdXUAb/IAA4s01OhXNIDBkE32O0vqSrB10KGgNyDhBmfK zPttJ9DwH4p9hECOUehoZx1ZZUiAYCYumfMpTe8631wng0cPUqMM/exeNI6NxA== Cc: , , , "Jinhui Guo" From: "Jinhui Guo" Subject: [PATCH] vfio/virtio: Fix lock/unlock mismatch in virtiovf_read_device_context_chunk() X-Lms-Return-Path: Content-Type: text/plain; charset=UTF-8 X-Mailer: git-send-email 2.17.1 Content-Transfer-Encoding: 7bit To: "Alex Williamson" , "Jason Gunthorpe" , "Yishai Hadas" , "Shameer Kolothum" , "Kevin Tian" Date: Mon, 13 Apr 2026 14:52:04 +0800 Message-Id: <20260413065204.30330-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: Jinhui Guo virtiovf_read_device_context_chunk() takes migf->list_lock with spin_lock() but releases it with spin_unlock_irq(). This mismatch can incorrectly enable interrupts if they were already disabled when the lock was acquired, leading to unbalanced IRQ state. Fix by using spin_lock_irq() to match spin_unlock_irq(). Fixes: 0bbc82e4ec79 ("vfio/virtio: Add support for the basic live migration functionality") Signed-off-by: Jinhui Guo --- drivers/vfio/pci/virtio/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c index 35fa2d6ed611..9fc24788fc04 100644 --- a/drivers/vfio/pci/virtio/migrate.c +++ b/drivers/vfio/pci/virtio/migrate.c @@ -621,7 +621,7 @@ virtiovf_read_device_context_chunk(struct virtiovf_migration_file *migf, buf->start_pos = buf->migf->max_pos; migf->max_pos += buf->length; - spin_lock(&migf->list_lock); + spin_lock_irq(&migf->list_lock); list_add_tail(&buf->buf_elm, &migf->buf_list); spin_unlock_irq(&migf->list_lock); return 0; -- 2.20.1