From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-1-111.ptr.blmpb.com (va-1-111.ptr.blmpb.com [209.127.230.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ADF7396B90 for ; Mon, 13 Apr 2026 07:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.230.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776065804; cv=none; b=tM2eNN9QS3ChXmWzAgX8CKLFdwrSpEDlmzA5oVq7L5gLBCICwWVYDcCLzZitW9Qwvioq4c4aFZh3iTJ778teWbMUWfSpA+C+bN1uj9cno3owYPIPGkEMeDrFrojDzTv896x7eUKEHvWTESU5FtQhNsujs9xmgnePGWQsTlPXEiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776065804; c=relaxed/simple; bh=udLn74JxhDF7Sr+0RcIAAIJPKdt0g6+Cyo54JAMtr2c=; h=Content-Type:To:Message-Id:Mime-Version:Cc:From:Subject:Date; b=SLTw+HPUqKKQfeJ7tgvQhWpbYPK/HSinSAnO0kjXcQy2GsBb7W2vCP+IEH1MbyFEP9zq/ycp8IsqVIoWFO0rDon8pqm6pW6gJAtQTJHgIBhbuDRu6i9Mypbd6eFkZSJRnYCgHSyn0ZvBciSgxkl6p7ZpaZe9AiyZlIkbJj87ZhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=Iw8uUTFY; arc=none smtp.client-ip=209.127.230.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="Iw8uUTFY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1776065789; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=rhZEIiDegqUPaC2rLzO5r5Di1IByvlqQfj2KNidppxM=; b=Iw8uUTFYnZ2FIz3xH412JTtnCTT3a07t5m4OUEVKuo0W6L63oTrfCiwXfwz93tnRtqXIhe w6s8E8LrQz6Z5bhPifuSbtdKy3ZkLtstf8cWBoPzwVng4rHuXgfMbKYFEFHx0pi6usT1MT My3/QShXwhlMD9xvqd31rXnmeZdXxRS7LGPMSmUe9qaEajcTgnP/Mu61d41ET1SK0huxmy 6T+uyLYLVhD0SOaS+tXdtPHrYmNKgAJ5Q0g0z/wi2+E04P9/vtc8Hq7OrHqu7hlw8YK7H0 1v9xeg425XQ6rqgjj6XXp1ussarS1KfbQHLYBckP4fkf79N5m+5Tr37r5QRBYw== Content-Type: text/plain; charset=UTF-8 To: "Alex Williamson" , "Jason Gunthorpe" , "Yishai Hadas" , "Shameer Kolothum" , "Kevin Tian" Message-Id: <20260413073603.30538-1-guojinhui.liam@bytedance.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Lms-Return-Path: X-Mailer: git-send-email 2.17.1 X-Original-From: Jinhui Guo Content-Transfer-Encoding: 7bit Cc: , , , "Jinhui Guo" , From: "Jinhui Guo" Subject: [RESEND PATCH] vfio/virtio: Fix lock/unlock mismatch in virtiovf_read_device_context_chunk() Date: Mon, 13 Apr 2026 15:36:03 +0800 virtiovf_read_device_context_chunk() takes migf->list_lock with spin_lock() but releases it with spin_unlock_irq(). This mismatch can incorrectly enable interrupts if they were already disabled when the lock was acquired, leading to unbalanced IRQ state. Fix by using spin_lock_irq() to match spin_unlock_irq(). Fixes: 0bbc82e4ec79 ("vfio/virtio: Add support for the basic live migration functionality") Cc: stable@vger.kernel.org Signed-off-by: Jinhui Guo --- Hi, Sorry for the noise. Resent with "Cc: stable@vger.kernel.org""; no other changes. Best regards, Jinhui drivers/vfio/pci/virtio/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c index 35fa2d6ed611..9fc24788fc04 100644 --- a/drivers/vfio/pci/virtio/migrate.c +++ b/drivers/vfio/pci/virtio/migrate.c @@ -621,7 +621,7 @@ virtiovf_read_device_context_chunk(struct virtiovf_migration_file *migf, buf->start_pos = buf->migf->max_pos; migf->max_pos += buf->length; - spin_lock(&migf->list_lock); + spin_lock_irq(&migf->list_lock); list_add_tail(&buf->buf_elm, &migf->buf_list); spin_unlock_irq(&migf->list_lock); return 0; -- 2.20.1