From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AD7383C76 for ; Thu, 21 May 2026 16:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779382000; cv=none; b=pxdIjMgHc69CUbRThLcNqprXtPEH80pIrJ6iQOGJbTRTBPMJnuEQ6oM9aMUztFw2pmbZnPBWc6tHyi7bas182DNwi5GwvHbPK4CY7Q+cmsmeEAa0wNs5AeR8dd4Kpjw/E1uGBijv347/6LqddIZdv4F4yCboH503LNjKG3FqUbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779382000; c=relaxed/simple; bh=55HpdrZ1XWqM3uwC+a47+vakAvshOA/Toys7NpGVJzc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LP3Yop5iXcI+xc/vYXgK/hCBa7PAWdOQLPE2JAcibmkws/H+TWIJHQjV7MhOITPljVAGMGtNG3e1mPrwiCs4+kcOJrPVoKRAkFAp14xxhnwWId8Qx4zwLayvLSvZMQNtpc++0t0muNgfCFnvuRZgCCOHCKqBUA8jAu+5X0OYOhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gY6Hqv/Q; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gY6Hqv/Q" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4903997fcb5so9530875e9.2 for ; Thu, 21 May 2026 09:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779381995; x=1779986795; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=NA/nM16UoxaTsk3A7SWQL7q3HkgK647mNtY2rDcRyyc=; b=gY6Hqv/QL5wpxrXWIj1UbAgmyvi477zx29y5cd4+7HiZdbC9f0A3AvYAZWTzWQafPW q3vsCMydXJHCt2jBoFAQfvOEbTf2ebpFWhWb2K/jSuhWx5X1vwYh3Kjn50/17BHcFA0R zs3Yd40XHa65leBARJwdtyankw+Meo3J5r6GN9gcEb6bPlzmF88fFaFDEkCb8RklLJTs 7us84anJYvbxuAjUhDpLwhoj2bEjVb0cwaW9pekoLstjQnVdflgFF3KwvPoe+7nWWAhi KF1BbRVYO8rGMiOBIVr4I3EIo9tLmNMbkgTxUAfnkzbPs20N0nAPXyklUMZX9Ydz7A2I kt/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779381995; x=1779986795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NA/nM16UoxaTsk3A7SWQL7q3HkgK647mNtY2rDcRyyc=; b=Bmd8ItcJQ3XwqMyuDCr5BVOqughvLWaZENHiqx23CtNp3FverlZAXm2a9j2txbKx/+ b6r3JdR+6iVv+wxBofq7vkRCFJ8ynJTXU0ZMqFNGtmaqhvSHX6VQ1nnSjquRWzymuckT /zLqgipZg+sPdkRRJewttM91R7KwO3s+4wRIPVJvKmaKHNoC8k846JK/q4wnEU7gfQP1 I9ABCAg6/WEKKx4r1uKSmw2mhJE9W2+5XUDMB8up2u1hbv0ezAykeS4v2qdbGhdDF2mf QSbNmTc0QKz5m+0mbXiXOmhdblK2iiU8TTdezVIyWNbECwg9MafNMIdI4oa9m0xhWwyt ryMw== X-Forwarded-Encrypted: i=1; AFNElJ+SeL+JL2jbNyG2G3LjY0cPDKeyrF+pdPs3fi3uHAbx353cXiNV7meihJNR53qYnBztlzD9K1jM/7icovHI8Q==@lists.linux.dev X-Gm-Message-State: AOJu0Yw2BV7q+O/5QbqoxETh/u2Yvec3qZFjGnJ8acWbFNIWwaTveUIT xM7I2Ki8Kkx/4VDIYsOWI6RHJkR8nXbm6gOb8d2RDcEJNpPCSGAMbdB9 X-Gm-Gg: Acq92OEEq3Rj6jZJSjRalBmiVUk9YDi6U2DAmiHUzeivV09qzlb+4vXBBIHSqoDD4nW DqxYzoYxoAAGbob17ZACraDvs8nkju3nNtswPhzRMQ2+LbgEGt58jw6Gn41HvzPCCXmaxpPSUby 9khEGEPJNeccrVGK0RDkqqnLxXOiGMqUrH6BSMYDM14iMKbj8/75QHvHn5zUa3Oj9aynlKAhDeS Wg51kXNV42rovU9lZ7Ype78rUo2a8RB3vkLoZrYiL5qAD5wtnpXFAcW+Yj0gJESGmfXye7LVMve Jrn9BHY6WE0+5PZ6HqdsKw0kvkd0OfAIGNmVLCifx1100p7L8b4Stvvp9yWECixozeBIG+r4Ff6 grQmnJehZMz7PbSQG/X3n9sqa0Zp1YqTz+IFuFORJG5chTj6LH4yU7ci960VwOeUCUy/nZrk3bK C2M6xf769/AiGkJ0huAKI3j1fmRlJGNDZEe5MgZfnMsIBvdGvJ3xAZCuoom4ezWvcz X-Received: by 2002:a05:600c:45c6:b0:488:ac01:72de with SMTP id 5b1f17b1804b1-49036033502mr53623425e9.5.1779381994891; Thu, 21 May 2026 09:46:34 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035ecac15sm31613075e9.6.2026.05.21.09.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 09:46:34 -0700 (PDT) Date: Thu, 21 May 2026 17:46:31 +0100 From: David Laight To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , stable@vger.kernel.org, Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Message-ID: <20260521174631.71a06440@pumpkin> In-Reply-To: <20260521133326.2465264-1-kees@kernel.org> References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-1-kees@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 06:33:14 -0700 Kees Cook wrote: > From: Pengpeng Hou > > param_array_get() appends each element's string representation into the > shared sysfs page buffer by passing buffer + off to the element getter. > > That works for getters that only write a small bounded string, but > param_get_charp() and similar helpers format against PAGE_SIZE from the > pointer they receive. Once off is non-zero, an element getter can > therefore write past the end of the original sysfs page buffer. > > Collect each element into a temporary PAGE_SIZE buffer first and then > copy only the remaining space into the caller's page buffer. Should this be using a 4k buffer on all architectures? Initially perhaps just using a different name for the constant until all the associated PAGE_SIZE limits have been removed. -- David > > Cc: stable@vger.kernel.org > Reviewed-by: Petr Pavlu > Signed-off-by: Pengpeng Hou > Signed-off-by: Kees Cook > --- > kernel/params.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/kernel/params.c b/kernel/params.c > index 74d620bc2521..752721922a15 100644 > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -475,22 +475,36 @@ static int param_array_set(const char *val, const struct kernel_param *kp) > static int param_array_get(char *buffer, const struct kernel_param *kp) > { > int i, off, ret; > + char *elem_buf; > const struct kparam_array *arr = kp->arr; > struct kernel_param p = *kp; > > + elem_buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > + if (!elem_buf) > + return -ENOMEM; > + > for (i = off = 0; i < (arr->num ? *arr->num : arr->max); i++) { > - /* Replace \n with comma */ > - if (i) > - buffer[off - 1] = ','; > p.arg = arr->elem + arr->elemsize * i; > check_kparam_locked(p.mod); > - ret = arr->ops->get(buffer + off, &p); > + ret = arr->ops->get(elem_buf, &p); > if (ret < 0) > - return ret; > + goto out; > + ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > + if (!ret) > + break; > + /* Replace the previous element's trailing newline with a comma. */ > + if (i) > + buffer[off - 1] = ','; > + memcpy(buffer + off, elem_buf, ret); > off += ret; > + if (off == PAGE_SIZE - 1) > + break; > } > buffer[off] = '\0'; > - return off; > + ret = off; > +out: > + kfree(elem_buf); > + return ret; > } > > static void param_array_free(void *arg)