From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: oe-kbuild@lists.linux.dev, "Eugenio Pérez" <eperezma@redhat.com>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
virtualization@lists.linux.dev,
"Jason Wang" <jasowang@redhat.com>, "Cindy Lu" <lulu@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
linux-kernel@vger.kernel.org,
"Laurent Vivier" <lvivier@redhat.com>,
"Yongji Xie" <xieyongji@bytedance.com>,
"Maxime Coquelin" <mcoqueli@redhat.com>
Subject: Re: [PATCH v3] vduse: Add suspend
Date: Thu, 11 Jun 2026 05:03:24 -0400 [thread overview]
Message-ID: <20260611050140-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202606111115.tKKe1qCE-lkp@intel.com>
On Thu, Jun 11, 2026 at 10:18:51AM +0300, Dan Carpenter wrote:
> Hi Eugenio,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Eugenio-P-rez/vduse-Add-suspend/20260610-164534
> base: next-20260609
> patch link: https://lore.kernel.org/r/20260610083452.477759-1-eperezma%40redhat.com
> patch subject: [PATCH v3] vduse: Add suspend
> config: arm64-randconfig-r072-20260610 (https://download.01.org/0day-ci/archive/20260611/202606111115.tKKe1qCE-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 8.5.0
> smatch: v0.5.0-9185-gbcc58b9c
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <error27@gmail.com>
> | Closes: https://lore.kernel.org/r/202606111115.tKKe1qCE-lkp@intel.com/
>
> smatch warnings:
> drivers/vdpa/vdpa_user/vduse_dev.c:577 vduse_vq_kick() warn: inconsistent returns '&vq->kick_lock'.
> drivers/vdpa/vdpa_user/vduse_dev.c:1302 vduse_dev_queue_irq_work() warn: inconsistent returns '&dev->rwsem'.
>
> vim +577 drivers/vdpa/vdpa_user/vduse_dev.c
>
> c8a6153b6c59d9 Xie Yongji 2021-08-31 562 static void vduse_vq_kick(struct vduse_virtqueue *vq)
> c8a6153b6c59d9 Xie Yongji 2021-08-31 563 {
> c8a6153b6c59d9 Xie Yongji 2021-08-31 564 spin_lock(&vq->kick_lock);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> c8a6153b6c59d9 Xie Yongji 2021-08-31 565 if (!vq->ready)
> c8a6153b6c59d9 Xie Yongji 2021-08-31 566 goto unlock;
> c8a6153b6c59d9 Xie Yongji 2021-08-31 567
> 9c4307e82fa1dc Eugenio Pérez 2026-06-10 568 guard(rwsem_read)(&vq->dev->rwsem);
> 9c4307e82fa1dc Eugenio Pérez 2026-06-10 569 if (vq->dev->suspended)
> 9c4307e82fa1dc Eugenio Pérez 2026-06-10 570 return;
>
> unlock before returning?
>
> 9c4307e82fa1dc Eugenio Pérez 2026-06-10 571
> c8a6153b6c59d9 Xie Yongji 2021-08-31 572 if (vq->kickfd)
> 3652117f854819 Christian Brauner 2023-11-22 573 eventfd_signal(vq->kickfd);
> c8a6153b6c59d9 Xie Yongji 2021-08-31 574 else
> c8a6153b6c59d9 Xie Yongji 2021-08-31 575 vq->kicked = true;
> c8a6153b6c59d9 Xie Yongji 2021-08-31 576 unlock:
> c8a6153b6c59d9 Xie Yongji 2021-08-31 @577 spin_unlock(&vq->kick_lock);
> c8a6153b6c59d9 Xie Yongji 2021-08-31 578 }
I think this is fixed by:
commit e4a249d15eb2d4b28213bebb1eefaf2e6d99de0b (HEAD -> vhost, linux-next-vhost/linux-next, kernel.org/vhost, kernel.org/test)
Author: Nathan Chancellor <nathan@kernel.org>
Date: Wed Jun 10 12:16:49 2026 -0700
vduse: Fix error around jumping over a __cleanup() variable
right?
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-06-11 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 8:34 [PATCH v3] vduse: Add suspend Eugenio Pérez
2026-06-10 19:10 ` kernel test robot
2026-06-11 7:18 ` Dan Carpenter
2026-06-11 9:03 ` Michael S. Tsirkin [this message]
2026-06-11 9:19 ` Dan Carpenter
2026-06-11 9:30 ` Eugenio Perez Martin
2026-06-11 10:38 ` Michael S. Tsirkin
2026-06-11 9:29 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611050140-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=error27@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox