From: Raf Dickson <rafdog35@gmail.com>
To: sgarzare@redhat.com
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
pabeni@redhat.com, stefanha@redhat.com,
bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, bobbyeshleman@gmail.com
Subject: Re: [PATCH net-next v2 1/2] vsock: fold sk_acceptq_added() into vsock_enqueue_accept()
Date: Thu, 11 Jun 2026 08:55:37 +0000 [thread overview]
Message-ID: <20260611085537.622665-1-rafdog35@gmail.com> (raw)
In-Reply-To: <aiptrtQIC5ivKjem@sgarzare-redhat>
On Thu, Jun 11, 2026 at 10:27:42AM +0200, Stefano Garzarella wrote:
> Maybe adding a new function that moves a socket from the pending queue
> to the accept queue avoiding also sock_put/sock_hold dance and
> sk_acceptq_removed()/sk_acceptq_added().
>
> To be called in vmci_transport_recv_connecting_server().
>
> So can we move sk_acceptq_added() also in vsock_add_pending()?
I like the vsock_pending_to_accept() approach, it makes the vmci
path clean without the double-accounting issue. Will send a v3 series
with that as patch 1, followed by folding sk_acceptq_added() into
vsock_add_pending() and sk_acceptq_removed() into vsock_remove_pending()
as separate patches.
Any preference on the name xd? vsock_pending_to_accept() works for me.
Raf
next prev parent reply other threads:[~2026-06-11 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 2:13 [PATCH net-next v2 0/2] vsock: fold acceptq accounting into core helpers Raf Dickson
2026-06-11 2:13 ` [PATCH net-next v2 1/2] vsock: fold sk_acceptq_added() into vsock_enqueue_accept() Raf Dickson
2026-06-11 8:27 ` Stefano Garzarella
2026-06-11 8:55 ` Raf Dickson [this message]
2026-06-11 9:41 ` Stefano Garzarella
2026-06-11 9:55 ` Raf Dickson
2026-06-11 9:59 ` Stefano Garzarella
2026-06-11 2:13 ` [PATCH net-next v2 2/2] vsock: fold sk_acceptq_removed() into vsock_remove_pending() Raf Dickson
2026-06-11 8:35 ` Stefano Garzarella
2026-06-11 8:56 ` Raf Dickson
2026-06-11 9:43 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611085537.622665-1-rafdog35@gmail.com \
--to=rafdog35@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bobbyeshleman@gmail.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=vishnu.dasa@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox