From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D232E3655D1; Sun, 21 Jun 2026 13:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782046995; cv=pass; b=ZH0nLlmkOj1sfba5aY7mxeKqV384MntGqptDuYFLHaCXPJullyL7sm9qimNOfIcbjZ9FXmRwTUbF/2B7NgTUvpp5ZUlHGvzK+flJhkCFP1bGrE+9BJHpqE60VWc2UDWel/wldyyFivukS6h/f5Wl8Z2u15KNU1BIPuLXaZsw2T8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782046995; c=relaxed/simple; bh=BObJGRZzmtRxVfVzdFlLpRgDXZJViibwtMW5khQwtNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kr45H6q/HqxIx3VM8XugPQBHYmjLuZsS/XTHbHglBkznsHQG+43AiqFJ+oT+CsqY/isV414jAI3k79c7bbtSP4hBsBfQB9eBhS5IMiSp2d+mIjEV7NQEfnJIyzewvLRrezp1JptP1hjzjD3S2N+sXGqlEyI4YxOoVXe2w34dysQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.beauty; spf=pass smtp.mailfrom=linux.beauty; dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty header.b=k+jt0Rnn; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.beauty Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.beauty Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty header.b="k+jt0Rnn" ARC-Seal: i=1; a=rsa-sha256; t=1782046988; cv=none; d=zohomail.com; s=zohoarc; b=FwjkGTc6hYYIgB9wwvkVKiUrXYQmqd9TgZwNDcg9I3ftcB1vTmiNW6RZVjJVK+cvZsvqRTGOM1PqcqX0F2x80xmUrmU/rnjusRC8X4qADO6EvhT8OoMxQwD/aYe1l3gw18V1w73/2NmzEO+/pPsNxynzcpnpcwUIkEkFs9xA2oM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782046988; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Kkm6b8v9HrmRxgveYsXGJWG4c5oEBQ3malO2AScRBME=; b=WSwjrjm9SXUuh4K8H3gNf72vApLE5G9bqLvRFGI/V0aJ+68fMM+DDHau+MMQQ3ELnqn9fCaOkn6yXXdnwRr74OMqTqadyw4aviuemmv47vzgoEPp3SpMAs7ygxeOD20zNl37d4CfDHgV31DTq5JxgibFWHpvMSDxHqhXunbBFI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782046988; s=zmail; d=linux.beauty; i=me@linux.beauty; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Kkm6b8v9HrmRxgveYsXGJWG4c5oEBQ3malO2AScRBME=; b=k+jt0RnnZHpeMTck8WP3eoK+qJPoaxDXW4+cfJIDj3MSpoLZgOAKaTD7HLrc8KuS w/25Trckyg2V9iI251BcN/q/OyePYCiyHMg7aQVtuHb4DkvuoRkQwnplolE5m79oZ6z uc8q2SabJ0xwJNosUhWp/arhpCRfYe6IwI3ZayXQ= Received: by mx.zohomail.com with SMTPS id 1782046985587100.80729899755318; Sun, 21 Jun 2026 06:03:05 -0700 (PDT) From: Li Chen To: Pankaj Gupta , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Alison Schofield , virtualization@lists.linux.dev, nvdimm@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Li Chen Subject: [PATCH v6 01/12] nvdimm: preserve flush callback errors Date: Sun, 21 Jun 2026 21:02:32 +0800 Message-ID: <20260621130246.2973254-2-me@linux.beauty> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260621130246.2973254-1-me@linux.beauty> References: <20260621130246.2973254-1-me@linux.beauty> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External nvdimm_flush() currently converts any non-zero provider flush error to -EIO. That loses useful errno values from provider callbacks. A local virtio-pmem mkfs sanity test showed the masking clearly: wipefs: /dev/pmem0: cannot flush modified buffers: Input/output error mkfs.ext4: Input/output error while writing out and closing file system nd_region region0: dbg: nvdimm_flush rc=-5 The virtio-pmem callback can return -ENOMEM when async_pmem_flush() fails to allocate a child flush bio, but nvdimm_flush() hides that as -EIO before pmem_submit_bio() converts it to a block status. Return the provider callback error directly. The generic flush path still returns 0, and pmem_submit_bio() already handles errno-to-blk_status conversion for bio completion. Signed-off-by: Li Chen --- v3->v4: - New patch. drivers/nvdimm/region_devs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index e35c2e18518f0..0cd96503c0596 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -1114,10 +1114,8 @@ int nvdimm_flush(struct nd_region *nd_region, struct bio *bio) if (!nd_region->flush) rc = generic_nvdimm_flush(nd_region); - else { - if (nd_region->flush(nd_region, bio)) - rc = -EIO; - } + else + rc = nd_region->flush(nd_region, bio); return rc; } -- 2.52.0