Linux virtualization list
 help / color / mirror / Atom feed
From: Li Chen <me@linux.beauty>
To: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	virtualization@lists.linux.dev, nvdimm@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, Li Chen <me@linux.beauty>
Subject: [PATCH v6 05/12] nvdimm: virtio_pmem: use GFP_NOIO for flush requests
Date: Sun, 21 Jun 2026 21:02:36 +0800	[thread overview]
Message-ID: <20260621130246.2973254-6-me@linux.beauty> (raw)
In-Reply-To: <20260621130246.2973254-1-me@linux.beauty>

virtio_pmem_flush() can run from pmem_submit_bio() while filesystem IO
is waiting on the flush completion. The request object allocation can
sleep, but it should not enter filesystem or block IO reclaim from this
flush path.

Use GFP_NOIO for the request allocation. The virtqueue descriptor
allocation still uses GFP_ATOMIC because it runs under pmem_lock.

Signed-off-by: Li Chen <me@linux.beauty>
---
Changes in v6:
- New patch; keep GFP_NOIO only for the virtio-pmem request allocation.

 drivers/nvdimm/nd_virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
index 4b2e9c47af0f5..91ca144607531 100644
--- a/drivers/nvdimm/nd_virtio.c
+++ b/drivers/nvdimm/nd_virtio.c
@@ -55,7 +55,7 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
 		return -EIO;
 	}
 
-	req_data = kmalloc_obj(*req_data);
+	req_data = kmalloc_obj(*req_data, GFP_NOIO);
 	if (!req_data)
 		return -ENOMEM;
 
-- 
2.52.0

  parent reply	other threads:[~2026-06-21 13:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-21 13:02 [PATCH v6 00/12] nvdimm: virtio_pmem: fix request lifetime and converge broken queue failures Li Chen
2026-06-21 13:02 ` [PATCH v6 01/12] nvdimm: preserve flush callback errors Li Chen
2026-06-23  9:46   ` Pankaj Gupta
2026-06-27  8:53     ` Li Chen
2026-06-21 13:02 ` [PATCH v6 02/12] nvdimm: pmem: keep PREFLUSH before data writes Li Chen
2026-06-21 13:02 ` [PATCH v6 03/12] nvdimm: pmem: guard data loop for dataless bios Li Chen
2026-06-21 13:02 ` [PATCH v6 04/12] nvdimm: virtio_pmem: stop allocating child flush bio Li Chen
2026-06-24 17:22   ` Pankaj Gupta
2026-06-27 12:44     ` Li Chen
2026-06-21 13:02 ` Li Chen [this message]
2026-06-21 13:02 ` [PATCH v6 06/12] nvdimm: virtio_pmem: always wake -ENOSPC waiters Li Chen
2026-06-21 13:02 ` [PATCH v6 07/12] nvdimm: virtio_pmem: use READ_ONCE()/WRITE_ONCE() for wait flags Li Chen
2026-06-23  8:34   ` Pankaj Gupta
2026-06-21 13:02 ` [PATCH v6 08/12] nvdimm: virtio_pmem: refcount requests for token lifetime Li Chen
2026-06-21 13:02 ` [PATCH v6 09/12] nvdimm: virtio_pmem: publish done with release/acquire Li Chen
2026-06-21 13:02 ` [PATCH v6 10/12] nvdimm: virtio_pmem: isolate DMA request buffers Li Chen
2026-06-21 13:02 ` [PATCH v6 11/12] nvdimm: virtio_pmem: converge broken virtqueue to -EIO Li Chen
2026-06-21 13:02 ` [PATCH v6 12/12] nvdimm: virtio_pmem: drain requests in freeze Li Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260621130246.2973254-6-me@linux.beauty \
    --to=me@linux.beauty \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=virtualization@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox