From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93D613E8330; Tue, 30 Jun 2026 09:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782811464; cv=pass; b=WQRrK/K2VKVTBoJoOHL0Tp7sI5QqFv2I5J/udV6cAV/pkp/HSaTS624Dl7i0cX/r3YMTe0DbrY3bQ6MF3KBIIeojKTHl71wrY+neRAS2N2pCXB35HcyY6CS5vc8/wv+QqJkM55GtsBgIML8josmGUYQqvtCM6QMzccebaXaA6B8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782811464; c=relaxed/simple; bh=yNGrEJlXC/3Kj2L50w8PBQwDVtyNG/aExJYIOATyaIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NMrUVbKOVk7ZoHeSIRwPIMOB/uf23oIIwM89vLAT3MephNBpnrvxC4bKJjQAvOak3t8phHe+EWXyLziOh4Anxrg2lAptNplUm2sSSiEopyBJfq9ZtWF4caXgTSKua08IW0mt+Z42R+s4zqCWU63fLMX0+oOceN4KM82pcJ1vqyI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.beauty; spf=pass smtp.mailfrom=linux.beauty; dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty header.b=Siatnupv; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.beauty Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.beauty Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty header.b="Siatnupv" ARC-Seal: i=1; a=rsa-sha256; t=1782811443; cv=none; d=zohomail.com; s=zohoarc; b=L+u6Fmf2x2oguNaTRPIbxb/0O2OSThKtr9jFDt/qeJmustvvlpc9AMwXnvu6P0BBa8gLFIJmfd7TPKpL0TB/9suDAJKtuzqbDNKygY/m9L4UhLRJE3XptneDO3bkSt5235ZqHKFJ0cvDMCOKAXKR9uR1vsp3qfW1Nedzr89tHcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782811443; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=l+TairmX9egfA9LqMO7TzDhHCGZIpaTe4WqZKhyGKds=; b=APF269aS7WsZWebC+0+JRQqpPRPnUmaEmvRnezKxVju6O2EPbewg5gqDJK6B5D00z5QRUnpqFAeaayeAfqGFbWOphUFb8agw+hTVoNU6nA8qfM8vqtBuwLGTd7tbdA3TG3O7bcbNGwxouS2Yhlaqo7+6IGi7cwSaWxOP51D4g68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782811443; s=zmail; d=linux.beauty; i=me@linux.beauty; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=l+TairmX9egfA9LqMO7TzDhHCGZIpaTe4WqZKhyGKds=; b=Siatnupv6204YrPK2svoEN0Ri0CaRkZBfNJzV6FT0QG0A/ychuoP8afQsGxJB4J2 SRfF8mECDE3GQ7hwc7hZoYNvg9VXcxIH74a6LnMq7yDKssNUzxo0/IOMYztr7uUB2yF 5RDake7BadOXomPuaxUSyzLlhXf6CzritrWE3Dmw= Received: by mx.zohomail.com with SMTPS id 1782811441310821.0554398994373; Tue, 30 Jun 2026 02:24:01 -0700 (PDT) From: Li Chen To: Pankaj Gupta , Vishal Verma , Dave Jiang , Alison Schofield , virtualization@lists.linux.dev, nvdimm@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Li Chen Subject: [PATCH v7 02/12] nvdimm: pmem: keep PREFLUSH before data writes Date: Tue, 30 Jun 2026 17:23:27 +0800 Message-ID: <20260630092338.2094628-3-me@linux.beauty> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260630092338.2094628-1-me@linux.beauty> References: <20260630092338.2094628-1-me@linux.beauty> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External pmem_submit_bio() records a REQ_PREFLUSH error, but continues to copy the bio data and can later overwrite the error with a successful REQ_FUA flush. That lets data writes run after a failed preflush and can complete the bio successfully despite the failed ordering barrier. Run the REQ_PREFLUSH flush synchronously before touching the bio data and complete the bio with the flush error if it fails. Keep asynchronous flush chaining for REQ_FUA. At that point, data copy has completed and the parent bio can wait for the chained flush bio. Signed-off-by: Li Chen --- Changes in v5: - New patch. drivers/nvdimm/pmem.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 92c67fbbc1c85..05d3de33e2706 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -208,8 +208,14 @@ static void pmem_submit_bio(struct bio *bio) struct pmem_device *pmem = bio->bi_bdev->bd_disk->private_data; struct nd_region *nd_region = to_region(pmem); - if (bio->bi_opf & REQ_PREFLUSH) - ret = nvdimm_flush(nd_region, bio); + if (bio->bi_opf & REQ_PREFLUSH) { + ret = nvdimm_flush(nd_region, NULL); + if (ret) { + bio->bi_status = errno_to_blk_status(ret); + bio_endio(bio); + return; + } + } do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) @@ -229,7 +235,7 @@ static void pmem_submit_bio(struct bio *bio) if (do_acct) bio_end_io_acct(bio, start); - if (bio->bi_opf & REQ_FUA) + if ((bio->bi_opf & REQ_FUA) && !bio->bi_status) ret = nvdimm_flush(nd_region, bio); if (ret) -- 2.52.0