From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6860346FB0 for ; Sat, 18 Jul 2026 23:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417768; cv=none; b=u3xmYiEls27sJQcjvTXvlKYnRhgfin7e5VDtJGDLm8/3f612txwpni2HLxmsODA/8APSTmVG0N52ci4NgWNfIR/0e6oOvniQcfGDSoSQGWd35mZ3VaWcOSRTfZTchKExHM/JwwZ2P7tmJj2PoyhT+/LKWEuoKaRm6tlganCXC98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417768; c=relaxed/simple; bh=ZH81L3uHWN97/YC8FIR37Q/EWDlCtHMgy9u61P6CSM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bEDosuoX2AlqAcp9EA6KDScQvxdAUszKzYANBPE8LwaHKxsPw4uU1fi6k0L0C2vbkSjcX7ojJVqcSpJ0G1z3mf+vNTrP82RmoSkLfWaJg1rkGk7FoBkiO2eolnxQfxWEH+GTqrdt2aajEaZ5gYOIuR+h1PpzO5OdvKIz+gXnNdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JCOI+bwm; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JCOI+bwm" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4954d29264cso6769825e9.2 for ; Sat, 18 Jul 2026 16:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417765; x=1785022565; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oxJhJqOvpAaSiQeGabxE955gR5KY+0a4asEx/JWs7Lo=; b=JCOI+bwmE+KMGYTSuC+IDq/nFAyrX1OhDY8wC8EekgGvI6uIOdFa2TBCe55NAuvGu1 zvPPB28Ae1nGdTc1gs3wGKTx3pw2l1MlItCyOJYj82XLd9KIp9JtCCAnQxKe5VruoSuQ c8FEk0kAbLxxSreeTvpoPekHhknN1Tftx6iJ7PYhcRj0czIarUwhjV3l0nszovdzjDqy Et+yrJrlPuLI51dImIIyeOp5oFXlB/x5/jOHgarhkTZH8wI3upvJe00ch2dKCJ4t+I/p N6gkcIz5o1DWY2yuBx3O5NXCUwYwdyFslNvIHjJTLliItDvzWDRN4W6+7od9ar8lSCiS eRiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417765; x=1785022565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oxJhJqOvpAaSiQeGabxE955gR5KY+0a4asEx/JWs7Lo=; b=B+rb1PA1XZeANAO5ewNrFsLDq4dcQktd7+qGYM7Z1B/n43SC0AhwljMvgMcy5a6M7c aAhLLn8E1mYfR0GDJrx3e7VUnsog+90DgAvTXMqyga5+hFvYHabIVMc/QDsP+UI6b5o5 E7hxEJbkId5EHZ26Z7UMtjqZPIguA+dpNPL0KoeQ77BfI7xfTcbcyzXFLtQuaQ6Pz/sz NhOmwqoHRGAtgiBAGUpquhIE+NMddPMzRurcdC+qWFh7xsqInk/i6d+ZS0eSeiMZtGEu KopeWVFvlokZQDB0tA5jCkgIA7D5MEQZ9Y3wCE7m+S6yB2LXJ9t8Upe4rmlE5/cvhy1I iXJw== X-Forwarded-Encrypted: i=1; AHgh+Rrp5u9hLY0GHb8q0Y8dk2bKcKZabn4pZhk8+rOkPZtnuHMPKCkuBHWqTU7ToI1/NrnZllpj0S3UyQt1m7kyeQ==@lists.linux.dev X-Gm-Message-State: AOJu0YyHN0pmP+s8MHYPDBN0kiHVDxRWVvBh8aSTzHkDKEB+Eo/kZMkN Y12/atJzKnR0P9127FzL9eDo4kc0E3dgJyJ5x1wG5TYDe49+rPa4lvIG X-Gm-Gg: AfdE7cmxjk2UN+Hs4OtML+94C2d1TmKJFeaW1DXStzuXDTEUAKCXi955ugc621HyCJZ OVMoHQFdKQnude1KtMXbPsx/+laxKQ3jFqdn6kz6wePwkF1q3ttGu0B74Ztcqw0cLkDOLsM/wrl ecP5dTm8NKA/4dBbYwQAPwfX+3Usa1ukgeJi5OJxtOOT1A13HmxFx7/0MiXKvqGtLkZh8lXpOak lPdjcP7mhmxkrKT/TthVo/e3yM1f8C/7R80tNoLyGEiFp0bYeQJAm4rpz/o3LsyPiXEQ/ryHAKR VNovlSrGsUIuH1HXxDVDhmUDj9FyVVYWRhiZX2glQkEJ4VG9xCbNzGqsgDb1zMC5VPcFFLmmfQH eVW0Qcm3cnXEMX3HbXS5qQdWSFoLlD5InOBPGQ8pZ82DcYz2EdUGNbbikt/T+NW9ZmRL64G86QM kddnGwQeOPew== X-Received: by 2002:a05:600c:4ec6:b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-4954d5c913dmr76289525e9.7.1784417764814; Sat, 18 Jul 2026 16:36:04 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:04 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:33 +0200 Subject: [PATCH 02/15] drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-2-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index d5f922450565..1d194c2824e3 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -417,6 +416,10 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = { .minor = 0, }; +static const struct drm_encoder_funcs zynqmp_dpsub_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) { struct drm_encoder *encoder = &dpsub->drm->encoder; @@ -436,7 +439,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) /* Create the encoder and attach the bridge. */ encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc); - drm_simple_encoder_init(&dpsub->drm->dev, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(&dpsub->drm->dev, encoder, + &zynqmp_dpsub_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + dev_err(dpsub->dev, "failed to initialize encoder\n"); + return ret; + } ret = drm_bridge_attach(encoder, dpsub->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); -- 2.54.0