From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB857437120 for ; Mon, 20 Jul 2026 15:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562095; cv=none; b=H4SuaJSKTFO9Ry6LyKQ8PKPKre/gtGMHr9IT3c4yLudSCiqhSPkzPunuXJYWX4yIZ/4wW2PRHdeJO1AKG7+Y/bqNymR1ArEOREhpnjdAgndXQK5QmxuVkLzbiXKmLPPB84UjQ+i9ZoOA1RpIKwyQZpjyfvWE/4SQpes/LhDZf2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562095; c=relaxed/simple; bh=v9DwgKRLbmJruTxxwltkPfgfMQ/xrenPmg2doUmkQsk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eAJTq4pKQDpBKX427fJ9I8eynTphNbF+TT/WX23jVXQ6GrG7srKDR/na6WUplKlBh3jp6VRyawXAVTYxiOOQyK7+qGYYOC7YvphEHyOB1YbHNqVc82eCHi7Am6dr/gPszepYfZ+vsqupw3dcB1/2l/L2Zczkc717WljJ8IFXzqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nV1bHxhp; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nV1bHxhp" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47de0093c42so5587531f8f.3 for ; Mon, 20 Jul 2026 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562092; x=1785166892; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=glDDRAcdG2z8u1IQ6JIBLAUYK0TMezc+/0A/g0HZvjw=; b=nV1bHxhpshdpAlnK37n4KWIbLGwOxJFqKKAnW1MGa5/sy0iuu4iTtFYU3oifsJyzKD kF7XkBIRLJg8TbZw8BNkSy4Zecv3qsyFWqDKF7TOk1//KxVDYq/8sr2gVVB4+Md+tYTK a+6VYOFBhnOZNz4Ujz5qX0md1kPQrteo2RsQdSAikeyut2IaGHlY7dDXgCT8ptSOdcZX 4oGuWes/9jmsswLx1RggVM+Pjfsq9Ud1mSJk/EUOGXhZBrO6az0Lf+FUMplNm0Q9devy 5WPtkLeE8Uv8Gd5xdPyirgm5QQ2Sn4EtcDprHxV0zY5py15AHqFRl16m1y8+IRP/v7Sb Azkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562092; x=1785166892; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=glDDRAcdG2z8u1IQ6JIBLAUYK0TMezc+/0A/g0HZvjw=; b=ZSpKhJsgHn0XN5m5iUeDzMVeYFpbG4iHZ7Qav+pFjQY9enwXO9xPXh8rI4J4t30vu1 oZ5wOxhA5Fhw9baH3iSd6/G1lLE3awZEf8lw56uDgd/uYZhO/Di5uukM+HXtGVYVVBP0 NafiHj0lDQqFz7PY2aXr7++lH/0/UUS31hmllwPODZRSx5Ot8Oz2IfFntfn7AnmHS1gS tkz0+i3l4Syw5MkGk51QKeZlLKy6WHwNLCl3epdjtPSNmE+4Q8QHfIZqo+2tG7cVku3n lfL3Qo31sIcvYhsYNqn9mqoJMIMsm5VunUW5slwHgXQSrY8xT5B1yPx5d0zDK+0nLRRg lYbQ== X-Forwarded-Encrypted: i=1; AHgh+Ro6g/40PRLxAiKhMvatl57xH3+6XBAPdTuYQVRW/PMwfQat7d7irclFDYr8KScX6oRIbRLllUoFKHZVachRgQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwXYBSgkB7FEPijfPPMr1uKLTiR+GO5GoPPvKJMNPwThx55fR/W CWhRzY6B4cYK05vlmCIbt+lYUyo47d3p++is8ctGqMxKxVnzjfNEnoVY X-Gm-Gg: AR+sD13xtN235IEVCJfEk+OlNgZHZ+tFCpyX1u5cZ09JbRVxMy6ZuquB04PBAv3UNis 0nd8XFPOdQpP02MnkMW+hMXwDo6NzbhV63FapyfVuNcx/8JAM0wDaZzpb4wiiIJTOBi6vbFPhc0 RmT0lx7x4ky8RU27Ht71GZ/XYAjXN3d5fYli/dp8m9MhzmHZp4nIPJ4Y/BBklfZUtMQkMWNNLZy 6lCsX1KToM+etKeE1awskBI1AqWJehV7B9Xnyj2f1dSzipPY2DIzVWv4UK3wRS5IDCiWWoXW7cT hl0EQZezbIzuU4bYyxJurxlU8VeUIHsv6dXLDpD3n1YPinZy4LE6Rr+5qTjxje1aTcgeB7TZOkc zclG/zqJ+hjwfUlwNErGIitLNQBRMFQEN7/5npz1c41oRxpRJm5nckmMf3aaIWZk+rzGoEkGdzX pqyntPNPhrsw== X-Received: by 2002:a05:6000:29c8:b0:47f:699b:a80c with SMTP id ffacd0b85a97d-47f699ba8a2mr8405565f8f.52.1784562091837; Mon, 20 Jul 2026 08:41:31 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:31 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:44 +0200 Subject: [PATCH v2 12/15] drm/arm/komeda: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-12-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index e8cb782a6f8e..719568d9f7c2 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c @@ -11,9 +11,9 @@ #include #include +#include #include #include -#include #include #include "komeda_dev.h" @@ -635,6 +635,10 @@ static int komeda_attach_bridge(struct device *dev, return err; } +static const struct drm_encoder_funcs komeda_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int komeda_crtc_add(struct komeda_kms_dev *kms, struct komeda_crtc *kcrtc) { @@ -658,7 +662,8 @@ static int komeda_crtc_add(struct komeda_kms_dev *kms, * bridge */ kcrtc->encoder.possible_crtcs = drm_crtc_mask(crtc); - err = drm_simple_encoder_init(base, encoder, DRM_MODE_ENCODER_TMDS); + err = drm_encoder_init(base, encoder, &komeda_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); if (err) return err; -- 2.54.0