From: Francesco Valla <francesco@valla.it>
To: Haixu Cui <quic_haixcui@quicinc.com>, Mark Brown <broonie@kernel.org>
Cc: virtualization@lists.linux.dev, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Francesco Valla <francesco@valla.it>
Subject: [PATCH] spi: virtio: drop duplicate completion init
Date: Sun, 30 Aug 2026 15:48:35 +0200 [thread overview]
Message-ID: <20260830-virtio-spi-fix-v1-1-62f486f4acdc@valla.it> (raw)
The completion iused for SPI transfers is initialized twice in the
same function, without it being used in between. Drop the redundant
initialization.
Signed-off-by: Francesco Valla <francesco@valla.it>
---
drivers/spi/spi-virtio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-virtio.c b/drivers/spi/spi-virtio.c
index 2256dfec5407..87ce32b6d133 100644
--- a/drivers/spi/spi-virtio.c
+++ b/drivers/spi/spi-virtio.c
@@ -162,8 +162,6 @@ static int virtio_spi_transfer_one(struct spi_controller *ctrl,
if (!spi_req)
return -ENOMEM;
- init_completion(&spi_req->completion);
-
th = &spi_req->transfer_head;
/* Fill struct spi_transfer_head */
---
base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
change-id: 20260830-virtio-spi-fix-ca33b12bab2b
Best regards,
--
Francesco Valla <francesco@valla.it>
next reply other threads:[~2026-08-30 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 13:48 Francesco Valla [this message]
2026-08-30 21:51 ` [PATCH] spi: virtio: drop duplicate completion init Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830-virtio-spi-fix-v1-1-62f486f4acdc@valla.it \
--to=francesco@valla.it \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_haixcui@quicinc.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox