From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Westphal <fw@strlen.de>
Cc: Geliang Tang <geliang@kernel.org>, Amit Shah <amit@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <kees@kernel.org>,
Geliang Tang <tanggeliang@kylinos.cn>,
virtualization@lists.linux.dev, Sungho Bae <baver.bae@lge.com>
Subject: Re: [PATCH] virtio_console: pass gfp flag through in alloc_buf()
Date: Sat, 5 Sep 2026 13:37:28 +0200 [thread overview]
Message-ID: <2026090555-abstract-unshipped-385b@gregkh> (raw)
In-Reply-To: <apts2h6pyF1ePHBW@strlen.de>
On Sat, Sep 05, 2026 at 03:14:17AM +0200, Florian Westphal wrote:
> Geliang Tang <geliang@kernel.org> wrote:
>
> [ CC Sungho Bae ]
>
> Ping, I still get this splat on mainline, this patch fixes things for
> me, so
>
> Tested-by: Florian Westphal <fw@strlen.de>
>
> Could someone push this to Linus please (if not yet queued up)?
>
> Thanks.
>
> > put_chars() correctly passes GFP_ATOMIC, but alloc_buf() silently
> > discards it and allocates with GFP_KERNEL, which may sleep.
> >
> > Pass the caller-supplied gfp flag through to kmalloc_flex() so
> > that atomic callers get atomic allocations.
> >
> > Fixes: 69050f8d6d07 ("treewide: Replace kmalloc with kmalloc_obj for non-scalar types")
>
>
> Hmm, probably:
>
> Fixes: fc220d6be3c7 ("virtio_console: refactor __send_to_port() buffer ownership")
>
> ... as that adds "gfp_t gfp", but doesn't fix up kmalloc_flex() which
> has GFP_KERNEL as a hidden argument via macro expansion.
Sorry, this is on me, I've been swamped, will try to get this to him
"soon".
greg k-h
next prev parent reply other threads:[~2026-09-05 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 1:20 [PATCH] virtio_console: pass gfp flag through in alloc_buf() Geliang Tang
2026-09-05 1:14 ` Florian Westphal
2026-09-05 11:37 ` Greg Kroah-Hartman [this message]
2026-09-05 17:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090555-abstract-unshipped-385b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=baver.bae@lge.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=kees@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox