From: sashiko-bot@kernel.org
To: physicalmtea@gmail.com
Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev,
"Eugenio Perez" <eperezma@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/2] vhost-scsi: preserve event ordering
Date: Tue, 15 Sep 2026 09:51:59 +0000 [thread overview]
Message-ID: <20260915095200.620501F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915094244.7900-2-physicalmtea@gmail.com>
> From: Jia Jia <physicalmtea@gmail.com>
>
> vhost_scsi_send_evt() uses llist_add(), so pending events are LIFO.
> vhost_scsi_complete_events() walks the detached list directly.
> This can deliver a later hotplug or hotunplug event before an earlier
> one.
>
> Reverse the detached list before processing it.
> This keeps delivery in enqueue order.
>
> Fixes: a6c9af87363c ("tcm_vhost: Add hotplug/hotunplug support")
> Signed-off-by: Jia Jia <physicalmtea@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915094244.7900-1-physicalmtea@gmail.com?part=1
next prev parent reply other threads:[~2026-09-15 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:42 [PATCH 0/2] vhost-scsi: preserve event ordering and fix fallback deadlock physicalmtea
2026-09-15 9:42 ` [PATCH 1/2] vhost-scsi: preserve event ordering physicalmtea
2026-09-15 9:51 ` sashiko-bot [this message]
2026-09-15 21:00 ` Mike Christie
2026-09-15 9:42 ` [PATCH 2/2] vhost-scsi: do not relock event vq mutex on send_evt fallback physicalmtea
2026-09-15 9:52 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915095200.620501F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=physicalmtea@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox