From: sashiko-bot@kernel.org
To: "Sebastian von Arx" <linux@sebastianvonarx.ch>
Cc: "Eugenio Perez" <eperezma@redhat.com>,
virtualization@lists.linux.dev, dri-devel@lists.freedesktop.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 2/2] drm/virtio: Propagate drm_encoder_init() errors
Date: Sun, 20 Sep 2026 19:31:06 +0000 [thread overview]
Message-ID: <20260920193106.A66201F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260920184244.464343-3-linux@sebastianvonarx.ch>
> vgdev_output_init() ignores errors from drm_encoder_init(), so output
> setup continues even when encoder initialization fails, for example
> because of an allocation failure.
>
> Check the return value and propagate the error to the caller.
>
> Assisted-by: LLM
> Signed-off-by: Sebastian von Arx <linux@sebastianvonarx.ch>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920184244.464343-2-linux@sebastianvonarx.ch?part=2
prev parent reply other threads:[~2026-09-20 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 18:42 [PATCH 0/2] drm/virtio: Open-code drm_simple_encoder_init() Sebastian von Arx
2026-09-20 18:42 ` [PATCH 1/2] " Sebastian von Arx
2026-09-20 19:29 ` sashiko-bot
2026-09-20 18:42 ` [PATCH 2/2] drm/virtio: Propagate drm_encoder_init() errors Sebastian von Arx
2026-09-20 19:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920193106.A66201F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=linux@sebastianvonarx.ch \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox