From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606EB481AA0 for ; Wed, 23 Sep 2026 10:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790158884; cv=none; b=G5FE1XwzIcjTc57yOS7ogMLU8I/zYXHLwsxzzHRdafuVZ79L425/Cmoipbb+CVa72KzLjo+2irGARaQMuhMIQLPleszF3P4EMxquFwzj4035kUq3Ujcol/LDHAnPFXFiaWbwm+4B3uDr1WF1AHJbR60+iL4S16YiVyb8vi01d1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790158884; c=relaxed/simple; bh=4qjSqIjJRSLWY8kT8aUZHOXLRBvJpPrV+p/O0kGjplU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=OSwHmhRzYMfOAW0mV1//TCVrFEuzPCIpCgTRCwVE3TA/jB/Nb2mkdJdXuHXGJkppbHPWdRGwgEg0mGixnqpor0pvGPT17us/+t4nWoOmAQK4rSkJ28COyYtW3+WevML8SbagXlMdBj7Iyx7LFtllEnjQvnluH0f665WQW/husoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Po4whxyI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Po4whxyI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790158877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A/yNGk5DmsVVa7FPt1z8YmmINF36yskI05CuGhzTjCI=; b=Po4whxyIPwX+uXFs8GVs8XB0kys95jd6YxDPNREAUKPBMSMba11cO+p6I1KpMBVrzsQVck IwLeUJjltTqXtDo9RGKM7swUQjKjNhgDCGe2Z1KCBc7W3qBxytf0a+NhMYYHV9AMZs4rVK oVZmhRg3dvEUAoOvOy68iyII5OGd7IA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-qlM-ALQoNHCnbcbOZjjcHQ-1; Wed, 23 Sep 2026 06:21:16 -0400 X-MC-Unique: qlM-ALQoNHCnbcbOZjjcHQ-1 X-Mimecast-MFC-AGG-ID: qlM-ALQoNHCnbcbOZjjcHQ_1790158875 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49953abe51fso4825185e9.1 for ; Wed, 23 Sep 2026 03:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790158875; x=1790763675; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A/yNGk5DmsVVa7FPt1z8YmmINF36yskI05CuGhzTjCI=; b=r8a1CAQroWQ8g8vo0V54N5adbJuc4Vi6e9f0TYznoaUgzFAxTfw7icecCLQuoTyXMW sBzgfh9z+YLbUks55hDyNBzvYqoUxc//2JZPznEi/PECBF7yUVYjJCOeONwdFHtEMm7Q ZEs62sM0ZKZO+bcjjz9iG6Cv6i3qeuZN3N7Hkakq/H3crwYkgjYprOrnlGxXiC5NGsZH Ht2kwj2pv1d/EilDMbXr57eXfej7lSF4o8kfzU8vkEULkKSnpedCfio3vAVASgjnAeOd 3i/bAXD031YUPOfeNZiIV9uTGyt8ahMyWqNezUB7+Imf5pwkGbRFVCiCjVLeB0zEktN/ U1yQ== X-Forwarded-Encrypted: i=1; AKwUvBwxZMc9I07Oibj2pvFp1Dpy9ndGwD5TXmNYsQOln+FWIpbSFr8OH3Rci+hYyolGcj7JDLIR9iNlMJfwCdl5Vw==@lists.linux.dev X-Gm-Message-State: AFuF++n/JajfCfegpvB0DUVU5Rwn4RhSQ+CEgszRQFHe+hOlGQfygTup FT75Bmr89eqWd31tcFAgUqrh6iupEQd1sZozTRj0qLKrVY408wlV0RSuitNcAXqJiBzYdN2jUV9 CYdjfU/LxFvWCPb7bs1G9wvNlQILnEvWPgioPJdryrrye69BzaWNjJcsg2iuw1jAAXomW X-Gm-Gg: AYBFou2DlyJ0mC6dqnlvSFiiIK5x+gaAPgDxyImTJ3z50hXR0k+LDzUOwomqxgBLszC 0O2BS6Ws0IagUbgmFMUc0G0yw/vx98inQdITvRr+N3I8e99qRmSfVAppEEcH6wpd67SUhok4V88 GN9JTgDop83jHBIr2IxaWdvKo4QQC0XV6ZO3QGS34NX1yXlGgJv37MS6QAV4Nk5Y7+f8hm+pBJq 9oxFTaWsbfAc8XFLLiE8A8XW0k/f4DI1PE4HIeqVlWDsMTvq7JTHo6TMBvBnOGGK14640SkmmGw 1jYTYNhEuY8NQzO6OaXxOv3PinYsrIWC4sGlFtlgdkBojhGqS/i7IQKs3WcnjsUrBEvRDA== X-Received: by 2002:a05:600c:4712:b0:49d:2536:402e with SMTP id 5b1f17b1804b1-49fdf24f928mr27541985e9.30.1790158875098; Wed, 23 Sep 2026 03:21:15 -0700 (PDT) X-Received: by 2002:a05:600c:4712:b0:49d:2536:402e with SMTP id 5b1f17b1804b1-49fdf24f928mr27541455e9.30.1790158874532; Wed, 23 Sep 2026 03:21:14 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:3fd7:5300:3d6b:52a4:a23f:9d0b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdf9691e2sm57317795e9.1.2026.09.23.03.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 03:21:13 -0700 (PDT) Date: Wed, 23 Sep 2026 06:21:09 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: Paulos Yibelo , netdev@vger.kernel.org, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, jasowangio@gmail.com, eperezma@redhat.com, xuanzhuo@linux.alibaba.com, andrew+netdev@lunn.ch, pablo@netfilter.org, fw@strlen.de, phil@nwl.cc, razor@blackwall.org, idosch@nvidia.com, dsahern@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-um@lists.infradead.org, virtualization@lists.linux.dev, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v6 1/2] net: validate virtio checksum start after network header Message-ID: <20260923061215-mutt-send-email-mst@kernel.org> References: <20260922030310.8684-1-habte.yibelo@gmail.com> <20260922030310.8684-2-habte.yibelo@gmail.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1lo1xsBshHuxvE5xsS_k2nBhPbZPz4uJdi2FYNpLKJI_1790158875 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 22, 2026 at 09:27:26PM -0400, Willem de Bruijn wrote: > Willem de Bruijn wrote: > > Paulos Yibelo wrote: > > > __virtio_net_hdr_to_skb() checks a minimum network-header length for > > > CHECKSUM_PARTIAL packets. Its checksum start is relative to skb->data, > > > but some callers have not established skb->network_header when they > > > convert the virtio header. > > > > > > Pass the data-relative L3 origin explicitly. Ethernet receive paths > > > parse the frame and nested VLAN headers without changing skb state. > > > AF_PACKET uses the frame's actual L3 origin even when the socket > > > protocol is ETH_P_IP and the raw frame carries VLAN tags. Non-Ethernet > > > AF_PACKET devices retain their established skb network offset. > > > > > > Also pass the actual L3 protocol so IPv6 packets use the 40-byte base > > > header minimum even without TCPv6 GSO. IFF_TUN obtains that protocol > > > from the packet before skb->protocol is set. Name the Ethernet parser > > > accordingly, use the same origin for tunnel validation, and propagate > > > conversion failures in UML. > > > > > > The bound remains a minimum; fragmentation paths separately validate > > > the parsed IPv4 or IPv6 header length before completing a checksum. > > > > > > Fixes: 49d14b54a527 ("net: test for not too small csum_start in virtio_net_hdr_to_skb()") > > > Fixes: a2fb4bc4e2a6 ("net: implement virtio helpers to handle UDP GSO tunneling.") > > > Reported-by: Paulos Yibelo > > > Link: https://lore.kernel.org/netdev/20260920004733.6473-2-habte.yibelo@gmail.com/ > > > Cc: stable@vger.kernel.org > > > Assisted-by: LLM > > > Signed-off-by: Paulos Yibelo > > > --- > > > arch/um/drivers/vector_transports.c | 13 ++++- > > > drivers/net/tun_vnet.h | 52 ++++++++++++++++- > > > drivers/net/virtio_net.c | 10 +++- > > > include/linux/virtio_net.h | 87 ++++++++++++++++++++++++----- > > > net/packet/af_packet.c | 24 +++++++- > > > 5 files changed, 163 insertions(+), 23 deletions(-) > > > > The fix may still miss the case IPv4 packets have options. > > > > This version is a very large patch. > > > > Untested shorter first suggestion by bot, which looks plausible as a > > starting point for discussion. > > Cleaned up some more: > > diff --git a/drivers/net/tun_vnet.h b/drivers/net/tun_vnet.h > index f4c652b1fa44..c24607af2aad 100644 > --- a/drivers/net/tun_vnet.h > +++ b/drivers/net/tun_vnet.h > @@ -180,6 +180,9 @@ static inline int tun_vnet_hdr_put(int sz, struct iov_iter *iter, > static inline int tun_vnet_hdr_to_skb(unsigned int flags, struct sk_buff *skb, > const struct virtio_net_hdr *hdr) > { > + if ((flags & TUN_TYPE_MASK) == IFF_TUN) > + skb_reset_network_header(skb); > + > return virtio_net_hdr_to_skb(skb, hdr, tun_vnet_is_little_endian(flags)); > } > > @@ -199,6 +202,9 @@ tun_vnet_hdr_tnl_to_skb(unsigned int flags, netdev_features_t features, > struct sk_buff *skb, > const struct virtio_net_hdr_v1_hash_tunnel *hdr) > { > + if ((flags & TUN_TYPE_MASK) == IFF_TUN) > + skb_reset_network_header(skb); > + > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > index c381b916c1b5..02c448de0802 100644 > --- a/include/linux/virtio_net.h > +++ b/include/linux/virtio_net.h > @@ -48,6 +48,42 @@ static inline int virtio_net_hdr_set_proto(struct sk_buff *skb, > return 0; > } > > +static inline int virtio_net_hdr_nh_min_len(const struct sk_buff *skb, > + unsigned int nh_min_len) > +{ > + int thoff = skb_transport_offset(skb); > + __be16 proto; > + int nhoff; > + > + if (skb_network_header_was_set(skb)) { > + nhoff = skb_network_offset(skb); > + proto = skb->protocol; > + } else { > + if (unlikely(thoff < ETH_HLEN)) > + return -EINVAL; > + nhoff = ETH_HLEN; > + proto = eth_hdr(skb)->h_proto; > + } > + > + if (eth_type_vlan(proto)) { > + proto = __vlan_get_protocol(skb, proto, &nhoff); > + if (!proto) > + return -EINVAL; > + } > + > + if (proto == htons(ETH_P_IP)) { > + const struct iphdr *iph = (void *)(skb->data + nhoff); > + > + if (unlikely(thoff < nhoff + sizeof(*iph))) > + return -EINVAL; > + nh_min_len = max_t(u32, iph->ihl * 4, sizeof(*iph)); > + } else if (proto == htons(ETH_P_IPV6)) { > + nh_min_len = sizeof(struct ipv6hdr); > + } > + > + return nhoff + nh_min_len; > +} > + > static inline int __virtio_net_hdr_to_skb(struct sk_buff *skb, > const struct virtio_net_hdr *hdr, > bool little_endian, u8 hdr_gso_type) > @@ -98,13 +134,15 @@ static inline int __virtio_net_hdr_to_skb(struct sk_buff *skb, > u32 start = __virtio16_to_cpu(little_endian, hdr->csum_start); > u32 off = __virtio16_to_cpu(little_endian, hdr->csum_offset); > u32 needed = start + max_t(u32, thlen, off + sizeof(__sum16)); > + int min_thoff; > > if (!pskb_may_pull(skb, needed)) > return -EINVAL; > > if (!skb_partial_csum_set(skb, start, off)) > return -EINVAL; > - if (skb_transport_offset(skb) < nh_min_len) > + min_thoff = virtio_net_hdr_nh_min_len(skb, nh_min_len); > + if (min_thoff < 0 || skb_transport_offset(skb) < min_thoff) > return -EINVAL; Certainly looks much better. But I'd like to ask, generally: doesn't the net stack need to protect against weird packets? It seems likely that not all drivers validate headers defensively, and incoming packets can easily become outgoing ones. So do we even need virtio specific validation, or is it enough to validate everything in the net stack, where we are poking at the header anyway? Or maybe it's more a defense in depth thing? My worries: - more poking at the header, more cache misses, where we really do not need that - future protocol extensions that now will require surgery in virtio, instead of just being passed through to the host What do others think? -- MST