From: sashiko-bot@kernel.org
To: "David Carlier" <devnexen@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH net-next v2 1/2] vsock: report pending receive data to io_uring
Date: Wed, 23 Sep 2026 18:46:54 +0000 [thread overview]
Message-ID: <20260923184655.31D671F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923184008.153541-2-devnexen@gmail.com>
> AF_VSOCK stream receives never fill msghdr.msg_inq, so io_uring cannot set
> IORING_CQE_F_SOCK_NONEMPTY and retries a multishot receive even after the
> queue has been drained.
>
> Fill the hint at the common receive exit using the transport callback that
> SIOCINQ already uses, and report 1 once the connection is finished so the
> caller performs the receive which observes EOF, as TCP does after a FIN.
>
> A vsock loopback ping-pong with io_uring multishot receive drops entries
> into __vsock_connectible_recvmsg from 1.97 to 1.00 per delivered message,
> and receiver CPU time by about 3% (25 runs of 50000 messages, p=0.006).
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923184008.153541-1-devnexen@gmail.com?part=1
next prev parent reply other threads:[~2026-09-23 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:40 [PATCH net-next v2 0/2] vsock: receive queue hint for io_uring David Carlier
2026-09-23 18:40 ` [PATCH net-next v2 1/2] vsock: report pending receive data to io_uring David Carlier
2026-09-23 18:46 ` sashiko-bot [this message]
2026-09-28 15:00 ` Stefano Garzarella
2026-09-23 18:40 ` [PATCH net-next v2 2/2] vsock/test: cover receive queue hints David Carlier
2026-09-23 18:46 ` sashiko-bot
2026-09-23 19:29 ` Bobby Eshleman
2026-09-28 15:00 ` Stefano Garzarella
2026-09-29 0:30 ` [PATCH net-next v2 0/2] vsock: receive queue hint for io_uring patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923184655.31D671F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=devnexen@gmail.com \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox