From: sashiko-bot@kernel.org
To: "Matheus Alves de Almeida" <matheus.aalmeida@inf.ufrgs.br>
Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev,
"Eugenio Perez" <eperezma@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] drm/qxl: return -ENODEV for unsupported revisions
Date: Wed, 30 Sep 2026 22:24:26 +0000 [thread overview]
Message-ID: <20260930222427.0E2DD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930222214.69443-1-matheus.aalmeida@inf.ufrgs.br>
> The qxl driver currently returns -EINVAL when the emulated qxl revision
> is too old. This is not a driver initialization failure but rather a
> match rejection, which should return -ENODEV.
>
> Change the value returned when the qxl revision is below 4 to -ENODEV.
> Switch the xf86-video-qxl suggestion log to be info level, as this is
> not an error.
>
> Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
> Signed-off-by: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930222214.69443-1-matheus.aalmeida@inf.ufrgs.br?part=1
next prev parent reply other threads:[~2026-09-30 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 22:22 [PATCH] drm/qxl: return -ENODEV for unsupported revisions Matheus Alves de Almeida
2026-09-30 22:24 ` sashiko-bot [this message]
2026-10-01 6:34 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930222427.0E2DD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=matheus.aalmeida@inf.ufrgs.br \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox