From: Karthikeyan KS <karthiproffesional@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: sashiko-reviews@lists.linux.dev,
Mike Christie <michael.christie@oracle.com>,
Jia Jia <physicalmtea@gmail.com>,
Eugenio Perez <eperezma@redhat.com>,
virtualization@lists.linux.dev, kvm@vger.kernel.org
Subject: Re: [PATCH RESEND] vhost-scsi: use FOLL_PIN for DMA page pinning
Date: Tue, 3 Nov 2026 17:06:13 +0000 [thread overview]
Message-ID: <20261103170613.162803-1-karthiproffesional@gmail.com> (raw)
In-Reply-To: <20261102073033-mutt-send-email-mst@kernel.org>
On Mon, Nov 02, 2026 at 07:30:54AM -0500, Michael S. Tsirkin wrote:
> Karthikeyan were you going to address this review?
Yes. The leak Sashiko found predates this patch (the same loop leaked a
put_page() reference) and is fixed in your tree by Jia Jia's
058fc59326af ("vhost-scsi: fix page reference leak in misaligned I/O
fallback"). v2 is rebased on it and only switches that loop to
unpin_user_page():
https://lore.kernel.org/20261103165917.148720-1-karthiproffesional@gmail.com
Thanks,
Karthikeyan
prev parent reply other threads:[~2026-11-03 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 18:26 [PATCH RESEND] vhost-scsi: use FOLL_PIN for DMA page pinning Karthikeyan KS
2026-10-21 18:27 ` sashiko-bot
2026-11-02 12:30 ` Michael S. Tsirkin
2026-11-03 17:06 ` Karthikeyan KS [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103170613.162803-1-karthiproffesional@gmail.com \
--to=karthiproffesional@gmail.com \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=physicalmtea@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox