From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Mete Durlu <meted@linux.ibm.com>, Yury Norov <ynorov@nvidia.com>,
"Ionut Nechita (Sunlight Linux)" <sunlightlinux@gmail.com>,
frederic@kernel.org
Cc: arighi@nvidia.com, chleroy@kernel.org, christian.loehle@arm.com,
corbet@lwn.net, dietmar.eggemann@arm.com,
gregkh@linuxfoundation.org, hdanton@sina.com,
huschle@linux.ibm.com, iii@linux.ibm.com, jgross@suse.com,
juri.lelli@redhat.com, kernellwp@gmail.com,
kprateek.nayak@amd.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, maddy@linux.ibm.com,
maz@kernel.org, mingo@kernel.org, pauld@redhat.com,
pbonzini@redhat.com, peterz@infradead.org, rafael@kernel.org,
rdunlap@infradead.org, rostedt@goodmis.org, seanjc@google.com,
tglx@kernel.org, tj@kernel.org, tommaso.cucinotta@gmail.com,
vincent.guittot@linaro.org, vineeth@bitbyteword.org,
virtualization@lists.linux.dev, vschneid@redhat.com,
yury.norov@gmail.com
Subject: Re: [PATCH] Re: [PATCH v10 00/12] sched, steal_governor: Introduce preferred CPUs and steal-driven vCPU backoff
Date: Thu, 13 Aug 2026 16:42:04 +0530 [thread overview]
Message-ID: <20aa609c-6b11-41a1-875e-3aaba2809883@linux.ibm.com> (raw)
In-Reply-To: <a4478425-1914-47d1-b5ec-5e11dba048dd@linux.ibm.com>
Hi Mete, Thanks for going through the patches/discussions.
On 8/13/26 12:20 PM, Mete Durlu wrote:
> Hi all,
>
> All of the points raised by Ionut are about governor lacking
> certain logic for a specific arch. Considering what Shrikanth
> mentions under "Future Work";
>
> """
> Known Limitations & Future Work
> ===============================
> ...
> - Arch specific hints and framework for it as been deferred to
> the future.
> ...
> """
>
> I think all of these points can be addressed better if
> Xen used said framework and implemented their own governor
> module. That way we wouldn't see an overinflated single
> steal_governor but instead nicely separated arch/platform
> specific ones, that are tailored best for their needs.
> The current implementation could be the fallback option
> if platform does not implement their own and would also
> serve as an example.
For now, I prefer adding a defensive check for dom0
and keep the driver simple.
>
> I really think we should follow the example of cpuidle
> drivers and how their framework brings together so many
> platforms under a single roof.
>
But I remember fredric saying it isn't ideal either and he had
planned to clean it up. (Fredric, correct me if i remember it wrong)
> Thanks!
> -Mete
I prefer we defer the arch specific hooks for now, until there is a need
for one. If you guys insist it should be done, then i can start looking
at cpuidle framework. But it will be a bigger rework.
But if the patch given in other thread is good enough for XEN, then we
could keep it simple one file for the time being.
If the driver eventually outgrows a single file, we can work on a
modular framework post-merge. But for now, let's keep it simple and get
the simple version upstream.
Thoughts?
next prev parent reply other threads:[~2026-08-13 11:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 5:40 [PATCH v10 00/12] sched, steal_governor: Introduce preferred CPUs and steal-driven vCPU backoff Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 01/12] sched/cputime: Add kcpustat_field_total helper Shrikanth Hegde
2026-08-12 18:44 ` Yury Norov
2026-08-12 5:40 ` [PATCH v10 02/12] sched/docs: Document cpu_preferred_mask and Preferred CPU concept Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 03/12] cpumask: Introduce cpu_preferred_mask Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 04/12] sysfs: Add preferred CPU file Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 05/12] sched/core: Try to use a preferred CPU in is_cpu_allowed Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 06/12] sched/fair: Load balance only among preferred CPUs Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 07/12] sched/core: Push current task from non preferred CPU Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 08/12] sched/debug: Add migration stats due to non preferred CPUs Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 09/12] virt: Introduce steal governor driver Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 10/12] virt/steal_governor: Add control knobs for handling steal values Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 11/12] virt/steal_governor: Implement steal_governor policy loop Shrikanth Hegde
2026-08-12 5:40 ` [PATCH v10 12/12] virt/steal_governor: Enable the driver Shrikanth Hegde
2026-08-12 19:45 ` [PATCH] Re: [PATCH v10 00/12] sched, steal_governor: Introduce preferred CPUs and steal-driven vCPU backoff Ionut Nechita (Sunlight Linux)
2026-08-13 0:13 ` Yury Norov
2026-08-13 6:50 ` Mete Durlu
2026-08-13 11:12 ` Shrikanth Hegde [this message]
2026-08-13 10:56 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20aa609c-6b11-41a1-875e-3aaba2809883@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=arighi@nvidia.com \
--cc=chleroy@kernel.org \
--cc=christian.loehle@arm.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=huschle@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jgross@suse.com \
--cc=juri.lelli@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=maz@kernel.org \
--cc=meted@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=sunlightlinux@gmail.com \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=virtualization@lists.linux.dev \
--cc=vschneid@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox