From: "Morris Pan (潘泰為)" <Morris.Pan@mediatek.com>
To: "airlied@redhat.com" <airlied@redhat.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"dmitry.osipenko@collabora.com" <dmitry.osipenko@collabora.com>
Cc: "virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"gurchetansingh@chromium.org" <gurchetansingh@chromium.org>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"olvaffe@gmail.com" <olvaffe@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [PATCH] drm/virtgpu: Add PM support for suspend/resume
Date: Fri, 17 Apr 2026 09:40:51 +0000 [thread overview]
Message-ID: <26884a5a6043ce2d146456644cd7e37278b0edb0.camel@mediatek.com> (raw)
In-Reply-To: <2175a05a-d83f-4252-bbf8-581ae652a6b8@collabora.com>
On Wed, 2026-04-08 at 15:59 +0300, Dmitry Osipenko wrote:
> Hi,
>
> On 4/1/26 09:10, Morris Pan wrote:
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c
> > b/drivers/gpu/drm/virtio/virtgpu_drv.c
> > index a5ce96fb8a1d..fbca0a82958c 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
> > @@ -145,6 +145,40 @@ static void virtio_gpu_config_changed(struct
> > virtio_device *vdev)
> > schedule_work(&vgdev->config_changed_work);
> > }
> >
> > +#ifdef CONFIG_PM_SLEEP
> > +static int virtgpu_freeze(struct virtio_device *vdev)
> > +{
> > + vdev->config->del_vqs(vdev);
> > + virtio_reset_device(vdev);
> > +
> > + return 0;
> > +}
>
> VirtIO-GPU shouldn't be reset freely. See [1] and follow previous
> hibernation-support discussions on the ML.
>
> [1[
> https://lore.kernel.org/dri-devel/20260107182745.229481-1-dongwon.kim@intel.com/
>
>
Hi Dmitry,
Thank you for the guidance and for pointing me to that thread.
I have looked into the series you mentioned, specifically "PATCH v7
1/3: drm/virtio: Freeze and restore hooks to support suspend and
resume" (link).
I have verified that this change resolves the issue I was experiencing
in my envirronment.
I will keep an eye on that series and follow its progress. Thank you
for your time and help.
Best regards,
Morris Pan
next prev parent reply other threads:[~2026-04-17 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 6:10 [PATCH] drm/virtgpu: Add PM support for suspend/resume Morris Pan
2026-04-01 6:24 ` Thomas Zimmermann
2026-04-08 7:04 ` Morris Pan (潘泰為)
2026-04-08 12:59 ` Dmitry Osipenko
2026-04-17 9:40 ` Morris Pan (潘泰為) [this message]
2026-04-30 22:49 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26884a5a6043ce2d146456644cd7e37278b0edb0.camel@mediatek.com \
--to=morris.pan@mediatek.com \
--cc=airlied@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=simona@ffwll.ch \
--cc=srv_heupstream@mediatek.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox