From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Rob Clark" <robdclark@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Cc: kernel@collabora.com, dri-devel <dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Thomas Hellström" <thomas_os@shipmail.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-tegra@vger.kernel.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Dmitry Osipenko" <digetx@gmail.com>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
"Chia-I Wu" <olvaffe@gmail.com>
Subject: Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs
Date: Tue, 16 Aug 2022 14:03:49 +0200 [thread overview]
Message-ID: <2ce5ff0a-9ab2-d146-04db-487a64714fce@gmail.com> (raw)
In-Reply-To: <5f118e10-db7a-a128-1e87-c9dddb65b2ac@collabora.com>
Am 16.08.22 um 13:44 schrieb Dmitry Osipenko:
> [SNIP]
>> The other complication I noticed is that we don't seem to keep around
>> the fd after importing to a GEM handle. And I could imagine that
>> doing so could cause issues with too many fd's. So I guess the best
>> thing is to keep the status quo and let drivers that cannot mmap
>> imported buffers just fail mmap?
> That actually should be all the drivers excluding those that use
> DRM-SHMEM because only DRM-SHMEM uses dma_buf_mmap(), that's why it
> works for Panfrost. I'm pretty sure mmaping of imported GEMs doesn't
> work for the MSM driver, isn't it?
>
> Intel and AMD drivers don't allow to map the imported dma-bufs. Both
> refuse to do the mapping.
>
> Although, AMDGPU "succeeds" to do the mapping using
> AMDGPU_GEM_DOMAIN_GTT, but then touching the mapping causes bus fault,
> hence mapping actually fails. I think it might be the AMDGPU
> driver/libdrm bug, haven't checked yet.
That's then certainly broken somehow. Amdgpu should nerve ever have
allowed to mmap() imported DMA-bufs and the last time I check it didn't.
Regards,
Christian.
>
> So we're back to the point that neither of DRM drivers need to map
> imported dma-bufs and this was never tested. In this case this patch is
> valid, IMO.
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-08-16 12:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220701090240.1896131-1-dmitry.osipenko@collabora.com>
[not found] ` <20220701090240.1896131-2-dmitry.osipenko@collabora.com>
2022-07-05 11:33 ` [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error Christian König via Virtualization
2022-08-09 16:44 ` Daniel Vetter
2022-08-10 6:52 ` Christian König via Virtualization
2022-08-10 8:33 ` Daniel Vetter
2022-08-10 9:04 ` Christian König via Virtualization
[not found] ` <20220701090240.1896131-3-dmitry.osipenko@collabora.com>
2022-07-05 11:39 ` [PATCH v8 2/2] drm/gem: Don't map imported GEMs Christian König via Virtualization
2022-07-05 21:48 ` Rob Clark
[not found] ` <2a646ce4-c2ec-3b11-77a0-cc720afd6fe1@collabora.com>
2022-08-10 11:47 ` Daniel Vetter
2022-08-10 15:08 ` Rob Clark
[not found] ` <9674d00e-c0d6-ceba-feab-5dc475bda694@collabora.com>
2022-08-10 22:03 ` Rob Clark
[not found] ` <fc019528-7ec7-9e5b-1b6d-c44da14346cf@collabora.com>
2022-08-10 23:19 ` Rob Clark
[not found] ` <73b51dde-689f-64ce-a1c8-0d7c84a2ed66@collabora.com>
2022-08-12 14:57 ` Rob Clark
2022-08-12 15:01 ` Rob Clark
[not found] ` <5f118e10-db7a-a128-1e87-c9dddb65b2ac@collabora.com>
2022-08-16 12:03 ` Christian König [this message]
[not found] ` <cf8cd8da-08d2-5e70-a239-2a67da37c9ea@collabora.com>
[not found] ` <e9bde303-6474-aa0b-7880-cf7d8b163983@collabora.com>
2022-08-23 10:01 ` Christian König
2022-08-23 16:47 ` Rob Clark
[not found] ` <bab5a55b-cbd3-4119-af39-794e38f5a0ee@collabora.com>
2022-09-11 18:00 ` Rob Clark
2022-08-16 22:18 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce5ff0a-9ab2-d146-04db-487a64714fce@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gurchetansingh@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=robdclark@gmail.com \
--cc=thomas_os@shipmail.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).