From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Jason Wang" <jasowang@redhat.com>,
"Xie Yongji" <xieyongji@bytedance.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Anders Roxell" <anders.roxell@linaro.org>,
"Marco Crivellari" <marco.crivellari@suse.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vduse: fix compat handling for VDUSE_IOTLB_GET_FD/VDUSE_VQ_GET_INFO
Date: Mon, 02 Feb 2026 23:54:17 +0100 [thread overview]
Message-ID: <34d3ce77-84b2-476c-a678-e092831041ae@app.fastmail.com> (raw)
In-Reply-To: <20260202114412-mutt-send-email-mst@kernel.org>
On Mon, Feb 2, 2026, at 17:45, Michael S. Tsirkin wrote:
> On Mon, Feb 02, 2026 at 12:59:03PM +0100, Arnd Bergmann wrote:
>
> I think .compat_ioctl would be cleaner frankly. Just look at
> all the ifdefery. And who knows what broken-ness userspace
> comes up with with this approach. Better use the standard approach.
Sent now.
I'm not sure it's much better because there is quite a bit of
code duplication, and reducing that would be a larger rework.
It may be best to hold off on patch 2 for the coming merge window
since the compat ioctl code has apparently always been broken for
x86 here.
I hope we can at least get patch 1/2 merged along with the
new code though, otherwise it would get a lot harder to sort
it out properly, with the v2 struct members overlapping the
old padding fields.
Arnd
next prev parent reply other threads:[~2026-02-02 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 9:59 [PATCH 1/2] vduse: avoid adding implicit padding Arnd Bergmann
2026-02-02 9:59 ` [PATCH 2/2] vduse: fix compat handling for VDUSE_IOTLB_GET_FD/VDUSE_VQ_GET_INFO Arnd Bergmann
2026-02-02 11:34 ` Eugenio Perez Martin
2026-02-02 11:59 ` Arnd Bergmann
2026-02-02 16:45 ` Michael S. Tsirkin
2026-02-02 22:54 ` Arnd Bergmann [this message]
2026-02-03 10:35 ` Michael S. Tsirkin
2026-02-03 14:13 ` Eugenio Perez Martin
2026-02-03 14:41 ` Arnd Bergmann
2026-02-03 15:03 ` Eugenio Perez Martin
2026-02-02 11:28 ` [PATCH 1/2] vduse: avoid adding implicit padding Eugenio Perez Martin
2026-02-02 11:50 ` Eugenio Perez Martin
2026-02-02 12:06 ` Arnd Bergmann
2026-02-03 7:00 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d3ce77-84b2-476c-a678-e092831041ae@app.fastmail.com \
--to=arnd@arndb.de \
--cc=anders.roxell@linaro.org \
--cc=arnd@kernel.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox